From: Dave Jones <davej@redhat.com>
To: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: Dmitry Eremin-Solenikov <dbaryshkov@gmail.com>,
linuxppc-dev@lists.ozlabs.org, cpufreq@vger.kernel.org,
Paul Mackerras <paulus@samba.org>
Subject: Re: [PATCH 2/2] Add cpufreq driver for Momentum Maple boards
Date: Tue, 28 Jun 2011 23:43:49 -0400 [thread overview]
Message-ID: <20110629034348.GB30973@redhat.com> (raw)
In-Reply-To: <1309318110.32158.520.camel@pasglop>
On Wed, Jun 29, 2011 at 01:28:30PM +1000, Ben Herrenschmidt wrote:
> Before I comment on this last one, a quick Q. for Dave: Do you want to
> handle this or should I merge it via powerpc.git ? (It depends on
> another change to the arch code to expose the SCOM functions that it
> uses, and that patch is going to be in my -next branch).
If you're carrying the dependancy, it sounds like it would make more sense
for you to carry this too. There are some changes to the Kconfig/Makefile
in drivers/cpufreq in my tree for 3.1 already, so you might get a collision
when both trees end up in next & subsequently Linus' tree. Just trivial changes though.
> > ---
> > drivers/cpufreq/Kconfig | 5 +
> > drivers/cpufreq/Kconfig.powerpc | 7 +
> > drivers/cpufreq/Makefile | 5 +
> > drivers/cpufreq/maple-cpufreq.c | 314 +++++++++++++++++++++++++++++++++++++++
>
> If we're going to have a Kconfig.powerpc, should we maybe just have a
> powerpc subdirectory instead with the driver in it ?
>
> I'm happy at some later point to try moving some of my other ones there.
So far we haven't bothered with additional subarch drivers/ directories for x86/arm.
I'm not against the idea. As more archs move over, I could see drivers/cpufreq/
getting more cluttered.
Dave
WARNING: multiple messages have this Message-ID (diff)
From: Dave Jones <davej@redhat.com>
To: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: Dmitry Eremin-Solenikov <dbaryshkov@gmail.com>,
Paul Mackerras <paulus@samba.org>,
linuxppc-dev@lists.ozlabs.org, cpufreq@vger.kernel.org
Subject: Re: [PATCH 2/2] Add cpufreq driver for Momentum Maple boards
Date: Tue, 28 Jun 2011 23:43:49 -0400 [thread overview]
Message-ID: <20110629034348.GB30973@redhat.com> (raw)
In-Reply-To: <1309318110.32158.520.camel@pasglop>
On Wed, Jun 29, 2011 at 01:28:30PM +1000, Ben Herrenschmidt wrote:
> Before I comment on this last one, a quick Q. for Dave: Do you want to
> handle this or should I merge it via powerpc.git ? (It depends on
> another change to the arch code to expose the SCOM functions that it
> uses, and that patch is going to be in my -next branch).
If you're carrying the dependancy, it sounds like it would make more sense
for you to carry this too. There are some changes to the Kconfig/Makefile
in drivers/cpufreq in my tree for 3.1 already, so you might get a collision
when both trees end up in next & subsequently Linus' tree. Just trivial changes though.
> > ---
> > drivers/cpufreq/Kconfig | 5 +
> > drivers/cpufreq/Kconfig.powerpc | 7 +
> > drivers/cpufreq/Makefile | 5 +
> > drivers/cpufreq/maple-cpufreq.c | 314 +++++++++++++++++++++++++++++++++++++++
>
> If we're going to have a Kconfig.powerpc, should we maybe just have a
> powerpc subdirectory instead with the driver in it ?
>
> I'm happy at some later point to try moving some of my other ones there.
So far we haven't bothered with additional subarch drivers/ directories for x86/arm.
I'm not against the idea. As more archs move over, I could see drivers/cpufreq/
getting more cluttered.
Dave
next prev parent reply other threads:[~2011-06-29 3:43 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-17 13:10 [PATCH 1/2] ppc: enable scom access functions on Maple Dmitry Eremin-Solenikov
2011-06-17 13:10 ` Dmitry Eremin-Solenikov
2011-06-17 13:10 ` [PATCH 2/2] Add cpufreq driver for Momentum Maple boards Dmitry Eremin-Solenikov
2011-06-17 13:10 ` Dmitry Eremin-Solenikov
2011-06-29 3:28 ` Benjamin Herrenschmidt
2011-06-29 3:28 ` Benjamin Herrenschmidt
2011-06-29 3:43 ` Dave Jones [this message]
2011-06-29 3:43 ` Dave Jones
2011-06-29 8:40 ` Dmitry Eremin-Solenikov
2011-06-29 8:40 ` Dmitry Eremin-Solenikov
2011-06-29 8:54 ` Benjamin Herrenschmidt
2011-06-29 8:54 ` Benjamin Herrenschmidt
2011-06-29 18:25 ` kevin diggs
2011-06-29 18:09 ` kevin diggs
2011-06-29 18:09 ` kevin diggs
2011-06-29 20:58 ` Dmitry Eremin-Solenikov
2011-06-29 20:58 ` Dmitry Eremin-Solenikov
2011-06-30 18:23 ` kevin diggs
2011-06-30 18:23 ` kevin diggs
2011-06-30 18:30 ` Dave Jones
2011-06-30 18:30 ` Dave Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110629034348.GB30973@redhat.com \
--to=davej@redhat.com \
--cc=benh@kernel.crashing.org \
--cc=cpufreq@vger.kernel.org \
--cc=dbaryshkov@gmail.com \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.