From: Tony Lindgren <tony@atomide.com>
To: Grazvydas Ignotas <notasas@gmail.com>
Cc: Vimal Singh <vimal.newwork@gmail.com>,
linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] omap: cleanup NAND platform data
Date: Wed, 29 Jun 2011 01:12:43 -0700 [thread overview]
Message-ID: <20110629081243.GA23145@atomide.com> (raw)
In-Reply-To: <BANLkTimXxOcr4q2fkD0hjq4pMVPC0StBFw@mail.gmail.com>
* Grazvydas Ignotas <notasas@gmail.com> [110603 15:01]:
> On Sat, Jun 4, 2011 at 12:14 AM, Vimal Singh <vimal.newwork@gmail.com> wrote:
> > On Sat, Jun 4, 2011 at 1:26 AM, Grazvydas Ignotas <notasas@gmail.com> wrote:
> >>
> >> -static int omap2_nand_gpmc_retime(void)
> >> +static int omap2_nand_gpmc_retime(struct omap_nand_platform_data *gpmc_nand_data)
> >> {
> >> struct gpmc_timings t;
> >> int err;
> >> @@ -83,13 +81,11 @@ static int omap2_nand_gpmc_retime(void)
> >> return 0;
> >> }
> >>
> >> -int __init gpmc_nand_init(struct omap_nand_platform_data *_nand_data)
> >> +int __init gpmc_nand_init(struct omap_nand_platform_data *gpmc_nand_data)
> >> {
> >> int err = 0;
> >> struct device *dev = &gpmc_nand_device.dev;
> >>
> >> - gpmc_nand_data = _nand_data;
> >> - gpmc_nand_data->nand_setup = omap2_nand_gpmc_retime;
> >
> > Purpose of doing this was to be able to utilise
> > 'omap2_nand_gpmc_retime', when DVFS is ready to use it,
> > for changing timing parameter dynamically when a frequency change is done.
>
> Well but it seems currently ...retime() only does single static
> configuration, I guess when it's updated to do DVFS stuff callback can
> easily be added back..
Applying this into devel-cleanup.
Regards,
Tony
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: tony@atomide.com (Tony Lindgren)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] omap: cleanup NAND platform data
Date: Wed, 29 Jun 2011 01:12:43 -0700 [thread overview]
Message-ID: <20110629081243.GA23145@atomide.com> (raw)
In-Reply-To: <BANLkTimXxOcr4q2fkD0hjq4pMVPC0StBFw@mail.gmail.com>
* Grazvydas Ignotas <notasas@gmail.com> [110603 15:01]:
> On Sat, Jun 4, 2011 at 12:14 AM, Vimal Singh <vimal.newwork@gmail.com> wrote:
> > On Sat, Jun 4, 2011 at 1:26 AM, Grazvydas Ignotas <notasas@gmail.com> wrote:
> >>
> >> -static int omap2_nand_gpmc_retime(void)
> >> +static int omap2_nand_gpmc_retime(struct omap_nand_platform_data *gpmc_nand_data)
> >> ?{
> >> ? ? ? ?struct gpmc_timings t;
> >> ? ? ? ?int err;
> >> @@ -83,13 +81,11 @@ static int omap2_nand_gpmc_retime(void)
> >> ? ? ? ?return 0;
> >> ?}
> >>
> >> -int __init gpmc_nand_init(struct omap_nand_platform_data *_nand_data)
> >> +int __init gpmc_nand_init(struct omap_nand_platform_data *gpmc_nand_data)
> >> ?{
> >> ? ? ? ?int err = 0;
> >> ? ? ? ?struct device *dev = &gpmc_nand_device.dev;
> >>
> >> - ? ? ? gpmc_nand_data = _nand_data;
> >> - ? ? ? gpmc_nand_data->nand_setup = omap2_nand_gpmc_retime;
> >
> > Purpose of doing this was to be able to utilise
> > 'omap2_nand_gpmc_retime', when DVFS is ready to use it,
> > for changing timing parameter dynamically when a frequency change is done.
>
> Well but it seems currently ...retime() only does single static
> configuration, I guess when it's updated to do DVFS stuff callback can
> easily be added back..
Applying this into devel-cleanup.
Regards,
Tony
next prev parent reply other threads:[~2011-06-29 8:12 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-03 19:56 [PATCH] omap: cleanup NAND platform data Grazvydas Ignotas
2011-06-03 19:56 ` Grazvydas Ignotas
2011-06-03 21:14 ` Vimal Singh
2011-06-03 21:14 ` Vimal Singh
2011-06-03 22:05 ` Grazvydas Ignotas
2011-06-03 22:05 ` Grazvydas Ignotas
2011-06-29 8:12 ` Tony Lindgren [this message]
2011-06-29 8:12 ` Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110629081243.GA23145@atomide.com \
--to=tony@atomide.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=notasas@gmail.com \
--cc=vimal.newwork@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.