From: Vasiliy Kulikov <segoon@openwall.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: kernel-hardening@lists.openwall.com,
Randy Dunlap <rdunlap@xenotime.net>,
"Eric W. Biederman" <ebiederm@xmission.com>,
"Serge E. Hallyn" <serge.hallyn@canonical.com>,
Daniel Lezcano <daniel.lezcano@free.fr>,
Oleg Nesterov <oleg@redhat.com>, Tejun Heo <tj@kernel.org>,
Ingo Molnar <mingo@elte.hu>,
linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-security-module@vger.kernel.org
Subject: [kernel-hardening] Re: [RFC] ipc: introduce shm_rmid_forced sysctl
Date: Thu, 30 Jun 2011 17:08:02 +0400 [thread overview]
Message-ID: <20110630130802.GA12620@albatros> (raw)
In-Reply-To: <20110630092103.GA4252@albatros>
On Thu, Jun 30, 2011 at 13:21 +0400, Vasiliy Kulikov wrote:
> > Perhaps shm_rmid_forced should have had bool type.
>
> OK. The sysctl handler should parse it OK if feed it with sizeof(bool).
I was wrong, maxlen must not be less than sizeof(int), it makes sense
for arrays only. So, it is kept being int.
--
Vasiliy Kulikov
http://www.openwall.com - bringing security into open computing environments
WARNING: multiple messages have this Message-ID (diff)
From: Vasiliy Kulikov <segoon@openwall.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: kernel-hardening@lists.openwall.com,
Randy Dunlap <rdunlap@xenotime.net>,
"Eric W. Biederman" <ebiederm@xmission.com>,
"Serge E. Hallyn" <serge.hallyn@canonical.com>,
Daniel Lezcano <daniel.lezcano@free.fr>,
Oleg Nesterov <oleg@redhat.com>, Tejun Heo <tj@kernel.org>,
Ingo Molnar <mingo@elte.hu>,
linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-security-module@vger.kernel.org
Subject: Re: [RFC] ipc: introduce shm_rmid_forced sysctl
Date: Thu, 30 Jun 2011 17:08:02 +0400 [thread overview]
Message-ID: <20110630130802.GA12620@albatros> (raw)
In-Reply-To: <20110630092103.GA4252@albatros>
On Thu, Jun 30, 2011 at 13:21 +0400, Vasiliy Kulikov wrote:
> > Perhaps shm_rmid_forced should have had bool type.
>
> OK. The sysctl handler should parse it OK if feed it with sizeof(bool).
I was wrong, maxlen must not be less than sizeof(int), it makes sense
for arrays only. So, it is kept being int.
--
Vasiliy Kulikov
http://www.openwall.com - bringing security into open computing environments
next prev parent reply other threads:[~2011-06-30 13:08 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-22 15:25 [kernel-hardening] [RFC] ipc: introduce shm_rmid_forced sysctl Vasiliy Kulikov
2011-06-22 15:25 ` Vasiliy Kulikov
2011-06-22 16:03 ` [kernel-hardening] " Randy Dunlap
2011-06-22 16:03 ` Randy Dunlap
2011-06-29 22:14 ` [kernel-hardening] " Andrew Morton
2011-06-29 22:14 ` Andrew Morton
2011-06-30 9:21 ` [kernel-hardening] " Vasiliy Kulikov
2011-06-30 9:21 ` Vasiliy Kulikov
2011-06-30 13:08 ` Vasiliy Kulikov [this message]
2011-06-30 13:08 ` Vasiliy Kulikov
2011-07-01 11:25 ` [kernel-hardening] " Ingo Molnar
2011-07-01 11:25 ` Ingo Molnar
2011-07-01 11:35 ` [kernel-hardening] " Vasiliy Kulikov
2011-07-01 11:35 ` Vasiliy Kulikov
2011-07-01 12:04 ` [kernel-hardening] " Ingo Molnar
2011-07-01 12:04 ` Ingo Molnar
2011-07-01 14:18 ` [kernel-hardening] " Alan Cox
2011-07-01 14:18 ` Alan Cox
2011-07-03 19:38 ` [kernel-hardening] " Ingo Molnar
2011-07-03 19:38 ` Ingo Molnar
2011-07-03 21:25 ` [kernel-hardening] " Alan Cox
2011-07-03 21:25 ` Alan Cox
2011-07-02 16:50 ` [kernel-hardening] " Solar Designer
2011-07-02 16:50 ` Solar Designer
2011-07-02 17:31 ` [kernel-hardening] " Solar Designer
2011-07-02 17:31 ` Solar Designer
2011-07-04 15:08 ` [kernel-hardening] " Oleg Nesterov
2011-07-04 15:08 ` Oleg Nesterov
2011-07-04 15:36 ` [kernel-hardening] " Vasiliy Kulikov
2011-07-04 15:36 ` Vasiliy Kulikov
2011-07-04 15:44 ` [kernel-hardening] " Oleg Nesterov
2011-07-04 15:44 ` Oleg Nesterov
2011-07-04 16:06 ` [kernel-hardening] " Vasiliy Kulikov
2011-07-04 16:06 ` Vasiliy Kulikov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110630130802.GA12620@albatros \
--to=segoon@openwall.com \
--cc=akpm@linux-foundation.org \
--cc=daniel.lezcano@free.fr \
--cc=ebiederm@xmission.com \
--cc=kernel-hardening@lists.openwall.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=oleg@redhat.com \
--cc=rdunlap@xenotime.net \
--cc=serge.hallyn@canonical.com \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.