All of lore.kernel.org
 help / color / mirror / Atom feed
From: Anton Blanchard <anton@samba.org>
To: David Ahern <dsahern@gmail.com>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>,
	Paul Mackerras <paulus@samba.org>, Ingo Molnar <mingo@elte.hu>,
	Arnaldo Carvalho de Melo <acme@ghostprotocols.net>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] perf report/annotate: Add option to specify a CPU range
Date: Thu, 30 Jun 2011 13:15:09 +1000	[thread overview]
Message-ID: <20110630131509.673fa438@kryten> (raw)
In-Reply-To: <4E0B69EC.70009@gmail.com>


Hi David,

> > Add an option to perf report and perf annotate to specify which CPUs
> 
> What about perf-script?

Good point, I added the option to perf script.

> > +	if (cpu_list && !test_bit(sample->cpu, cpu_bitmap))
> > +		return 0;
> > +
> 
> Need to check that the SAMPLE_CPU attribute is set for the event for
> which the sample is generated; see builtin-script.c,
> perf_evsel__check_attr().

Added.

> This option should be added to the Documentation file,
> Documentation/perf-report.txt

Added. Updated patch on the way.

Thanks,
Anton

  reply	other threads:[~2011-06-30  3:15 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-06-29  5:07 [PATCH] perf report/annotate: Add option to specify a CPU range Anton Blanchard
2011-06-29 18:07 ` David Ahern
2011-06-30  3:15   ` Anton Blanchard [this message]
2011-06-30  3:16   ` Anton Blanchard
2011-06-30  3:56     ` David Ahern
2011-07-01 11:16       ` Ingo Molnar
2011-07-04 11:51         ` Anton Blanchard
2011-07-04 11:57         ` [PATCH] perf report/annotate/script: " Anton Blanchard
2011-07-05 12:56           ` [tip:perf/core] " tip-bot for Anton Blanchard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110630131509.673fa438@kryten \
    --to=anton@samba.org \
    --cc=a.p.zijlstra@chello.nl \
    --cc=acme@ghostprotocols.net \
    --cc=dsahern@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=paulus@samba.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.