All of lore.kernel.org
 help / color / mirror / Atom feed
From: Marek Vasut <marek.vasut@gmail.com>
To: Stanislav Brabec <utx@penguin.cz>
Cc: linux-arm-kernel@lists.infradead.org,
	zaurus-devel@lists.linuxtogo.org,
	spi-devel-general@lists.sourceforge.net,
	Igor Grinberg <grinberg@compulab.co.il>,
	vapier@gentoo.org, khilman@deeprootsystems.com,
	dmitry.torokhov@gmail.com, linux-kernel@vger.kernel.org,
	pavel@ucw.cz, linux-input@vger.kernel.org, eric.y.miao@gmail.com,
	akpm@linux-foundation.org, broonie@opensource.wolfsonmicro.com,
	Pavel Herrmann <morpheus.ibis@gmail.com>
Subject: Re: kernel panic in spi_complete() on spitz (PXA270)
Date: Thu, 30 Jun 2011 17:09:48 +0200	[thread overview]
Message-ID: <201106301709.48818.marek.vasut@gmail.com> (raw)
In-Reply-To: <1309445118.4406.47.camel@oct.suse.cz>

On Thursday, June 30, 2011 04:45:18 PM Stanislav Brabec wrote:
> Marek Vasut wrote:
> > On Thursday, June 23, 2011 06:09:40 PM Stanislav Brabec wrote:
> > > Hallo.
> > > 
> > > These Oops and kernel panic were observed on a Zaurus (spitz) machine
> > > (ARMv5, PXA270).
> > 
> > Looks similar to "Re: [PATCH v2] Input: Make ADS7846 independent on
> > regulator"
> 
> I don't see any trace in that thread. But yes, I was testing your patch
> from this thread. Without it, ADS7846 does not work on spitz (ADS7846
> does not have any dedicated regulator there). I want to
> add .needs_regulator bool to ads7846.c and send the patch again to the
> list.
> 
> After sending the trace I was able to reproduced it several times by
> attaching of external charger.
> 
> Then I tried to apply "[PATCH] MAX1111: Fix race condition causing NULL
> pointer exception", connected charger that periodically disconnects and
> not seen the crash again. No OOPS was seen after ~100 reconnects.
> 
> So I guess that MAX1111 AC voltage reading (via SPI) was involved in an
> incorrect moment and race happened there and your MAX1111 race condition
> fix fixes it.

It's not mine, it's from Pavel Herrmann actually ;-)

But yes, it's likely either this or the regulator stuff again (which I believed 
was fixed).

WARNING: multiple messages have this Message-ID (diff)
From: marek.vasut@gmail.com (Marek Vasut)
To: linux-arm-kernel@lists.infradead.org
Subject: kernel panic in spi_complete() on spitz (PXA270)
Date: Thu, 30 Jun 2011 17:09:48 +0200	[thread overview]
Message-ID: <201106301709.48818.marek.vasut@gmail.com> (raw)
In-Reply-To: <1309445118.4406.47.camel@oct.suse.cz>

On Thursday, June 30, 2011 04:45:18 PM Stanislav Brabec wrote:
> Marek Vasut wrote:
> > On Thursday, June 23, 2011 06:09:40 PM Stanislav Brabec wrote:
> > > Hallo.
> > > 
> > > These Oops and kernel panic were observed on a Zaurus (spitz) machine
> > > (ARMv5, PXA270).
> > 
> > Looks similar to "Re: [PATCH v2] Input: Make ADS7846 independent on
> > regulator"
> 
> I don't see any trace in that thread. But yes, I was testing your patch
> from this thread. Without it, ADS7846 does not work on spitz (ADS7846
> does not have any dedicated regulator there). I want to
> add .needs_regulator bool to ads7846.c and send the patch again to the
> list.
> 
> After sending the trace I was able to reproduced it several times by
> attaching of external charger.
> 
> Then I tried to apply "[PATCH] MAX1111: Fix race condition causing NULL
> pointer exception", connected charger that periodically disconnects and
> not seen the crash again. No OOPS was seen after ~100 reconnects.
> 
> So I guess that MAX1111 AC voltage reading (via SPI) was involved in an
> incorrect moment and race happened there and your MAX1111 race condition
> fix fixes it.

It's not mine, it's from Pavel Herrmann actually ;-)

But yes, it's likely either this or the regulator stuff again (which I believed 
was fixed).

WARNING: multiple messages have this Message-ID (diff)
From: Marek Vasut <marek.vasut@gmail.com>
To: Stanislav Brabec <utx@penguin.cz>
Cc: linux-arm-kernel@lists.infradead.org,
	zaurus-devel@www.linuxtogo.org,
	spi-devel-general@lists.sourceforge.net,
	Igor Grinberg <grinberg@compulab.co.il>,
	vapier@gentoo.org, khilman@deeprootsystems.com,
	dmitry.torokhov@gmail.com, linux-kernel@vger.kernel.org,
	pavel@ucw.cz, linux-input@vger.kernel.org, eric.y.miao@gmail.com,
	akpm@linux-foundation.org, broonie@opensource.wolfsonmicro.com,
	Pavel Herrmann <morpheus.ibis@gmail.com>
Subject: Re: kernel panic in spi_complete() on spitz (PXA270)
Date: Thu, 30 Jun 2011 17:09:48 +0200	[thread overview]
Message-ID: <201106301709.48818.marek.vasut@gmail.com> (raw)
In-Reply-To: <1309445118.4406.47.camel@oct.suse.cz>

On Thursday, June 30, 2011 04:45:18 PM Stanislav Brabec wrote:
> Marek Vasut wrote:
> > On Thursday, June 23, 2011 06:09:40 PM Stanislav Brabec wrote:
> > > Hallo.
> > > 
> > > These Oops and kernel panic were observed on a Zaurus (spitz) machine
> > > (ARMv5, PXA270).
> > 
> > Looks similar to "Re: [PATCH v2] Input: Make ADS7846 independent on
> > regulator"
> 
> I don't see any trace in that thread. But yes, I was testing your patch
> from this thread. Without it, ADS7846 does not work on spitz (ADS7846
> does not have any dedicated regulator there). I want to
> add .needs_regulator bool to ads7846.c and send the patch again to the
> list.
> 
> After sending the trace I was able to reproduced it several times by
> attaching of external charger.
> 
> Then I tried to apply "[PATCH] MAX1111: Fix race condition causing NULL
> pointer exception", connected charger that periodically disconnects and
> not seen the crash again. No OOPS was seen after ~100 reconnects.
> 
> So I guess that MAX1111 AC voltage reading (via SPI) was involved in an
> incorrect moment and race happened there and your MAX1111 race condition
> fix fixes it.

It's not mine, it's from Pavel Herrmann actually ;-)

But yes, it's likely either this or the regulator stuff again (which I believed 
was fixed).

  reply	other threads:[~2011-06-30 15:09 UTC|newest]

Thread overview: 38+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-06-23 16:09 kernel panic in spi_complete() on spitz (PXA270) Stanislav Brabec
2011-06-23 16:09 ` Stanislav Brabec
2011-06-30 11:52 ` Marek Vasut
2011-06-30 11:52   ` Marek Vasut
2011-06-30 11:52   ` Marek Vasut
     [not found]   ` <201106301352.21684.marek.vasut-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2011-06-30 14:45     ` Stanislav Brabec
2011-06-30 14:45       ` Stanislav Brabec
2011-06-30 14:45       ` Stanislav Brabec
2011-06-30 15:09       ` Marek Vasut [this message]
2011-06-30 15:09         ` Marek Vasut
2011-06-30 15:09         ` Marek Vasut
2011-06-30 15:36         ` Pavel Herrmann
2011-06-30 15:36           ` Pavel Herrmann
2011-06-30 15:36           ` Pavel Herrmann
2011-06-30 16:22           ` Stanislav Brabec
2011-06-30 16:22             ` Stanislav Brabec
2011-06-30 16:22             ` Stanislav Brabec
2011-06-30 15:25       ` Igor Grinberg
2011-06-30 15:25         ` Igor Grinberg
2011-06-30 15:25         ` Igor Grinberg
2011-06-30 15:59         ` Mark Brown
2011-06-30 15:59           ` Mark Brown
2011-06-30 15:59           ` Mark Brown
     [not found]         ` <4E0C957F.8080807-UTxiZqZC01RS1MOuV/RT9w@public.gmane.org>
2011-06-30 16:13           ` Stanislav Brabec
2011-06-30 16:13             ` Stanislav Brabec
2011-06-30 16:13             ` Stanislav Brabec
2011-06-30 17:40             ` Igor Grinberg
2011-06-30 17:40               ` Igor Grinberg
2011-06-30 17:40               ` Igor Grinberg
2011-06-30 18:01               ` Mark Brown
2011-06-30 18:01                 ` Mark Brown
2011-06-30 18:01                 ` Mark Brown
2011-06-30 20:50                 ` Igor Grinberg
2011-06-30 20:50                   ` Igor Grinberg
2011-06-30 20:50                   ` Igor Grinberg
     [not found]                   ` <4E0CE189.1020000-UTxiZqZC01RS1MOuV/RT9w@public.gmane.org>
2011-06-30 22:20                     ` Stanislav Brabec
2011-06-30 22:20                       ` Stanislav Brabec
2011-06-30 22:20                       ` Stanislav Brabec

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201106301709.48818.marek.vasut@gmail.com \
    --to=marek.vasut@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=broonie@opensource.wolfsonmicro.com \
    --cc=dmitry.torokhov@gmail.com \
    --cc=eric.y.miao@gmail.com \
    --cc=grinberg@compulab.co.il \
    --cc=khilman@deeprootsystems.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=morpheus.ibis@gmail.com \
    --cc=pavel@ucw.cz \
    --cc=spi-devel-general@lists.sourceforge.net \
    --cc=utx@penguin.cz \
    --cc=vapier@gentoo.org \
    --cc=zaurus-devel@lists.linuxtogo.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.