* [PATCH] ASoC: Improve error reporting in Speyside WM8962 driver
@ 2011-06-29 21:18 Mark Brown
2011-06-30 16:56 ` Lu Guanqun
0 siblings, 1 reply; 5+ messages in thread
From: Mark Brown @ 2011-06-29 21:18 UTC (permalink / raw)
To: Liam Girdwood; +Cc: alsa-devel, patches, Mark Brown
Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
---
sound/soc/samsung/speyside_wm8962.c | 12 ++++++++----
1 files changed, 8 insertions(+), 4 deletions(-)
diff --git a/sound/soc/samsung/speyside_wm8962.c b/sound/soc/samsung/speyside_wm8962.c
index c0ba0bf..55233e8 100644
--- a/sound/soc/samsung/speyside_wm8962.c
+++ b/sound/soc/samsung/speyside_wm8962.c
@@ -30,14 +30,16 @@ static int speyside_wm8962_set_bias_level(struct snd_soc_card *card,
WM8962_FLL_MCLK, 32768,
44100 * 256);
if (ret < 0)
- pr_err("Failed to start FLL\n");
+ pr_err("Failed to start FLL: %d\n");
ret = snd_soc_dai_set_sysclk(codec_dai,
WM8962_SYSCLK_FLL,
44100 * 256,
SND_SOC_CLOCK_IN);
- if (ret < 0)
+ if (ret < 0) {
+ pr_err("Failed to set SYSCLK: %d\n");
return ret;
+ }
}
break;
@@ -59,13 +61,15 @@ static int speyside_wm8962_set_bias_level_post(struct snd_soc_card *card,
case SND_SOC_BIAS_STANDBY:
ret = snd_soc_dai_set_sysclk(codec_dai, WM8962_SYSCLK_MCLK,
32768, SND_SOC_CLOCK_IN);
- if (ret < 0)
+ if (ret < 0) {
+ pr_err("Failed to switch away from FLL: %d\n", ret);
return ret;
+ }
ret = snd_soc_dai_set_pll(codec_dai, WM8962_FLL,
0, 0, 0);
if (ret < 0) {
- pr_err("Failed to stop FLL\n");
+ pr_err("Failed to stop FLL: %d\n", ret);
return ret;
}
break;
--
1.7.5.4
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] ASoC: Improve error reporting in Speyside WM8962 driver
2011-06-29 21:18 [PATCH] ASoC: Improve error reporting in Speyside WM8962 driver Mark Brown
@ 2011-06-30 16:56 ` Lu Guanqun
2011-06-30 18:02 ` Mark Brown
0 siblings, 1 reply; 5+ messages in thread
From: Lu Guanqun @ 2011-06-30 16:56 UTC (permalink / raw)
To: Mark Brown
Cc: alsa-devel@alsa-project.org, patches@opensource.wolfsonmicro.com,
Liam Girdwood
On Thu, Jun 30, 2011 at 05:18:51AM +0800, Mark Brown wrote:
> if (ret < 0)
> - pr_err("Failed to start FLL\n");
> + pr_err("Failed to start FLL: %d\n");
missed 'ret' here? :)
--
guanqun
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] ASoC: Improve error reporting in Speyside WM8962 driver
2011-06-30 18:02 ` Mark Brown
@ 2011-06-30 18:02 ` Lu Guanqun
2011-06-30 18:08 ` Liam Girdwood
1 sibling, 0 replies; 5+ messages in thread
From: Lu Guanqun @ 2011-06-30 18:02 UTC (permalink / raw)
To: Mark Brown
Cc: alsa-devel@alsa-project.org, patches@opensource.wolfsonmicro.com,
Liam Girdwood
On Fri, Jul 01, 2011 at 02:02:28AM +0800, Mark Brown wrote:
> On Fri, Jul 01, 2011 at 12:56:17AM +0800, Lu Guanqun wrote:
> > On Thu, Jun 30, 2011 at 05:18:51AM +0800, Mark Brown wrote:
> > > if (ret < 0)
> > > - pr_err("Failed to start FLL\n");
> > > + pr_err("Failed to start FLL: %d\n");
>
> > missed 'ret' here? :)
>
> Fixed locally, Liam I'll not bother reposting if you're otherwise OK?
I just randomly read the patches and spotted it... Sorry for the noise. :)
--
guanqun
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] ASoC: Improve error reporting in Speyside WM8962 driver
2011-06-30 16:56 ` Lu Guanqun
@ 2011-06-30 18:02 ` Mark Brown
2011-06-30 18:02 ` Lu Guanqun
2011-06-30 18:08 ` Liam Girdwood
0 siblings, 2 replies; 5+ messages in thread
From: Mark Brown @ 2011-06-30 18:02 UTC (permalink / raw)
To: Lu Guanqun
Cc: alsa-devel@alsa-project.org, patches@opensource.wolfsonmicro.com,
Liam Girdwood
On Fri, Jul 01, 2011 at 12:56:17AM +0800, Lu Guanqun wrote:
> On Thu, Jun 30, 2011 at 05:18:51AM +0800, Mark Brown wrote:
> > if (ret < 0)
> > - pr_err("Failed to start FLL\n");
> > + pr_err("Failed to start FLL: %d\n");
> missed 'ret' here? :)
Fixed locally, Liam I'll not bother reposting if you're otherwise OK?
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] ASoC: Improve error reporting in Speyside WM8962 driver
2011-06-30 18:02 ` Mark Brown
2011-06-30 18:02 ` Lu Guanqun
@ 2011-06-30 18:08 ` Liam Girdwood
1 sibling, 0 replies; 5+ messages in thread
From: Liam Girdwood @ 2011-06-30 18:08 UTC (permalink / raw)
To: Mark Brown
Cc: alsa-devel@alsa-project.org, Lu Guanqun,
patches@opensource.wolfsonmicro.com
On 30/06/11 19:02, Mark Brown wrote:
> On Fri, Jul 01, 2011 at 12:56:17AM +0800, Lu Guanqun wrote:
>> On Thu, Jun 30, 2011 at 05:18:51AM +0800, Mark Brown wrote:
>>> if (ret < 0)
>>> - pr_err("Failed to start FLL\n");
>>> + pr_err("Failed to start FLL: %d\n");
>
>> missed 'ret' here? :)
>
> Fixed locally, Liam I'll not bother reposting if you're otherwise OK?
I'm OK.
Liam
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2011-06-30 18:08 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-06-29 21:18 [PATCH] ASoC: Improve error reporting in Speyside WM8962 driver Mark Brown
2011-06-30 16:56 ` Lu Guanqun
2011-06-30 18:02 ` Mark Brown
2011-06-30 18:02 ` Lu Guanqun
2011-06-30 18:08 ` Liam Girdwood
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.