* [PATCH] ARM: OMAP: Overo: remove illegal extra call to overo_ads7846_init()
@ 2011-06-17 15:21 ` Daniel Mack
0 siblings, 0 replies; 10+ messages in thread
From: Daniel Mack @ 2011-06-17 15:21 UTC (permalink / raw)
To: linux-arm-kernel; +Cc: tony, linux-omap, Daniel Mack
Signed-off-by: Daniel Mack <zonque@gmail.com>
---
arch/arm/mach-omap2/board-overo.c | 1 -
1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/arch/arm/mach-omap2/board-overo.c b/arch/arm/mach-omap2/board-overo.c
index 175e1ab..110475f 100644
--- a/arch/arm/mach-omap2/board-overo.c
+++ b/arch/arm/mach-omap2/board-overo.c
@@ -568,7 +568,6 @@ static void __init overo_init(void)
usb_musb_init(NULL);
usbhs_init(&usbhs_bdata);
overo_spi_init();
- overo_ads7846_init();
overo_init_smsc911x();
overo_display_init();
overo_init_led();
--
1.7.5.1
^ permalink raw reply related [flat|nested] 10+ messages in thread
* [PATCH] ARM: OMAP: Overo: remove illegal extra call to overo_ads7846_init()
@ 2011-06-17 15:21 ` Daniel Mack
0 siblings, 0 replies; 10+ messages in thread
From: Daniel Mack @ 2011-06-17 15:21 UTC (permalink / raw)
To: linux-arm-kernel
Signed-off-by: Daniel Mack <zonque@gmail.com>
---
arch/arm/mach-omap2/board-overo.c | 1 -
1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/arch/arm/mach-omap2/board-overo.c b/arch/arm/mach-omap2/board-overo.c
index 175e1ab..110475f 100644
--- a/arch/arm/mach-omap2/board-overo.c
+++ b/arch/arm/mach-omap2/board-overo.c
@@ -568,7 +568,6 @@ static void __init overo_init(void)
usb_musb_init(NULL);
usbhs_init(&usbhs_bdata);
overo_spi_init();
- overo_ads7846_init();
overo_init_smsc911x();
overo_display_init();
overo_init_led();
--
1.7.5.1
^ permalink raw reply related [flat|nested] 10+ messages in thread
* Re: [PATCH] ARM: OMAP: Overo: remove illegal extra call to overo_ads7846_init()
2011-06-17 15:21 ` Daniel Mack
@ 2011-06-17 16:03 ` Kevin Hilman
-1 siblings, 0 replies; 10+ messages in thread
From: Kevin Hilman @ 2011-06-17 16:03 UTC (permalink / raw)
To: Daniel Mack; +Cc: linux-arm-kernel, linux-omap, tony
Daniel Mack <zonque@gmail.com> writes:
> Signed-off-by: Daniel Mack <zonque@gmail.com>
Thanks for fixing this, I noticed this recently too.
Please add a descriptive changelog. For example, why is it duplcate?
where is it already done? what commit added the extra call, what
problems does it cause, etc.
Also, your subject says 'illegal', but it's not really illegal. It's just
wrong. :) "remove duplcate call to..." is enough.
Thanks,
Kevin
> ---
> arch/arm/mach-omap2/board-overo.c | 1 -
> 1 files changed, 0 insertions(+), 1 deletions(-)
>
> diff --git a/arch/arm/mach-omap2/board-overo.c b/arch/arm/mach-omap2/board-overo.c
> index 175e1ab..110475f 100644
> --- a/arch/arm/mach-omap2/board-overo.c
> +++ b/arch/arm/mach-omap2/board-overo.c
> @@ -568,7 +568,6 @@ static void __init overo_init(void)
> usb_musb_init(NULL);
> usbhs_init(&usbhs_bdata);
> overo_spi_init();
> - overo_ads7846_init();
> overo_init_smsc911x();
> overo_display_init();
> overo_init_led();
^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH] ARM: OMAP: Overo: remove illegal extra call to overo_ads7846_init()
@ 2011-06-17 16:03 ` Kevin Hilman
0 siblings, 0 replies; 10+ messages in thread
From: Kevin Hilman @ 2011-06-17 16:03 UTC (permalink / raw)
To: linux-arm-kernel
Daniel Mack <zonque@gmail.com> writes:
> Signed-off-by: Daniel Mack <zonque@gmail.com>
Thanks for fixing this, I noticed this recently too.
Please add a descriptive changelog. For example, why is it duplcate?
where is it already done? what commit added the extra call, what
problems does it cause, etc.
Also, your subject says 'illegal', but it's not really illegal. It's just
wrong. :) "remove duplcate call to..." is enough.
Thanks,
Kevin
> ---
> arch/arm/mach-omap2/board-overo.c | 1 -
> 1 files changed, 0 insertions(+), 1 deletions(-)
>
> diff --git a/arch/arm/mach-omap2/board-overo.c b/arch/arm/mach-omap2/board-overo.c
> index 175e1ab..110475f 100644
> --- a/arch/arm/mach-omap2/board-overo.c
> +++ b/arch/arm/mach-omap2/board-overo.c
> @@ -568,7 +568,6 @@ static void __init overo_init(void)
> usb_musb_init(NULL);
> usbhs_init(&usbhs_bdata);
> overo_spi_init();
> - overo_ads7846_init();
> overo_init_smsc911x();
> overo_display_init();
> overo_init_led();
^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH] ARM: OMAP: Overo: remove duplicate call to overo_ads7846_init()
2011-06-17 16:03 ` Kevin Hilman
@ 2011-06-17 16:17 ` Daniel Mack
-1 siblings, 0 replies; 10+ messages in thread
From: Daniel Mack @ 2011-06-17 16:17 UTC (permalink / raw)
To: linux-arm-kernel; +Cc: linux-omap, tony, Daniel Mack
overo_ads7846_init() is already called from overo_spi_init(), and
calling it twice is not only unnecessary but causes a warning as
"reg-fixed-voltage.1" is already added to the device tree.
Signed-off-by: Daniel Mack <zonque@gmail.com>
---
arch/arm/mach-omap2/board-overo.c | 1 -
1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/arch/arm/mach-omap2/board-overo.c b/arch/arm/mach-omap2/board-overo.c
index 175e1ab..110475f 100644
--- a/arch/arm/mach-omap2/board-overo.c
+++ b/arch/arm/mach-omap2/board-overo.c
@@ -568,7 +568,6 @@ static void __init overo_init(void)
usb_musb_init(NULL);
usbhs_init(&usbhs_bdata);
overo_spi_init();
- overo_ads7846_init();
overo_init_smsc911x();
overo_display_init();
overo_init_led();
--
1.7.5.1
^ permalink raw reply related [flat|nested] 10+ messages in thread
* [PATCH] ARM: OMAP: Overo: remove duplicate call to overo_ads7846_init()
@ 2011-06-17 16:17 ` Daniel Mack
0 siblings, 0 replies; 10+ messages in thread
From: Daniel Mack @ 2011-06-17 16:17 UTC (permalink / raw)
To: linux-arm-kernel
overo_ads7846_init() is already called from overo_spi_init(), and
calling it twice is not only unnecessary but causes a warning as
"reg-fixed-voltage.1" is already added to the device tree.
Signed-off-by: Daniel Mack <zonque@gmail.com>
---
arch/arm/mach-omap2/board-overo.c | 1 -
1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/arch/arm/mach-omap2/board-overo.c b/arch/arm/mach-omap2/board-overo.c
index 175e1ab..110475f 100644
--- a/arch/arm/mach-omap2/board-overo.c
+++ b/arch/arm/mach-omap2/board-overo.c
@@ -568,7 +568,6 @@ static void __init overo_init(void)
usb_musb_init(NULL);
usbhs_init(&usbhs_bdata);
overo_spi_init();
- overo_ads7846_init();
overo_init_smsc911x();
overo_display_init();
overo_init_led();
--
1.7.5.1
^ permalink raw reply related [flat|nested] 10+ messages in thread
* Re: [PATCH] ARM: OMAP: Overo: remove duplicate call to overo_ads7846_init()
2011-06-17 16:17 ` Daniel Mack
@ 2011-06-17 20:59 ` Kevin Hilman
-1 siblings, 0 replies; 10+ messages in thread
From: Kevin Hilman @ 2011-06-17 20:59 UTC (permalink / raw)
To: Daniel Mack; +Cc: linux-arm-kernel, linux-omap, tony
Daniel Mack <zonque@gmail.com> writes:
> overo_ads7846_init() is already called from overo_spi_init(), and
> calling it twice is not only unnecessary but causes a warning as
> "reg-fixed-voltage.1" is already added to the device tree.
Excellent, thanks!
> Signed-off-by: Daniel Mack <zonque@gmail.com>
Tested-by: Kevin Hilman <khilman@ti.com>
^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH] ARM: OMAP: Overo: remove duplicate call to overo_ads7846_init()
@ 2011-06-17 20:59 ` Kevin Hilman
0 siblings, 0 replies; 10+ messages in thread
From: Kevin Hilman @ 2011-06-17 20:59 UTC (permalink / raw)
To: linux-arm-kernel
Daniel Mack <zonque@gmail.com> writes:
> overo_ads7846_init() is already called from overo_spi_init(), and
> calling it twice is not only unnecessary but causes a warning as
> "reg-fixed-voltage.1" is already added to the device tree.
Excellent, thanks!
> Signed-off-by: Daniel Mack <zonque@gmail.com>
Tested-by: Kevin Hilman <khilman@ti.com>
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] ARM: OMAP: Overo: remove duplicate call to overo_ads7846_init()
2011-06-17 20:59 ` Kevin Hilman
@ 2011-07-01 7:30 ` Tony Lindgren
-1 siblings, 0 replies; 10+ messages in thread
From: Tony Lindgren @ 2011-07-01 7:30 UTC (permalink / raw)
To: Kevin Hilman; +Cc: Daniel Mack, linux-arm-kernel, linux-omap
* Kevin Hilman <khilman@ti.com> [110617 13:54]:
> Daniel Mack <zonque@gmail.com> writes:
>
> > overo_ads7846_init() is already called from overo_spi_init(), and
> > calling it twice is not only unnecessary but causes a warning as
> > "reg-fixed-voltage.1" is already added to the device tree.
>
> Excellent, thanks!
>
> > Signed-off-by: Daniel Mack <zonque@gmail.com>
>
> Tested-by: Kevin Hilman <khilman@ti.com>
>
Applying into devel-fixes.
Tony
^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH] ARM: OMAP: Overo: remove duplicate call to overo_ads7846_init()
@ 2011-07-01 7:30 ` Tony Lindgren
0 siblings, 0 replies; 10+ messages in thread
From: Tony Lindgren @ 2011-07-01 7:30 UTC (permalink / raw)
To: linux-arm-kernel
* Kevin Hilman <khilman@ti.com> [110617 13:54]:
> Daniel Mack <zonque@gmail.com> writes:
>
> > overo_ads7846_init() is already called from overo_spi_init(), and
> > calling it twice is not only unnecessary but causes a warning as
> > "reg-fixed-voltage.1" is already added to the device tree.
>
> Excellent, thanks!
>
> > Signed-off-by: Daniel Mack <zonque@gmail.com>
>
> Tested-by: Kevin Hilman <khilman@ti.com>
>
Applying into devel-fixes.
Tony
^ permalink raw reply [flat|nested] 10+ messages in thread
end of thread, other threads:[~2011-07-01 7:30 UTC | newest]
Thread overview: 10+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-06-17 15:21 [PATCH] ARM: OMAP: Overo: remove illegal extra call to overo_ads7846_init() Daniel Mack
2011-06-17 15:21 ` Daniel Mack
2011-06-17 16:03 ` Kevin Hilman
2011-06-17 16:03 ` Kevin Hilman
2011-06-17 16:17 ` [PATCH] ARM: OMAP: Overo: remove duplicate " Daniel Mack
2011-06-17 16:17 ` Daniel Mack
2011-06-17 20:59 ` Kevin Hilman
2011-06-17 20:59 ` Kevin Hilman
2011-07-01 7:30 ` Tony Lindgren
2011-07-01 7:30 ` Tony Lindgren
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.