From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Nicolas Ferre <nicolas.ferre@atmel.com>
Cc: alsa-devel@alsa-project.org, lrg@ti.com,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ASoC: wm8731: set the ACTIVE bit if bias ON entered
Date: Fri, 1 Jul 2011 09:15:07 -0700 [thread overview]
Message-ID: <20110701161506.GC23784@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <1309517034-26110-1-git-send-email-nicolas.ferre@atmel.com>
On Fri, Jul 01, 2011 at 12:43:54PM +0200, Nicolas Ferre wrote:
> Resuming from a suspend/resume cycle, the ACTIVE bit was not set even if a
> stream had actually been processing.
> Setting this bit at entering SND_SOC_BIAS_ON level will ensure this.
This will set the bit even for analogue bypass paths which don't need
it. I'd suggest making the active bit a supply widget supplying the DAC
and ADC rather than something open coded, that should do the right thing
I think.
WARNING: multiple messages have this Message-ID (diff)
From: broonie@opensource.wolfsonmicro.com (Mark Brown)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ASoC: wm8731: set the ACTIVE bit if bias ON entered
Date: Fri, 1 Jul 2011 09:15:07 -0700 [thread overview]
Message-ID: <20110701161506.GC23784@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <1309517034-26110-1-git-send-email-nicolas.ferre@atmel.com>
On Fri, Jul 01, 2011 at 12:43:54PM +0200, Nicolas Ferre wrote:
> Resuming from a suspend/resume cycle, the ACTIVE bit was not set even if a
> stream had actually been processing.
> Setting this bit at entering SND_SOC_BIAS_ON level will ensure this.
This will set the bit even for analogue bypass paths which don't need
it. I'd suggest making the active bit a supply widget supplying the DAC
and ADC rather than something open coded, that should do the right thing
I think.
next prev parent reply other threads:[~2011-07-01 16:15 UTC|newest]
Thread overview: 62+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-29 18:00 use dmaengine for atmel ssc/pcm dai drivers Nicolas Ferre
2011-06-29 18:00 ` Nicolas Ferre
2011-06-29 18:00 ` Nicolas Ferre
2011-06-29 18:00 ` [PATCH 1/5] ASoC: wm8731: rework power management Nicolas Ferre
2011-06-29 18:00 ` Nicolas Ferre
2011-06-29 18:00 ` Nicolas Ferre
2011-06-29 17:11 ` Mark Brown
2011-06-29 17:11 ` Mark Brown
2011-06-29 17:11 ` Mark Brown
2011-06-30 13:57 ` Nicolas Ferre
2011-06-30 13:57 ` Nicolas Ferre
2011-06-30 13:57 ` Nicolas Ferre
2011-06-30 15:04 ` [alsa-devel] " Nicolas Ferre
2011-06-30 15:04 ` Nicolas Ferre
2011-06-30 15:04 ` Nicolas Ferre
2011-06-30 15:22 ` Mark Brown
2011-06-30 15:22 ` Mark Brown
2011-06-30 15:22 ` Mark Brown
2011-07-01 9:31 ` Nicolas Ferre
2011-07-01 9:31 ` Nicolas Ferre
2011-07-01 9:31 ` Nicolas Ferre
2011-06-29 18:00 ` [PATCH 2/5] ASoC: atmel-ssc: add phybase in device structure Nicolas Ferre
2011-06-29 18:00 ` Nicolas Ferre
2011-06-29 17:48 ` Mark Brown
2011-06-29 17:48 ` Mark Brown
2011-07-01 14:46 ` [PATCH V2 " Nicolas Ferre
2011-07-01 14:46 ` Nicolas Ferre
2011-07-01 14:46 ` Nicolas Ferre
2011-06-29 18:00 ` [PATCH 3/5] ASoC: atmel-ssc: dmaengine usage switch depending on cpu Nicolas Ferre
2011-06-29 18:00 ` Nicolas Ferre
2011-06-29 18:00 ` [PATCH 4/5] ASoC: atmel_ssc_dai/atmel-pcm: adapt to dmaengine usage Nicolas Ferre
2011-06-29 18:00 ` Nicolas Ferre
2011-06-29 17:59 ` Mark Brown
2011-06-29 17:59 ` Mark Brown
2011-06-29 17:59 ` Mark Brown
2011-06-30 0:54 ` Koul, Vinod
2011-06-30 0:54 ` Koul, Vinod
2011-06-30 0:54 ` Koul, Vinod
2011-06-29 18:00 ` [PATCH 5/5] ASoC: atmel_ssc_dai: PM: actually stopping clock on suspend/resume Nicolas Ferre
2011-06-29 18:00 ` Nicolas Ferre
2011-07-01 10:43 ` [PATCH] ASoC: wm8731: set the ACTIVE bit if bias ON entered Nicolas Ferre
2011-07-01 10:43 ` Nicolas Ferre
2011-07-01 10:43 ` Nicolas Ferre
2011-07-01 14:18 ` Liam Girdwood
2011-07-01 14:18 ` Liam Girdwood
2011-07-01 14:18 ` Liam Girdwood
2011-07-01 16:15 ` Mark Brown [this message]
2011-07-01 16:15 ` Mark Brown
2011-07-04 9:46 ` Nicolas Ferre
2011-07-04 9:46 ` Nicolas Ferre
2011-07-04 9:46 ` Nicolas Ferre
2011-07-04 17:29 ` Mark Brown
2011-07-04 17:29 ` Mark Brown
2011-07-04 17:29 ` Mark Brown
2011-07-04 17:34 ` Liam Girdwood
2011-07-04 17:34 ` Liam Girdwood
2011-07-04 17:34 ` Liam Girdwood
2011-07-05 7:58 ` Nicolas Ferre
2011-07-05 7:58 ` Nicolas Ferre
2011-07-05 7:58 ` Nicolas Ferre
2011-07-05 20:27 ` [alsa-devel] " Mark Brown
2011-07-05 20:27 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110701161506.GC23784@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=alsa-devel@alsa-project.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lrg@ti.com \
--cc=nicolas.ferre@atmel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.