From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Peter Ujfalusi <peter.ujfalusi@ti.com>
Cc: alsa-devel@alsa-project.org, Samuel Ortiz <sameo@linux.intel.com>,
Tony Lindgren <tony@atomide.com>,
linux-kernel@vger.kernel.org,
Misael Lopez Cruz <misael.lopez@ti.com>,
Liam Girdwood <lrg@ti.com>
Subject: Re: [PATCH 6/6] ASoC: twl6040: No need to convert the PLL ID
Date: Mon, 4 Jul 2011 10:46:00 -0700 [thread overview]
Message-ID: <20110704174556.GI28726@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <1309773958-14608-7-git-send-email-peter.ujfalusi@ti.com>
On Mon, Jul 04, 2011 at 01:05:58PM +0300, Peter Ujfalusi wrote:
> Since the PLL handling has been simplified, and
> rebased on 0, there is no longer need for converting
> the PLL ID.
These are all
Acked-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
though I do generally prefer to have the IDs based off 1 as this means
that we catch people just shoving 0 in as an ID when it's not
appropriate.
WARNING: multiple messages have this Message-ID (diff)
From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Peter Ujfalusi <peter.ujfalusi@ti.com>
Cc: Liam Girdwood <lrg@ti.com>, Tony Lindgren <tony@atomide.com>,
Samuel Ortiz <sameo@linux.intel.com>,
linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org,
Misael Lopez Cruz <misael.lopez@ti.com>
Subject: Re: [PATCH 6/6] ASoC: twl6040: No need to convert the PLL ID
Date: Mon, 4 Jul 2011 10:46:00 -0700 [thread overview]
Message-ID: <20110704174556.GI28726@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <1309773958-14608-7-git-send-email-peter.ujfalusi@ti.com>
On Mon, Jul 04, 2011 at 01:05:58PM +0300, Peter Ujfalusi wrote:
> Since the PLL handling has been simplified, and
> rebased on 0, there is no longer need for converting
> the PLL ID.
These are all
Acked-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
though I do generally prefer to have the IDs based off 1 as this means
that we catch people just shoving 0 in as an ID when it's not
appropriate.
next prev parent reply other threads:[~2011-07-04 17:46 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-04 10:05 [PATCH 0/6] ASoC/MFD: twl6040: PLL handling changes Peter Ujfalusi
2011-07-04 10:05 ` Peter Ujfalusi
2011-07-04 10:05 ` [PATCH 1/6] ASoC: twl6040: Use neutral name for power mode text/enum Peter Ujfalusi
2011-07-04 10:05 ` Peter Ujfalusi
2011-07-04 10:05 ` [PATCH 2/6] ASoC: twl6040: Move PLL selection to codec driver Peter Ujfalusi
2011-07-04 10:05 ` Peter Ujfalusi
2011-07-04 10:05 ` [PATCH 3/6] ASoC: twl6040: Simplify sample rate constraint handling Peter Ujfalusi
2011-07-04 10:05 ` [PATCH 4/6] ASoC: twl6040: Configure PLL only once Peter Ujfalusi
2011-07-04 10:05 ` [PATCH 5/6] MFD: twl6040: Remove enum for PLL tracking Peter Ujfalusi
2011-07-04 10:05 ` Peter Ujfalusi
2011-07-06 18:31 ` Samuel Ortiz
2011-07-04 10:05 ` [PATCH 6/6] ASoC: twl6040: No need to convert the PLL ID Peter Ujfalusi
2011-07-04 17:46 ` Mark Brown [this message]
2011-07-04 17:46 ` Mark Brown
2011-07-06 5:47 ` [alsa-devel] [PATCH 0/6] ASoC/MFD: twl6040: PLL handling changes Péter Ujfalusi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110704174556.GI28726@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=alsa-devel@alsa-project.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lrg@ti.com \
--cc=misael.lopez@ti.com \
--cc=peter.ujfalusi@ti.com \
--cc=sameo@linux.intel.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.