All of lore.kernel.org
 help / color / mirror / Atom feed
From: arnd@arndb.de (Arnd Bergmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 6/8 RESEND] drivers: add Contiguous Memory Allocator
Date: Tue, 5 Jul 2011 13:50:10 +0200	[thread overview]
Message-ID: <201107051350.11150.arnd@arndb.de> (raw)
In-Reply-To: <1309863722-6370-1-git-send-email-m.szyprowski@samsung.com>

On Tuesday 05 July 2011, Marek Szyprowski wrote:
> The Contiguous Memory Allocator is a set of helper functions for DMA
> mapping framework that improves allocations of contiguous memory chunks.
> 
> CMA grabs memory on system boot, marks it with CMA_MIGRATE_TYPE and
> gives back to the system. Kernel is allowed to allocate movable pages
> within CMA's managed memory so that it can be used for example for page
> cache when DMA mapping do not use it. On dma_alloc_from_contiguous()
> request such pages are migrated out of CMA area to free required
> contiguous block and fulfill the request. This allows to allocate large
> contiguous chunks of memory at any time assuming that there is enough
> free memory available in the system.
> 
> This code is heavily based on earlier works by Michal Nazarewicz.
> 
> Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com>
> Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
> CC: Michal Nazarewicz <mina86@mina86.com>

Reviewed-by: Arnd Bergmann <arnd@arndb.de>, but I noticed two
one-character mistakes:

> +if CMA
> +
> +config CMA_DEBUG
> +	bool "CMA debug messages (DEVELOPEMENT)"

s/DEVELOPEMENT/DEVELOPMENT/

> diff --git a/drivers/base/Makefile b/drivers/base/Makefile
> index 4c5701c..be6aab4 100644
> --- a/drivers/base/Makefile
> +++ b/drivers/base/Makefile
> @@ -5,6 +5,7 @@ obj-y			:= core.o sys.o bus.o dd.o syscore.o \
>  			   cpu.o firmware.o init.o map.o devres.o \
>  			   attribute_container.o transport_class.o
>  obj-$(CONFIG_DEVTMPFS)	+= devtmpfs.o
> +obj-$(CONFIG_CMA) += dma-contiguous.o
>  obj-y			+= power/
>  obj-$(CONFIG_HAS_DMA)	+= dma-mapping.o

Please add another tab to indent the line in the same way as the others.

	Arnd

WARNING: multiple messages have this Message-ID (diff)
From: Arnd Bergmann <arnd@arndb.de>
To: Marek Szyprowski <m.szyprowski@samsung.com>
Cc: linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-media@vger.kernel.org, linux-mm@kvack.org,
	linaro-mm-sig@lists.linaro.org,
	Michal Nazarewicz <mina86@mina86.com>,
	Kyungmin Park <kyungmin.park@samsung.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>,
	Ankita Garg <ankita@in.ibm.com>,
	Daniel Walker <dwalker@codeaurora.org>,
	Mel Gorman <mel@csn.ul.ie>,
	Jesse Barker <jesse.barker@linaro.org>,
	Jonathan Corbet <corbet@lwn.net>,
	Chunsang Jeong <chunsang.jeong@linaro.org>
Subject: Re: [PATCH 6/8 RESEND] drivers: add Contiguous Memory Allocator
Date: Tue, 5 Jul 2011 13:50:10 +0200	[thread overview]
Message-ID: <201107051350.11150.arnd@arndb.de> (raw)
In-Reply-To: <1309863722-6370-1-git-send-email-m.szyprowski@samsung.com>

On Tuesday 05 July 2011, Marek Szyprowski wrote:
> The Contiguous Memory Allocator is a set of helper functions for DMA
> mapping framework that improves allocations of contiguous memory chunks.
> 
> CMA grabs memory on system boot, marks it with CMA_MIGRATE_TYPE and
> gives back to the system. Kernel is allowed to allocate movable pages
> within CMA's managed memory so that it can be used for example for page
> cache when DMA mapping do not use it. On dma_alloc_from_contiguous()
> request such pages are migrated out of CMA area to free required
> contiguous block and fulfill the request. This allows to allocate large
> contiguous chunks of memory at any time assuming that there is enough
> free memory available in the system.
> 
> This code is heavily based on earlier works by Michal Nazarewicz.
> 
> Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com>
> Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
> CC: Michal Nazarewicz <mina86@mina86.com>

Reviewed-by: Arnd Bergmann <arnd@arndb.de>, but I noticed two
one-character mistakes:

> +if CMA
> +
> +config CMA_DEBUG
> +	bool "CMA debug messages (DEVELOPEMENT)"

s/DEVELOPEMENT/DEVELOPMENT/

> diff --git a/drivers/base/Makefile b/drivers/base/Makefile
> index 4c5701c..be6aab4 100644
> --- a/drivers/base/Makefile
> +++ b/drivers/base/Makefile
> @@ -5,6 +5,7 @@ obj-y			:= core.o sys.o bus.o dd.o syscore.o \
>  			   cpu.o firmware.o init.o map.o devres.o \
>  			   attribute_container.o transport_class.o
>  obj-$(CONFIG_DEVTMPFS)	+= devtmpfs.o
> +obj-$(CONFIG_CMA) += dma-contiguous.o
>  obj-y			+= power/
>  obj-$(CONFIG_HAS_DMA)	+= dma-mapping.o

Please add another tab to indent the line in the same way as the others.

	Arnd

WARNING: multiple messages have this Message-ID (diff)
From: Arnd Bergmann <arnd@arndb.de>
To: Marek Szyprowski <m.szyprowski@samsung.com>
Cc: linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-media@vger.kernel.org, linux-mm@kvack.org,
	linaro-mm-sig@lists.linaro.org,
	Michal Nazarewicz <mina86@mina86.com>,
	Kyungmin Park <kyungmin.park@samsung.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>,
	Ankita Garg <ankita@in.ibm.com>,
	Daniel Walker <dwalker@codeaurora.org>,
	Mel Gorman <mel@csn.ul.ie>,
	Jesse Barker <jesse.barker@linaro.org>,
	Jonathan Corbet <corbet@lwn.net>,
	Chunsang Jeong <chunsang.jeong@linaro.org>
Subject: Re: [PATCH 6/8 RESEND] drivers: add Contiguous Memory Allocator
Date: Tue, 5 Jul 2011 13:50:10 +0200	[thread overview]
Message-ID: <201107051350.11150.arnd@arndb.de> (raw)
In-Reply-To: <1309863722-6370-1-git-send-email-m.szyprowski@samsung.com>

On Tuesday 05 July 2011, Marek Szyprowski wrote:
> The Contiguous Memory Allocator is a set of helper functions for DMA
> mapping framework that improves allocations of contiguous memory chunks.
> 
> CMA grabs memory on system boot, marks it with CMA_MIGRATE_TYPE and
> gives back to the system. Kernel is allowed to allocate movable pages
> within CMA's managed memory so that it can be used for example for page
> cache when DMA mapping do not use it. On dma_alloc_from_contiguous()
> request such pages are migrated out of CMA area to free required
> contiguous block and fulfill the request. This allows to allocate large
> contiguous chunks of memory at any time assuming that there is enough
> free memory available in the system.
> 
> This code is heavily based on earlier works by Michal Nazarewicz.
> 
> Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com>
> Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
> CC: Michal Nazarewicz <mina86@mina86.com>

Reviewed-by: Arnd Bergmann <arnd@arndb.de>, but I noticed two
one-character mistakes:

> +if CMA
> +
> +config CMA_DEBUG
> +	bool "CMA debug messages (DEVELOPEMENT)"

s/DEVELOPEMENT/DEVELOPMENT/

> diff --git a/drivers/base/Makefile b/drivers/base/Makefile
> index 4c5701c..be6aab4 100644
> --- a/drivers/base/Makefile
> +++ b/drivers/base/Makefile
> @@ -5,6 +5,7 @@ obj-y			:= core.o sys.o bus.o dd.o syscore.o \
>  			   cpu.o firmware.o init.o map.o devres.o \
>  			   attribute_container.o transport_class.o
>  obj-$(CONFIG_DEVTMPFS)	+= devtmpfs.o
> +obj-$(CONFIG_CMA) += dma-contiguous.o
>  obj-y			+= power/
>  obj-$(CONFIG_HAS_DMA)	+= dma-mapping.o

Please add another tab to indent the line in the same way as the others.

	Arnd

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  reply	other threads:[~2011-07-05 11:50 UTC|newest]

Thread overview: 177+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-07-05  7:41 [PATCHv11 0/8] Contiguous Memory Allocator Marek Szyprowski
2011-07-05  7:41 ` Marek Szyprowski
2011-07-05  7:41 ` Marek Szyprowski
2011-07-05  7:41 ` [PATCH 1/8] mm: move some functions from memory_hotplug.c to page_isolation.c Marek Szyprowski
2011-07-05  7:41   ` Marek Szyprowski
2011-07-05  7:41   ` Marek Szyprowski
2011-07-05 11:27   ` Arnd Bergmann
2011-07-05 11:27     ` Arnd Bergmann
2011-07-05 11:27     ` Arnd Bergmann
2011-07-05  7:41 ` [PATCH 2/8] mm: alloc_contig_freed_pages() added Marek Szyprowski
2011-07-05  7:41   ` Marek Szyprowski
2011-07-05  7:41   ` Marek Szyprowski
2011-07-05 11:30   ` Arnd Bergmann
2011-07-05 11:30     ` Arnd Bergmann
2011-07-05 11:30     ` Arnd Bergmann
2011-07-05  7:41 ` [PATCH 3/8] mm: alloc_contig_range() added Marek Szyprowski
2011-07-05  7:41   ` Marek Szyprowski
2011-07-05  7:41   ` Marek Szyprowski
2011-07-05 11:31   ` Arnd Bergmann
2011-07-05 11:31     ` Arnd Bergmann
2011-07-05 11:31     ` Arnd Bergmann
2011-07-05  7:41 ` [PATCH 4/8] mm: MIGRATE_CMA migration type added Marek Szyprowski
2011-07-05  7:41   ` Marek Szyprowski
2011-07-05  7:41   ` Marek Szyprowski
2011-07-05 11:44   ` Arnd Bergmann
2011-07-05 11:44     ` Arnd Bergmann
2011-07-05 11:44     ` Arnd Bergmann
2011-07-05 12:27     ` Russell King - ARM Linux
2011-07-05 12:27       ` Russell King - ARM Linux
2011-07-05 12:27       ` Russell King - ARM Linux
2011-07-05  7:41 ` [PATCH 5/8] mm: MIGRATE_CMA isolation functions added Marek Szyprowski
2011-07-05  7:41   ` Marek Szyprowski
2011-07-05  7:41   ` Marek Szyprowski
2011-07-05 11:45   ` Arnd Bergmann
2011-07-05 11:45     ` Arnd Bergmann
2011-07-05 11:45     ` Arnd Bergmann
2011-07-05  7:41 ` [PATCH 6/8] drivers: add Contiguous Memory Allocator Marek Szyprowski
2011-07-05  7:41   ` Marek Szyprowski
2011-07-05  7:41   ` Marek Szyprowski
2011-07-05 10:24   ` Marek Szyprowski
2011-07-05 10:24     ` Marek Szyprowski
2011-07-05 10:24     ` Marek Szyprowski
2011-07-05 11:02   ` [PATCH 6/8 RESEND] " Marek Szyprowski
2011-07-05 11:02     ` Marek Szyprowski
2011-07-05 11:02     ` Marek Szyprowski
2011-07-05 11:50     ` Arnd Bergmann [this message]
2011-07-05 11:50       ` Arnd Bergmann
2011-07-05 11:50       ` Arnd Bergmann
2011-07-05 11:33   ` [PATCH 6/8] " Russell King - ARM Linux
2011-07-05 11:33     ` Russell King - ARM Linux
2011-07-05 11:33     ` Russell King - ARM Linux
2011-07-05 12:27     ` Arnd Bergmann
2011-07-05 12:27       ` Arnd Bergmann
2011-07-05 12:27       ` Arnd Bergmann
2011-07-05 12:30       ` Russell King - ARM Linux
2011-07-05 12:30         ` Russell King - ARM Linux
2011-07-05 12:30         ` Russell King - ARM Linux
2011-07-05 13:58         ` Arnd Bergmann
2011-07-05 13:58           ` Arnd Bergmann
2011-07-05 13:58           ` Arnd Bergmann
2011-07-08 17:25           ` Russell King - ARM Linux
2011-07-08 17:25             ` Russell King - ARM Linux
2011-07-08 17:25             ` Russell King - ARM Linux
2011-07-12 13:39             ` Arnd Bergmann
2011-07-12 13:39               ` Arnd Bergmann
2011-07-12 13:39               ` Arnd Bergmann
2011-08-03 17:43       ` James Bottomley
2011-08-03 17:43         ` James Bottomley
2011-08-03 17:43         ` James Bottomley
2011-09-26 12:06         ` Marek Szyprowski
2011-09-26 12:06           ` Marek Szyprowski
2011-09-26 12:06           ` Marek Szyprowski
2011-09-26 13:00         ` Russell King - ARM Linux
2011-09-26 13:00           ` Russell King - ARM Linux
2011-09-26 13:00           ` Russell King - ARM Linux
2011-07-06 13:58     ` Marek Szyprowski
2011-07-06 13:58       ` Marek Szyprowski
2011-07-06 13:58       ` Marek Szyprowski
2011-07-06 14:09       ` Arnd Bergmann
2011-07-06 14:09         ` Arnd Bergmann
2011-07-06 14:09         ` Arnd Bergmann
2011-07-06 14:23         ` Russell King - ARM Linux
2011-07-06 14:23           ` Russell King - ARM Linux
2011-07-06 14:23           ` Russell King - ARM Linux
2011-07-06 14:37           ` [Linaro-mm-sig] " Nicolas Pitre
2011-07-06 14:37             ` Nicolas Pitre
2011-07-06 14:37             ` Nicolas Pitre
2011-07-06 14:59             ` Arnd Bergmann
2011-07-06 14:59               ` Arnd Bergmann
2011-07-06 14:59               ` Arnd Bergmann
2011-07-09 14:57               ` Janusz Krzysztofik
2011-07-09 14:57                 ` Janusz Krzysztofik
2011-07-09 14:57                 ` Janusz Krzysztofik
2011-07-11 13:47                 ` Marek Szyprowski
2011-07-11 13:47                   ` Marek Szyprowski
2011-07-11 13:47                   ` Marek Szyprowski
2011-07-11 19:01                   ` Janusz Krzysztofik
2011-07-11 19:01                     ` Janusz Krzysztofik
2011-07-11 19:01                     ` Janusz Krzysztofik
2011-07-12  5:34                     ` Marek Szyprowski
2011-07-12  5:34                       ` Marek Szyprowski
2011-07-12  5:34                       ` Marek Szyprowski
2011-07-06 14:51           ` Arnd Bergmann
2011-07-06 14:51             ` Arnd Bergmann
2011-07-06 14:51             ` Arnd Bergmann
2011-07-06 15:48             ` Russell King - ARM Linux
2011-07-06 15:48               ` Russell King - ARM Linux
2011-07-06 15:48               ` Russell King - ARM Linux
2011-07-06 16:05               ` Christoph Lameter
2011-07-06 16:05                 ` Christoph Lameter
2011-07-06 16:05                 ` Christoph Lameter
2011-07-06 16:09                 ` Michal Nazarewicz
2011-07-06 16:09                   ` Michal Nazarewicz
2011-07-06 16:09                   ` Michal Nazarewicz
2011-07-06 16:19                   ` Christoph Lameter
2011-07-06 16:19                     ` Christoph Lameter
2011-07-06 16:19                     ` Christoph Lameter
2011-07-06 17:15                     ` Russell King - ARM Linux
2011-07-06 17:15                       ` Russell King - ARM Linux
2011-07-06 17:15                       ` Russell King - ARM Linux
2011-07-06 19:03                       ` Christoph Lameter
2011-07-06 19:03                         ` Christoph Lameter
2011-07-06 19:03                         ` Christoph Lameter
2011-07-06 17:02                 ` Russell King - ARM Linux
2011-07-06 17:02                   ` Russell King - ARM Linux
2011-07-06 17:02                   ` Russell King - ARM Linux
2011-07-06 16:31               ` Arnd Bergmann
2011-07-06 16:31                 ` Arnd Bergmann
2011-07-06 16:31                 ` Arnd Bergmann
2011-07-06 19:10                 ` Nicolas Pitre
2011-07-06 19:10                   ` Nicolas Pitre
2011-07-06 19:10                   ` Nicolas Pitre
2011-07-06 20:23                   ` [Linaro-mm-sig] " Arnd Bergmann
2011-07-06 20:23                     ` Arnd Bergmann
2011-07-06 20:23                     ` Arnd Bergmann
2011-07-07  5:29                     ` Nicolas Pitre
2011-07-07  5:29                       ` Nicolas Pitre
2011-07-07  5:29                       ` Nicolas Pitre
2011-07-06 14:56         ` Marek Szyprowski
2011-07-06 14:56           ` Marek Szyprowski
2011-07-06 14:56           ` Marek Szyprowski
2011-07-06 15:37           ` Russell King - ARM Linux
2011-07-06 15:37             ` Russell King - ARM Linux
2011-07-06 15:37             ` Russell King - ARM Linux
2011-07-06 15:47             ` Marek Szyprowski
2011-07-06 15:47               ` Marek Szyprowski
2011-07-06 15:47               ` Marek Szyprowski
2011-07-14 12:29   ` Marek Szyprowski
2011-07-14 12:29     ` Marek Szyprowski
2011-07-14 12:29     ` Marek Szyprowski
2011-07-05  7:41 ` [PATCH 7/8] ARM: integrate CMA with dma-mapping subsystem Marek Szyprowski
2011-07-05  7:41   ` Marek Szyprowski
2011-07-05  7:41   ` Marek Szyprowski
2011-07-05 11:50   ` Arnd Bergmann
2011-07-05 11:50     ` Arnd Bergmann
2011-07-05 11:50     ` Arnd Bergmann
2011-07-05  7:41 ` [PATCH 8/8] ARM: S5PV210: example of CMA private area for FIMC device on Goni board Marek Szyprowski
2011-07-05  7:41   ` Marek Szyprowski
2011-07-05  7:41   ` Marek Szyprowski
2011-07-05 11:51   ` Arnd Bergmann
2011-07-05 11:51     ` Arnd Bergmann
2011-07-05 11:51     ` Arnd Bergmann
2011-07-05 12:07 ` [PATCHv11 0/8] Contiguous Memory Allocator Arnd Bergmann
2011-07-05 12:07   ` Arnd Bergmann
2011-07-05 12:07   ` Arnd Bergmann
2011-07-05 12:28   ` Russell King - ARM Linux
2011-07-05 12:28     ` Russell King - ARM Linux
2011-07-05 12:28     ` Russell King - ARM Linux
2011-07-06 22:11   ` Andrew Morton
2011-07-06 22:11     ` Andrew Morton
2011-07-06 22:11     ` Andrew Morton
2011-07-07  7:36     ` Arnd Bergmann
2011-07-07  7:36       ` Arnd Bergmann
2011-07-07  7:36       ` Arnd Bergmann
2011-07-11 13:24     ` Marek Szyprowski
2011-07-11 13:24       ` Marek Szyprowski
2011-07-11 13:24       ` Marek Szyprowski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201107051350.11150.arnd@arndb.de \
    --to=arnd@arndb.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.