From: Matthew Garrett <mjg59@srcf.ucam.org>
To: Jan Beulich <JBeulich@novell.com>
Cc: mingo@elte.hu, tglx@linutronix.de, hpa@zytor.com,
rtc-linux@googlegroups.com, dannf@hp.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] x86: enable rtc-efi
Date: Tue, 5 Jul 2011 19:29:13 +0100 [thread overview]
Message-ID: <20110705182913.GA31808@srcf.ucam.org> (raw)
In-Reply-To: <4E12DBAB020000780004C1B2@nat28.tlf.novell.com>
On Tue, Jul 05, 2011 at 08:38:51AM +0100, Jan Beulich wrote:
> Besides a Kconfig change this just requires creating a respective
> platform device.
Couple of other issues:
> +static struct platform_device rtc_efi_dev = {
> + .name = "rtc-efi",
> + .id = -1,
> +};
You haven't removed this from the IA64 code. Isn't that going to result
in registering the same device twice?
> +static int __init rtc_init(void)
> +{
> + if (efi_enabled && platform_device_register(&rtc_efi_dev) < 0)
> + printk(KERN_ERR "unable to register rtc device...\n");
Ought to -ENODEV if efi isn't present? The error message should also be
more verbose.
--
Matthew Garrett | mjg59@srcf.ucam.org
next prev parent reply other threads:[~2011-07-05 18:29 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-05 7:38 [PATCH] x86: enable rtc-efi Jan Beulich
2011-07-05 18:02 ` Matthew Garrett
2011-07-05 18:29 ` Matthew Garrett [this message]
2011-07-06 7:09 ` Jan Beulich
2011-07-06 11:42 ` Matthew Garrett
[not found] <4E16B5DB0200007800072A2D@nat28.tlf.novell.com>
2011-07-08 7:09 ` Matthew Garrett
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110705182913.GA31808@srcf.ucam.org \
--to=mjg59@srcf.ucam.org \
--cc=JBeulich@novell.com \
--cc=dannf@hp.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=rtc-linux@googlegroups.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.