From: Matthew Garrett <mjg59@srcf.ucam.org>
To: Jan Beulich <jbeulich@novell.com>
Cc: mingo@elte.hu, rtc-linux@googlegroups.com, dannf@hp.com,
tglx@linutronix.de, linux-kernel@vger.kernel.org, hpa@zytor.com
Subject: Re: [PATCH] x86: enable rtc-efi
Date: Fri, 8 Jul 2011 08:09:52 +0100 [thread overview]
Message-ID: <20110708070952.GA3004@srcf.ucam.org> (raw)
In-Reply-To: <4E16B5DB0200007800072A2D@nat28.tlf.novell.com>
On Fri, Jul 08, 2011 at 07:46:35AM +0100, Jan Beulich wrote:
> Having thought some more about this, I don't think this should be
> handled in the RTC driver. Instead, arch/x86/platform/efi/efi.c ought
> to be handling this - also for all other eventual callers of the time
> related calls. In other words, the bug has been existing before my
> patch (and it just exposes it by introducing callers of the incompletely
> implemented backing functions).
I'm in the process of removing this code from arch/x86, since it's
functionally identical to the IA64 version. That's probably going to
complicate this approach a little, but you're right that it makes sense
for the locking to be at the backend rather than in rtc-efi.
--
Matthew Garrett | mjg59@srcf.ucam.org
next parent reply other threads:[~2011-07-08 7:10 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <4E16B5DB0200007800072A2D@nat28.tlf.novell.com>
2011-07-08 7:09 ` Matthew Garrett [this message]
2011-07-05 7:38 [PATCH] x86: enable rtc-efi Jan Beulich
2011-07-05 18:02 ` Matthew Garrett
2011-07-05 18:29 ` Matthew Garrett
2011-07-06 7:09 ` Jan Beulich
2011-07-06 11:42 ` Matthew Garrett
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110708070952.GA3004@srcf.ucam.org \
--to=mjg59@srcf.ucam.org \
--cc=dannf@hp.com \
--cc=hpa@zytor.com \
--cc=jbeulich@novell.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=rtc-linux@googlegroups.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.