From: Andrew Morton <akpm@linux-foundation.org>
To: David Howells <dhowells@redhat.com>
Cc: torvalds@linux-foundation.org, linux-kernel@vger.kernel.org,
linux-fsdevel@vger.kernel.org, uclinux-dev@uclinux.org,
Davidlohr Bueso <dave@gnu.org>,
stable@kernel.org
Subject: Re: [PATCH] FDPIC: Fix memory leak
Date: Wed, 6 Jul 2011 14:16:04 -0700 [thread overview]
Message-ID: <20110706141604.92fd4f9a.akpm@linux-foundation.org> (raw)
In-Reply-To: <20110706112604.29112.39546.stgit@warthog.procyon.org.uk>
On Wed, 06 Jul 2011 12:26:05 +0100
David Howells <dhowells@redhat.com> wrote:
> From: Davidlohr Bueso <dave@gnu.org>
>
> The shdr4extnum variable isn't being freed in the cleanup process of
> elf_fdpic_core_dump().
>
> Signed-off-by: Davidlohr Bueso <dave@gnu.org>
> Signed-off-by: David Howells <dhowells@redhat.com>
> ---
>
> fs/binfmt_elf_fdpic.c | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
>
> diff --git a/fs/binfmt_elf_fdpic.c b/fs/binfmt_elf_fdpic.c
> index 63039ed..2bc5dc6 100644
> --- a/fs/binfmt_elf_fdpic.c
> +++ b/fs/binfmt_elf_fdpic.c
> @@ -1864,6 +1864,7 @@ cleanup:
> kfree(psinfo);
> kfree(notes);
> kfree(fpu);
> + kfree(shdr4extnum);
> #ifdef ELF_CORE_COPY_XFPREGS
> kfree(xfpu);
> #endif
So if it dumps core often enough, the machine runs out of memory and
dies. I added a cc:stable to my copy of this one.
WARNING: multiple messages have this Message-ID (diff)
From: Andrew Morton <akpm@linux-foundation.org>
To: David Howells <dhowells@redhat.com>
Cc: uclinux-dev@uclinux.org, linux-kernel@vger.kernel.org,
linux-fsdevel@vger.kernel.org, torvalds@linux-foundation.org,
stable@kernel.org, Davidlohr Bueso <dave@gnu.org>
Subject: Re: [PATCH] FDPIC: Fix memory leak
Date: Wed, 6 Jul 2011 14:16:04 -0700 [thread overview]
Message-ID: <20110706141604.92fd4f9a.akpm@linux-foundation.org> (raw)
In-Reply-To: <20110706112604.29112.39546.stgit@warthog.procyon.org.uk>
On Wed, 06 Jul 2011 12:26:05 +0100
David Howells <dhowells@redhat.com> wrote:
> From: Davidlohr Bueso <dave@gnu.org>
>
> The shdr4extnum variable isn't being freed in the cleanup process of
> elf_fdpic_core_dump().
>
> Signed-off-by: Davidlohr Bueso <dave@gnu.org>
> Signed-off-by: David Howells <dhowells@redhat.com>
> ---
>
> fs/binfmt_elf_fdpic.c | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
>
> diff --git a/fs/binfmt_elf_fdpic.c b/fs/binfmt_elf_fdpic.c
> index 63039ed..2bc5dc6 100644
> --- a/fs/binfmt_elf_fdpic.c
> +++ b/fs/binfmt_elf_fdpic.c
> @@ -1864,6 +1864,7 @@ cleanup:
> kfree(psinfo);
> kfree(notes);
> kfree(fpu);
> + kfree(shdr4extnum);
> #ifdef ELF_CORE_COPY_XFPREGS
> kfree(xfpu);
> #endif
So if it dumps core often enough, the machine runs out of memory and
dies. I added a cc:stable to my copy of this one.
_______________________________________________
stable mailing list
stable@linux.kernel.org
http://linux.kernel.org/mailman/listinfo/stable
next prev parent reply other threads:[~2011-07-06 21:22 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-06 11:26 [PATCH] FDPIC: Fix memory leak David Howells
2011-07-06 11:26 ` David Howells
2011-07-06 21:16 ` Andrew Morton [this message]
2011-07-06 21:16 ` Andrew Morton
-- strict thread matches above, loose matches on Subject: below --
2011-07-06 3:30 [PATCH] FDPIC: fix " Davidlohr Bueso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110706141604.92fd4f9a.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=dave@gnu.org \
--cc=dhowells@redhat.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=stable@kernel.org \
--cc=torvalds@linux-foundation.org \
--cc=uclinux-dev@uclinux.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.