From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Sascha Hauer <s.hauer@pengutronix.de>
Cc: linux-arm-kernel@lists.infradead.org,
Vinod Koul <vinod.koul@intel.com>, Chris Ball <cjb@laptop.org>,
linux-mmc@vger.kernel.org, Liam Girdwood <lrg@ti.com>,
alsa-devel@alsa-project.org
Subject: Re: [PATCH] ARM i.MX dma: Fix burstsize settings
Date: Wed, 6 Jul 2011 08:03:57 -0700 [thread overview]
Message-ID: <20110706150356.GA11993@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <20110706091833.GT6069@pengutronix.de>
On Wed, Jul 06, 2011 at 11:18:33AM +0200, Sascha Hauer wrote:
> dmaengine expects the maxburst parameter in words, not bytes.
> The imxdma driver and its users do this wrong. Fix this.
>
> As a side note the imx-pcm-dma-mx2 driver was 'fixed' to work
> with imx-dma. This broke the driver with imx-sdma support which
> correctly takes the maxburst parameter in words. This patch
> puts the sdma based sound back to work.
Acked-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
Probably makes sense to send via the ARM tree unless there's merge
issues?
WARNING: multiple messages have this Message-ID (diff)
From: broonie@opensource.wolfsonmicro.com (Mark Brown)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM i.MX dma: Fix burstsize settings
Date: Wed, 6 Jul 2011 08:03:57 -0700 [thread overview]
Message-ID: <20110706150356.GA11993@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <20110706091833.GT6069@pengutronix.de>
On Wed, Jul 06, 2011 at 11:18:33AM +0200, Sascha Hauer wrote:
> dmaengine expects the maxburst parameter in words, not bytes.
> The imxdma driver and its users do this wrong. Fix this.
>
> As a side note the imx-pcm-dma-mx2 driver was 'fixed' to work
> with imx-dma. This broke the driver with imx-sdma support which
> correctly takes the maxburst parameter in words. This patch
> puts the sdma based sound back to work.
Acked-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
Probably makes sense to send via the ARM tree unless there's merge
issues?
next prev parent reply other threads:[~2011-07-06 15:03 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-06 9:18 [PATCH] ARM i.MX dma: Fix burstsize settings Sascha Hauer
2011-07-06 9:18 ` Sascha Hauer
2011-07-06 15:03 ` Mark Brown [this message]
2011-07-06 15:03 ` Mark Brown
2011-07-07 1:35 ` Vinod Koul
2011-07-07 1:35 ` Vinod Koul
-- strict thread matches above, loose matches on Subject: below --
2011-07-06 9:18 Sascha Hauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110706150356.GA11993@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=alsa-devel@alsa-project.org \
--cc=cjb@laptop.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-mmc@vger.kernel.org \
--cc=lrg@ti.com \
--cc=s.hauer@pengutronix.de \
--cc=vinod.koul@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.