All of lore.kernel.org
 help / color / mirror / Atom feed
From: Olaf Hering <olaf@aepfle.de>
To: George Dunlap <George.Dunlap@eu.citrix.com>
Cc: xen-devel@lists.xensource.com
Subject: Re: crash in trace.c with large extra_data
Date: Mon, 11 Jul 2011 16:44:05 +0200	[thread overview]
Message-ID: <20110711144404.GA17475@aepfle.de> (raw)
In-Reply-To: <CAFLBxZbBf=BwEA0q5xWPhikPrNki8j081dmAL44+LMBEVAhh3g@mail.gmail.com>

On Mon, Jul 11, George Dunlap wrote:

> The general idea is that callers of trace_var() *shouldn't* be calling
> with extra_words > TRACE_EXTRA_MAX.  It's an assert so that it breaks
> on debug builds, allowing programmers to fix the mistake (obviously
> mine in this case), but not on production builds.
> 
> I suppose it could be changed into a warning of some kind instead.

George,

a simple printk() would do it I think.

In this unfortunate case the system does not even reboot, need to find
someone to power cycle the box..

Olaf

      reply	other threads:[~2011-07-11 14:44 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-07-11 14:02 crash in trace.c with large extra_data Olaf Hering
2011-07-11 14:35 ` George Dunlap
2011-07-11 14:44   ` Olaf Hering [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110711144404.GA17475@aepfle.de \
    --to=olaf@aepfle.de \
    --cc=George.Dunlap@eu.citrix.com \
    --cc=xen-devel@lists.xensource.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.