From: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
To: Joe Jin <joe.jin@oracle.com>, Jens Axboe <jaxboe@fusionio.com>
Cc: Daniel Stodden <daniel.stodden@citrix.com>,
Jens Axboe <jaxboe@fusionio.com>,
annie.li@oracle.com,
Jeremy Fitzhardinge <jeremy.fitzhardinge@citrix.com>,
Ian Campbell <ian.campbell@citrix.com>,
Kurt C Hackel <KURT.HACKEL@oracle.com>,
Greg Marsden <greg.marsden@oracle.com>,
"xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: xen-blkfront: Don't send closing notification to backend in blkfront_closing()
Date: Tue, 12 Jul 2011 11:04:09 -0400 [thread overview]
Message-ID: <20110712150409.GB7831@dumpdata.com> (raw)
In-Reply-To: <4E1BBFFD.7030900@oracle.com>
> without the patch, after detach the device by xm block-detach timeout also umount hang in guest.
> with my patch, xm block-detach timeout in Dom0, umount in guest worked!
Ah, I failed to spot you did the unmount after the timeout. I tried to do the umount after
forcing the block-detach. [and testing confirms your patch working properly]
Looks good to me - with the only exception that the description needs to have 'xm block-attach'
and 'xm block-detach' - please change that and resubmit and attach
Reviewed-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
CC: stable@kernel.org
and make sure to have Jens in the 'To:' header.
Thanks!
Jens,
Are you OK picking the amended patch (shortly to be posted) for 3.0-rc7?
WARNING: multiple messages have this Message-ID (diff)
From: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
To: Joe Jin <joe.jin@oracle.com>
Cc: Daniel Stodden <daniel.stodden@citrix.com>,
Jens Axboe <jaxboe@fusionio.com>,
annie.li@oracle.com,
Jeremy Fitzhardinge <jeremy.fitzhardinge@citrix.com>,
Ian Campbell <ian.campbell@citrix.com>,
Kurt C Hackel <KURT.HACKEL@oracle.com>,
Greg Marsden <greg.marsden@oracle.com>,
"xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: xen-blkfront: Don't send closing notification to backend in blkfront_closing()
Date: Tue, 12 Jul 2011 11:04:09 -0400 [thread overview]
Message-ID: <20110712150409.GB7831@dumpdata.com> (raw)
In-Reply-To: <4E1BBFFD.7030900@oracle.com>
> without the patch, after detach the device by xm block-detach timeout also umount hang in guest.
> with my patch, xm block-detach timeout in Dom0, umount in guest worked!
Ah, I failed to spot you did the unmount after the timeout. I tried to do the umount after
forcing the block-detach. [and testing confirms your patch working properly]
Looks good to me - with the only exception that the description needs to have 'xm block-attach'
and 'xm block-detach' - please change that and resubmit and attach
Reviewed-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
CC: stable@kernel.org
and make sure to have Jens in the 'To:' header.
Thanks!
Jens,
Are you OK picking the amended patch (shortly to be posted) for 3.0-rc7?
next prev parent reply other threads:[~2011-07-12 15:04 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-08 7:14 xen-blkfront: Don't send closing notification to backend in blkfront_closing() Joe Jin
2011-07-08 7:14 ` Joe Jin
2011-07-08 16:04 ` Konrad Rzeszutek Wilk
2011-07-09 0:26 ` Joe Jin
2011-07-09 13:11 ` Konrad Rzeszutek Wilk
2011-07-11 7:53 ` Joe Jin
2011-07-11 7:53 ` Joe Jin
2011-07-12 3:31 ` Joe Jin
2011-07-12 15:04 ` Konrad Rzeszutek Wilk [this message]
2011-07-12 15:04 ` Konrad Rzeszutek Wilk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110712150409.GB7831@dumpdata.com \
--to=konrad.wilk@oracle.com \
--cc=KURT.HACKEL@oracle.com \
--cc=annie.li@oracle.com \
--cc=daniel.stodden@citrix.com \
--cc=greg.marsden@oracle.com \
--cc=ian.campbell@citrix.com \
--cc=jaxboe@fusionio.com \
--cc=jeremy.fitzhardinge@citrix.com \
--cc=joe.jin@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.