From: Mel Gorman <mgorman@suse.de>
To: Frederic Weisbecker <fweisbec@gmail.com>
Cc: Ingo Molnar <mingo@elte.hu>, LKML <linux-kernel@vger.kernel.org>,
Richard Weinberger <richard@nod.at>,
Oleg Nesterov <oleg@redhat.com>,
Andrew Morton <akpm@linux-foundation.org>,
Huang Ying <ying.huang@intel.com>,
Soeren Sandmann Pedersen <ssp@redhat.com>,
Namhyung Kim <namhyung@gmail.com>, x86 <x86@kernel.org>,
"H. Peter Anvin" <hpa@zytor.com>,
Thomas Gleixner <tglx@linutronix.de>,
Robert Richter <robert.richter@amd.com>,
Paul Mundt <lethal@linux-sh.org>
Subject: Re: [PATCH 1/2] x86: Remove warning and warning_symbol from struct stacktrace_ops
Date: Thu, 14 Jul 2011 12:01:02 +0100 [thread overview]
Message-ID: <20110714110102.GT7529@suse.de> (raw)
In-Reply-To: <1305232326-9804-2-git-send-email-fweisbec@gmail.com>
On Thu, May 12, 2011 at 10:32:05PM +0200, Frederic Weisbecker wrote:
> From: Richard Weinberger <richard@nod.at>
>
> Both warning and warning_symbol are nowhere used.
> Let's get rid of them.
>
> Signed-off-by: Richard Weinberger <richard@nod.at>
> Cc: Oleg Nesterov <oleg@redhat.com>
> Cc: Andrew Morton <akpm@linux-foundation.org>
> Cc: Huang Ying <ying.huang@intel.com>
> Cc: Soeren Sandmann Pedersen <ssp@redhat.com>
> Cc: Namhyung Kim <namhyung@gmail.com>
> Cc: x86 <x86@kernel.org>
> Cc: H. Peter Anvin <hpa@zytor.com>
> Cc: Thomas Gleixner <tglx@linutronix.de>
> Cc: Robert Richter <robert.richter@amd.com>
> Cc: Paul Mundt <lethal@linux-sh.org>
> Link: http://lkml.kernel.org/r/1305205872-10321-2-git-send-email-richard@nod.at
> Signed-off-by: Frederic Weisbecker <fweisbec@gmail.com>
This change breaks systemtap. I know it's out of tree and systemtap
doesn't even do anything useful with the symbols as it assigns them
to dummy callbacks but the breakage is there.
--
Mel Gorman
SUSE Labs
next prev parent reply other threads:[~2011-07-14 11:01 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-12 20:32 [GIT PULL] x86 stacktrace updates Frederic Weisbecker
2011-05-12 20:32 ` [PATCH 1/2] x86: Remove warning and warning_symbol from struct stacktrace_ops Frederic Weisbecker
2011-07-14 11:01 ` Mel Gorman [this message]
2011-07-14 13:50 ` Frederic Weisbecker
2011-05-12 20:32 ` [PATCH 2/2] x86: Make the x86-64 stacktrace code safely callable from scheduler Frederic Weisbecker
2011-05-12 20:40 ` Frederic Weisbecker
2011-05-12 21:28 ` Ingo Molnar
2011-05-12 21:43 ` Frederic Weisbecker
2011-05-12 21:55 ` Ingo Molnar
2011-05-13 10:48 ` Steven Rostedt
2011-05-13 12:48 ` Frederic Weisbecker
2011-05-13 13:19 ` Peter Zijlstra
2011-05-13 13:29 ` Frederic Weisbecker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110714110102.GT7529@suse.de \
--to=mgorman@suse.de \
--cc=akpm@linux-foundation.org \
--cc=fweisbec@gmail.com \
--cc=hpa@zytor.com \
--cc=lethal@linux-sh.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=namhyung@gmail.com \
--cc=oleg@redhat.com \
--cc=richard@nod.at \
--cc=robert.richter@amd.com \
--cc=ssp@redhat.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
--cc=ying.huang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.