* Re: [PATCH] ASoC: WM8983: Initial driver [not found] <1310734290-21216-1-git-send-email-dp@opensource.wolfsonmicro.com> @ 2011-07-15 14:47 ` Mark Brown 2011-07-15 15:14 ` Dimitris Papastamos 0 siblings, 1 reply; 3+ messages in thread From: Mark Brown @ 2011-07-15 14:47 UTC (permalink / raw) To: Dimitris Papastamos; +Cc: alsa-devel, patches, Liam Girdwood, lrg On Fri, Jul 15, 2011 at 01:51:30PM +0100, Dimitris Papastamos wrote: > The WM8983 is a low power, high quality stereo CODEC > designed for portable multimedia applications. Highly flexible > analogue mixing functions enable new application features, > combining hi-fi quality audio with voice communication. I've applied this but there's one issue you should fix up later: > + /* mute all outputs and set PGAs to minimum gain */ > + for (i = WM8983_LOUT1_HP_VOLUME_CTRL; > + i <= WM8983_OUT4_MONO_MIX_CTRL; ++i) > + snd_soc_update_bits(codec, i, 0x40, 0x40); I know you're doing this to minimise artifacts on initial bias raise but we should really be doing this without affecting the default register settings. ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] ASoC: WM8983: Initial driver 2011-07-15 14:47 ` [PATCH] ASoC: WM8983: Initial driver Mark Brown @ 2011-07-15 15:14 ` Dimitris Papastamos 2011-07-15 15:18 ` Mark Brown 0 siblings, 1 reply; 3+ messages in thread From: Dimitris Papastamos @ 2011-07-15 15:14 UTC (permalink / raw) To: Mark Brown; +Cc: alsa-devel, patches, Liam Girdwood, lrg On Fri, Jul 15, 2011 at 11:47:41PM +0900, Mark Brown wrote: > On Fri, Jul 15, 2011 at 01:51:30PM +0100, Dimitris Papastamos wrote: > > The WM8983 is a low power, high quality stereo CODEC > > designed for portable multimedia applications. Highly flexible > > analogue mixing functions enable new application features, > > combining hi-fi quality audio with voice communication. > > I've applied this but there's one issue you should fix up later: > > > + /* mute all outputs and set PGAs to minimum gain */ > > + for (i = WM8983_LOUT1_HP_VOLUME_CTRL; > > + i <= WM8983_OUT4_MONO_MIX_CTRL; ++i) > > + snd_soc_update_bits(codec, i, 0x40, 0x40); > > I know you're doing this to minimise artifacts on initial bias raise but > we should really be doing this without affecting the default register > settings. Well, what about using the cache_bypass option to write directly to the HW? Thanks, Dimitris ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] ASoC: WM8983: Initial driver 2011-07-15 15:14 ` Dimitris Papastamos @ 2011-07-15 15:18 ` Mark Brown 0 siblings, 0 replies; 3+ messages in thread From: Mark Brown @ 2011-07-15 15:18 UTC (permalink / raw) To: Dimitris Papastamos; +Cc: alsa-devel, patches, Liam Girdwood, lrg On Fri, Jul 15, 2011 at 04:14:22PM +0100, Dimitris Papastamos wrote: > On Fri, Jul 15, 2011 at 11:47:41PM +0900, Mark Brown wrote: > > I know you're doing this to minimise artifacts on initial bias raise but > > we should really be doing this without affecting the default register > > settings. > Well, what about using the cache_bypass option to write directly to the > HW? You still have the same issue at resume time at least. ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2011-07-15 15:18 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <1310734290-21216-1-git-send-email-dp@opensource.wolfsonmicro.com>
2011-07-15 14:47 ` [PATCH] ASoC: WM8983: Initial driver Mark Brown
2011-07-15 15:14 ` Dimitris Papastamos
2011-07-15 15:18 ` Mark Brown
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.