From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Shawn Guo <shawn.guo@linaro.org>
Cc: linux-input@vger.kernel.org, devicetree-discuss@lists.ozlabs.org,
linux-arm-kernel@lists.infradead.org, patches@linaro.org,
Phil Blundell <pb@handhelds.org>
Subject: Re: [PATCH 1/2] Input: gpio-keys: do not reference platform_data after .probe exits
Date: Mon, 18 Jul 2011 10:02:44 -0700 [thread overview]
Message-ID: <201107181002.45170.dmitry.torokhov@gmail.com> (raw)
In-Reply-To: <1311007508-8096-2-git-send-email-shawn.guo@linaro.org>
On Monday, July 18, 2011 09:45:07 AM Shawn Guo wrote:
> The patch makes a copy of platform data into driver data, so that any
> reference to platform_data after .probe exits can be avoided.
And why is this beneficial? I am of the opinion that platform data should
stay on (and be accessed through a const pointer to ensure that the driver
will not alter it).
Thanks.
--
Dmitry
WARNING: multiple messages have this Message-ID (diff)
From: dmitry.torokhov@gmail.com (Dmitry Torokhov)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/2] Input: gpio-keys: do not reference platform_data after .probe exits
Date: Mon, 18 Jul 2011 10:02:44 -0700 [thread overview]
Message-ID: <201107181002.45170.dmitry.torokhov@gmail.com> (raw)
In-Reply-To: <1311007508-8096-2-git-send-email-shawn.guo@linaro.org>
On Monday, July 18, 2011 09:45:07 AM Shawn Guo wrote:
> The patch makes a copy of platform data into driver data, so that any
> reference to platform_data after .probe exits can be avoided.
And why is this beneficial? I am of the opinion that platform data should
stay on (and be accessed through a const pointer to ensure that the driver
will not alter it).
Thanks.
--
Dmitry
next prev parent reply other threads:[~2011-07-18 17:02 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-18 16:45 [PATCH 0/2] add device tree probe support for gpio_keys Shawn Guo
2011-07-18 16:45 ` Shawn Guo
2011-07-18 16:45 ` [PATCH 1/2] Input: gpio-keys: do not reference platform_data after .probe exits Shawn Guo
2011-07-18 16:45 ` Shawn Guo
2011-07-18 17:02 ` Dmitry Torokhov [this message]
2011-07-18 17:02 ` Dmitry Torokhov
2011-07-18 17:15 ` Grant Likely
2011-07-18 17:15 ` Grant Likely
2011-07-18 17:24 ` Dmitry Torokhov
2011-07-18 17:24 ` Dmitry Torokhov
2011-07-19 1:17 ` Shawn Guo
2011-07-19 1:17 ` Shawn Guo
[not found] ` <20110719011725.GB3838-+NayF8gZjK2ctlrPMvKcciBecyulp+rMXqFh9Ls21Oc@public.gmane.org>
2011-07-19 7:48 ` Russell King - ARM Linux
2011-07-19 7:48 ` Russell King - ARM Linux
2011-07-19 8:56 ` Shawn Guo
2011-07-19 8:56 ` Shawn Guo
2011-07-18 16:45 ` [PATCH 2/2] Input: gpio-keys: add device tree probe support Shawn Guo
2011-07-18 16:45 ` Shawn Guo
2011-07-18 17:05 ` Dmitry Torokhov
2011-07-18 17:05 ` Dmitry Torokhov
2011-07-19 1:22 ` Shawn Guo
2011-07-19 1:22 ` Shawn Guo
2011-07-19 3:55 ` Shawn Guo
2011-07-19 3:55 ` Shawn Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201107181002.45170.dmitry.torokhov@gmail.com \
--to=dmitry.torokhov@gmail.com \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-input@vger.kernel.org \
--cc=patches@linaro.org \
--cc=pb@handhelds.org \
--cc=shawn.guo@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.