Re: RFC: ctx->Driver.Map/UnmapTextureImage() hooks

Re: RFC: ctx->Driver.Map/UnmapTextureImage() hooks

[Pekka Paalanen]

On Mon, 18 Jul 2011 08:09:17 -0600
Brian Paul <brianp@vmware.com> wrote:

> On 07/15/2011 02:59 PM, Pekka Paalanen wrote:
> > On Fri, 15 Jul 2011 12:22:41 -0600
> > Brian Paul<brianp@vmware.com>  wrote:
> >
> >> On 07/15/2011 10:07 AM, Dave Airlie wrote:
> >>> On Fri, Jul 15, 2011 at 4:10 AM, Brian
> >>> Paul<brian.e.paul@gmail.com>   wrote:
> >>>>
> >>>>
> >>>> The map-texture-image-v4 branch that I just pushed implements
> >>>> this change.  It really cleaned things up for the better and
> >>>> will lead to a few more follow-on improvements.
> >>>>
> >>>> There's no obvious regressions with swrast or the gallium
> >>>> drivers.  I updated the intel driver code and tested i915 and
> >>>> it seems OK too, but I didn't do a full piglit run on it.  I
> >>>> also updated the legacy r600 driver in case anyone cares but
> >>>> didn't do any testing of it.
> >>>>
> >>>> I didn't update any of the other legacy DRI drivers.  Would
> >>>> anyone object if we simply stop building mach64, r128,
> >>>> unichrome, sis, etc? I'd be happy to remove those drivers
> >>>> altogether for that matter.
> >>>
> >>> we could EOL those in 7.11, and if anyone wants to ship them,
> >>> they can just build 7.11 for them.
> >>
> >> Sounds good to me.  I think we'd only keep the swrast, intel
> >> and maybe r300/r600 drivers.  Opinions?
> >
> > Um, don't kill nouveau_vieux, please.
> 
> Does the old nouveau driver support some GPUs that the gallium 
> nv50/nvc0 drivers don't support?

Yes. Like Corbin said, 'nouveau_vieux' is for NV04-NV2x, while
the gallium driver 'nouveau' supports NV30 and later.
http://nouveau.freedesktop.org/wiki/MesaDrivers

> If we want to keep the older driver someone will need to
> volunteer to update the code to support the new driver hooks.

Sorry, I cannot promise that.
Nouveau_vieux seems to have been missing a maintainer for
some time now.


Thanks.

-- 
Pekka Paalanen
http://www.iki.fi/pq/

Re: [Mesa-dev] RFC: ctx->Driver.Map/UnmapTextureImage() hooks

[Brian Paul]

On 07/18/2011 01:00 PM, Pekka Paalanen wrote:
> On Mon, 18 Jul 2011 08:09:17 -0600
> Brian Paul<brianp-pghWNbHTmq7QT0dZR+AlfA@public.gmane.org>  wrote:
>
>> On 07/15/2011 02:59 PM, Pekka Paalanen wrote:
>>> On Fri, 15 Jul 2011 12:22:41 -0600
>>> Brian Paul<brianp-pghWNbHTmq7QT0dZR+AlfA@public.gmane.org>   wrote:
>>>
>>>> On 07/15/2011 10:07 AM, Dave Airlie wrote:
>>>>> On Fri, Jul 15, 2011 at 4:10 AM, Brian
>>>>> Paul<brian.e.paul-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>    wrote:
>>>>>>
>>>>>>
>>>>>> The map-texture-image-v4 branch that I just pushed implements
>>>>>> this change.  It really cleaned things up for the better and
>>>>>> will lead to a few more follow-on improvements.
>>>>>>
>>>>>> There's no obvious regressions with swrast or the gallium
>>>>>> drivers.  I updated the intel driver code and tested i915 and
>>>>>> it seems OK too, but I didn't do a full piglit run on it.  I
>>>>>> also updated the legacy r600 driver in case anyone cares but
>>>>>> didn't do any testing of it.
>>>>>>
>>>>>> I didn't update any of the other legacy DRI drivers.  Would
>>>>>> anyone object if we simply stop building mach64, r128,
>>>>>> unichrome, sis, etc? I'd be happy to remove those drivers
>>>>>> altogether for that matter.
>>>>>
>>>>> we could EOL those in 7.11, and if anyone wants to ship them,
>>>>> they can just build 7.11 for them.
>>>>
>>>> Sounds good to me.  I think we'd only keep the swrast, intel
>>>> and maybe r300/r600 drivers.  Opinions?
>>>
>>> Um, don't kill nouveau_vieux, please.
>>
>> Does the old nouveau driver support some GPUs that the gallium
>> nv50/nvc0 drivers don't support?
>
> Yes. Like Corbin said, 'nouveau_vieux' is for NV04-NV2x, while
> the gallium driver 'nouveau' supports NV30 and later.
> http://nouveau.freedesktop.org/wiki/MesaDrivers
>
>> If we want to keep the older driver someone will need to
>> volunteer to update the code to support the new driver hooks.
>
> Sorry, I cannot promise that.
> Nouveau_vieux seems to have been missing a maintainer for
> some time now.

Any of the older DRI drivers that get dropped could easily be revived 
later if someone wants to do the work.

-Brian

Re: [Nouveau] RFC: ctx->Driver.Map/UnmapTextureImage() hooks

[Francisco Jerez]

[-- Attachment #1.1.1: Type: text/plain, Size: 2793 bytes --]

Pekka Paalanen <pq@iki.fi> writes:

> On Mon, 18 Jul 2011 08:09:17 -0600
> Brian Paul <brianp@vmware.com> wrote:
>
>> On 07/15/2011 02:59 PM, Pekka Paalanen wrote:
>> > On Fri, 15 Jul 2011 12:22:41 -0600
>> > Brian Paul<brianp@vmware.com>  wrote:
>> >
>> >> On 07/15/2011 10:07 AM, Dave Airlie wrote:
>> >>> On Fri, Jul 15, 2011 at 4:10 AM, Brian
>> >>> Paul<brian.e.paul@gmail.com>   wrote:
>> >>>>
>> >>>>
>> >>>> The map-texture-image-v4 branch that I just pushed implements
>> >>>> this change.  It really cleaned things up for the better and
>> >>>> will lead to a few more follow-on improvements.
>> >>>>
>> >>>> There's no obvious regressions with swrast or the gallium
>> >>>> drivers.  I updated the intel driver code and tested i915 and
>> >>>> it seems OK too, but I didn't do a full piglit run on it.  I
>> >>>> also updated the legacy r600 driver in case anyone cares but
>> >>>> didn't do any testing of it.
>> >>>>
>> >>>> I didn't update any of the other legacy DRI drivers.  Would
>> >>>> anyone object if we simply stop building mach64, r128,
>> >>>> unichrome, sis, etc? I'd be happy to remove those drivers
>> >>>> altogether for that matter.
>> >>>
>> >>> we could EOL those in 7.11, and if anyone wants to ship them,
>> >>> they can just build 7.11 for them.
>> >>
>> >> Sounds good to me.  I think we'd only keep the swrast, intel
>> >> and maybe r300/r600 drivers.  Opinions?
>> >
>> > Um, don't kill nouveau_vieux, please.
>> 
>> Does the old nouveau driver support some GPUs that the gallium 
>> nv50/nvc0 drivers don't support?
>
> Yes. Like Corbin said, 'nouveau_vieux' is for NV04-NV2x, while
> the gallium driver 'nouveau' supports NV30 and later.
> http://nouveau.freedesktop.org/wiki/MesaDrivers
>
I run a couple of machines with that driver and have to disagree with
that decision as well.

>> If we want to keep the older driver someone will need to
>> volunteer to update the code to support the new driver hooks.
>
> Sorry, I cannot promise that.
> Nouveau_vieux seems to have been missing a maintainer for
> some time now.
>
That would be me. I admit that because of personal/work reasons I've had
to keep myself somewhat out of the loop during the last couple of
months, that doesn't mean that I've disappeared or stopped answering my
mail.

Coincidentally nouveau's texture handling has always been structured
around two teximage map/unmap hooks (e.g. compare nouveau_teximage() and
the look of _mesa_store_teximage2d() after the API change), and AFAICT
the changes would be for the most part trivial, but still, if no-one
else wants or knows how to do it (isn't fixing up the drivers the
responsibility of whoever changes the API?), I'll get back to it as soon
as I can.

>
> Thanks.

[-- Attachment #1.2: Type: application/pgp-signature, Size: 229 bytes --]

[-- Attachment #2: Type: text/plain, Size: 156 bytes --]

_______________________________________________
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Nouveau] RFC: ctx->Driver.Map/UnmapTextureImage() hooks

[Matt Turner]

On Tue, Jul 19, 2011 at 11:12 AM, Francisco Jerez <currojerez@riseup.net> wrote:
> (isn't fixing up the drivers the
> responsibility of whoever changes the API?)

That's exactly why removing old drivers is being discussed.

Matt