* [PATCH RFC] vhost: fix zcopy reference counting
@ 2011-07-19 10:33 Michael S. Tsirkin
0 siblings, 0 replies; 2+ messages in thread
From: Michael S. Tsirkin @ 2011-07-19 10:33 UTC (permalink / raw)
To: mashirle; +Cc: kvm, virtualization, netdev, linux-kernel
Fix get/put refcount imbalance with zero copy,
which caused qemu to hang forever on guest driver unload.
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
---
Dave, I've put this on my tree so no need for you to bother.
drivers/vhost/vhost.c | 1 -
1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/drivers/vhost/vhost.c b/drivers/vhost/vhost.c
index 46822c0..c16d225 100644
--- a/drivers/vhost/vhost.c
+++ b/drivers/vhost/vhost.c
@@ -1578,7 +1578,6 @@ struct vhost_ubuf_ref *vhost_ubuf_alloc(struct vhost_virtqueue *vq,
if (!ubufs)
return ERR_PTR(-ENOMEM);
kref_init(&ubufs->kref);
- kref_get(&ubufs->kref);
init_waitqueue_head(&ubufs->wait);
ubufs->vq = vq;
return ubufs;
--
1.7.5.53.gc233e
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [PATCH RFC] vhost: fix zcopy reference counting
@ 2011-07-19 10:33 Michael S. Tsirkin
0 siblings, 0 replies; 2+ messages in thread
From: Michael S. Tsirkin @ 2011-07-19 10:33 UTC (permalink / raw)
To: mashirle; +Cc: netdev, linux-kernel, kvm, virtualization
Fix get/put refcount imbalance with zero copy,
which caused qemu to hang forever on guest driver unload.
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
---
Dave, I've put this on my tree so no need for you to bother.
drivers/vhost/vhost.c | 1 -
1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/drivers/vhost/vhost.c b/drivers/vhost/vhost.c
index 46822c0..c16d225 100644
--- a/drivers/vhost/vhost.c
+++ b/drivers/vhost/vhost.c
@@ -1578,7 +1578,6 @@ struct vhost_ubuf_ref *vhost_ubuf_alloc(struct vhost_virtqueue *vq,
if (!ubufs)
return ERR_PTR(-ENOMEM);
kref_init(&ubufs->kref);
- kref_get(&ubufs->kref);
init_waitqueue_head(&ubufs->wait);
ubufs->vq = vq;
return ubufs;
--
1.7.5.53.gc233e
^ permalink raw reply related [flat|nested] 2+ messages in thread
end of thread, other threads:[~2011-07-19 10:33 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-07-19 10:33 [PATCH RFC] vhost: fix zcopy reference counting Michael S. Tsirkin
-- strict thread matches above, loose matches on Subject: below --
2011-07-19 10:33 Michael S. Tsirkin
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.