From: Andrew Morton <akpm@linux-foundation.org>
To: Michal Hocko <mhocko@suse.cz>
Cc: linux-mm@kvack.org, Balbir Singh <bsingharora@gmail.com>,
KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2 v2] memcg: make oom_lock 0 and 1 based rather than coutner
Date: Thu, 21 Jul 2011 13:58:17 -0700 [thread overview]
Message-ID: <20110721135817.baab2a2c.akpm@linux-foundation.org> (raw)
In-Reply-To: <44ec61829ed8a83b55dc90a7aebffdd82fe0e102.1310732789.git.mhocko@suse.cz>
On Wed, 13 Jul 2011 13:05:49 +0200
Michal Hocko <mhocko@suse.cz> wrote:
> @@ -1893,6 +1942,8 @@ bool mem_cgroup_handle_oom(struct mem_cgroup *mem, gfp_t mask)
does:
: memcg_wakeup_oom(mem);
: mutex_unlock(&memcg_oom_mutex);
:
: mem_cgroup_unmark_under_oom(mem);
:
: if (test_thread_flag(TIF_MEMDIE) || fatal_signal_pending(current))
: return false;
: /* Give chance to dying process */
: schedule_timeout(1);
: return true;
: }
Calling schedule_timeout() in state TASK_RUNNING is equivalent to
calling schedule() and then pointlessly wasting some CPU cycles.
Someone might want to take a look at that, and wonder why this bug
wasn't detected in testing ;)
WARNING: multiple messages have this Message-ID (diff)
From: Andrew Morton <akpm@linux-foundation.org>
To: Michal Hocko <mhocko@suse.cz>
Cc: linux-mm@kvack.org, Balbir Singh <bsingharora@gmail.com>,
KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2 v2] memcg: make oom_lock 0 and 1 based rather than coutner
Date: Thu, 21 Jul 2011 13:58:17 -0700 [thread overview]
Message-ID: <20110721135817.baab2a2c.akpm@linux-foundation.org> (raw)
In-Reply-To: <44ec61829ed8a83b55dc90a7aebffdd82fe0e102.1310732789.git.mhocko@suse.cz>
On Wed, 13 Jul 2011 13:05:49 +0200
Michal Hocko <mhocko@suse.cz> wrote:
> @@ -1893,6 +1942,8 @@ bool mem_cgroup_handle_oom(struct mem_cgroup *mem, gfp_t mask)
does:
: memcg_wakeup_oom(mem);
: mutex_unlock(&memcg_oom_mutex);
:
: mem_cgroup_unmark_under_oom(mem);
:
: if (test_thread_flag(TIF_MEMDIE) || fatal_signal_pending(current))
: return false;
: /* Give chance to dying process */
: schedule_timeout(1);
: return true;
: }
Calling schedule_timeout() in state TASK_RUNNING is equivalent to
calling schedule() and then pointlessly wasting some CPU cycles.
Someone might want to take a look at that, and wonder why this bug
wasn't detected in testing ;)
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2011-07-21 20:58 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-15 12:26 [PATCH 0/2 v2 ] memcg: oom locking updates Michal Hocko
2011-07-13 11:05 ` [PATCH 1/2 v2] memcg: make oom_lock 0 and 1 based rather than coutner Michal Hocko
2011-07-21 20:58 ` Andrew Morton [this message]
2011-07-21 20:58 ` Andrew Morton
2011-07-22 0:15 ` KAMEZAWA Hiroyuki
2011-07-22 0:15 ` KAMEZAWA Hiroyuki
2011-08-09 14:03 ` Johannes Weiner
2011-08-09 14:03 ` Johannes Weiner
2011-08-09 15:22 ` Michal Hocko
2011-08-09 15:22 ` Michal Hocko
2011-08-09 15:37 ` Johannes Weiner
2011-08-09 15:37 ` Johannes Weiner
2011-08-09 15:43 ` Michal Hocko
2011-08-09 15:43 ` Michal Hocko
2011-08-10 0:22 ` KAMEZAWA Hiroyuki
2011-08-10 0:22 ` KAMEZAWA Hiroyuki
2011-07-14 15:29 ` [PATCH 2/2] memcg: change memcg_oom_mutex to spinlock Michal Hocko
2011-07-20 5:55 ` KAMEZAWA Hiroyuki
2011-07-20 5:55 ` KAMEZAWA Hiroyuki
2011-07-20 7:01 ` Michal Hocko
2011-07-20 7:01 ` Michal Hocko
2011-07-20 6:34 ` Balbir Singh
2011-07-20 6:34 ` Balbir Singh
2011-07-20 7:00 ` Michal Hocko
2011-07-20 7:00 ` Michal Hocko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110721135817.baab2a2c.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=bsingharora@gmail.com \
--cc=kamezawa.hiroyu@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.