From: Andrew Morton <akpm@linux-foundation.org>
To: "Stephen M. Cameron" <scameron@beardog.cce.hp.com>
Cc: linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org,
stable@kernel.org, james.bottomley@hansenpartnership.com,
stephenmcameron@gmail.com, thenzl@redhat.com,
mikem@beardog.cce.hp.com
Subject: Re: [PATCH] hpsa: do not attempt to read from a write-only register
Date: Fri, 22 Jul 2011 15:39:56 -0700 [thread overview]
Message-ID: <20110722153956.e0b5da19.akpm@linux-foundation.org> (raw)
In-Reply-To: <20110721181605.31672.36250.stgit@beardog.cce.hp.com>
On Thu, 21 Jul 2011 13:16:05 -0500
"Stephen M. Cameron" <scameron@beardog.cce.hp.com> wrote:
> From: Stephen M. Cameron <scameron@beardog.cce.hp.com>
>
> Most smartarrays tolerate it, but a few new ones don't.
> Without this change some newer Smart Arrays will lock up
> and i/o will grind to a halt.
>
> Signed-off-by: Stephen M. Cameron <scameron@beardog.cce.hp.com>
Cc: <stable@kernel.org>?
> diff --git a/drivers/scsi/hpsa.h b/drivers/scsi/hpsa.h
> index 6d8dcd4..7f53cea 100644
> --- a/drivers/scsi/hpsa.h
> +++ b/drivers/scsi/hpsa.h
> @@ -214,7 +214,7 @@ static void SA5_submit_command(struct ctlr_info *h,
> dev_dbg(&h->pdev->dev, "Sending %x, tag = %x\n", c->busaddr,
> c->Header.Tag.lower);
> writel(c->busaddr, h->vaddr + SA5_REQUEST_PORT_OFFSET);
> - (void) readl(h->vaddr + SA5_REQUEST_PORT_OFFSET);
> + (void) readl(h->vaddr + SA5_SCRATCHPAD_OFFSET);
> h->commands_outstanding++;
> if (h->commands_outstanding > h->max_outstanding)
> h->max_outstanding = h->commands_outstanding;
_______________________________________________
stable mailing list
stable@linux.kernel.org
http://linux.kernel.org/mailman/listinfo/stable
WARNING: multiple messages have this Message-ID (diff)
From: Andrew Morton <akpm@linux-foundation.org>
To: "Stephen M. Cameron" <scameron@beardog.cce.hp.com>
Cc: james.bottomley@hansenpartnership.com,
linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org,
stephenmcameron@gmail.com, thenzl@redhat.com,
mikem@beardog.cce.hp.com, stable@kernel.org
Subject: Re: [PATCH] hpsa: do not attempt to read from a write-only register
Date: Fri, 22 Jul 2011 15:39:56 -0700 [thread overview]
Message-ID: <20110722153956.e0b5da19.akpm@linux-foundation.org> (raw)
In-Reply-To: <20110721181605.31672.36250.stgit@beardog.cce.hp.com>
On Thu, 21 Jul 2011 13:16:05 -0500
"Stephen M. Cameron" <scameron@beardog.cce.hp.com> wrote:
> From: Stephen M. Cameron <scameron@beardog.cce.hp.com>
>
> Most smartarrays tolerate it, but a few new ones don't.
> Without this change some newer Smart Arrays will lock up
> and i/o will grind to a halt.
>
> Signed-off-by: Stephen M. Cameron <scameron@beardog.cce.hp.com>
Cc: <stable@kernel.org>?
> diff --git a/drivers/scsi/hpsa.h b/drivers/scsi/hpsa.h
> index 6d8dcd4..7f53cea 100644
> --- a/drivers/scsi/hpsa.h
> +++ b/drivers/scsi/hpsa.h
> @@ -214,7 +214,7 @@ static void SA5_submit_command(struct ctlr_info *h,
> dev_dbg(&h->pdev->dev, "Sending %x, tag = %x\n", c->busaddr,
> c->Header.Tag.lower);
> writel(c->busaddr, h->vaddr + SA5_REQUEST_PORT_OFFSET);
> - (void) readl(h->vaddr + SA5_REQUEST_PORT_OFFSET);
> + (void) readl(h->vaddr + SA5_SCRATCHPAD_OFFSET);
> h->commands_outstanding++;
> if (h->commands_outstanding > h->max_outstanding)
> h->max_outstanding = h->commands_outstanding;
next prev parent reply other threads:[~2011-07-22 22:39 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-21 18:16 [PATCH] hpsa: do not attempt to read from a write-only register Stephen M. Cameron
2011-07-21 18:17 ` Stephen Cameron
2011-07-22 22:39 ` Andrew Morton [this message]
2011-07-22 22:39 ` Andrew Morton
2011-09-01 15:24 ` [BUG] scsi: hpsa: how to destroy your files Eric Dumazet
2011-09-01 16:07 ` scameron
2011-09-01 16:18 ` Eric Dumazet
2011-09-01 16:18 ` Eric Dumazet
2011-09-01 17:40 ` Eric Dumazet
2011-09-01 17:40 ` Eric Dumazet
2011-09-01 17:58 ` Roland Dreier
2011-09-01 18:50 ` James Bottomley
2011-09-01 18:58 ` Jesse Barnes
2011-09-01 19:59 ` Jesse Barnes
[not found] ` <20110901200349.GO9189@beardog.cce.hp.com>
2011-09-01 20:09 ` Jesse Barnes
2011-09-01 20:09 ` Jesse Barnes
2011-09-01 20:44 ` scameron
2011-09-01 21:50 ` Jon Mason
2011-09-01 22:01 ` Eric Dumazet
2011-09-01 22:16 ` scameron
2011-09-02 5:32 ` Eric Dumazet
2011-09-02 5:32 ` Eric Dumazet
2011-09-02 9:39 ` Eric Dumazet
2011-09-02 10:08 ` Eric Dumazet
2011-09-02 15:03 ` scameron
2011-09-02 15:03 ` scameron
2011-09-01 19:36 ` Eric Dumazet
2011-09-01 18:01 ` scameron
2011-09-01 18:01 ` scameron
2011-09-01 19:03 ` scameron
2011-09-01 19:03 ` scameron
2011-09-02 23:13 ` Andrew Morton
2011-09-02 5:18 ` Mike Galbraith
-- strict thread matches above, loose matches on Subject: below --
2011-07-08 19:59 [PATCH] hpsa: do not attempt to read from a write-only register Stephen M. Cameron
2011-07-11 20:19 ` Andrew Morton
2011-07-11 20:51 ` scameron
2011-07-11 21:04 ` Andrew Morton
2011-07-11 21:08 ` scameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110722153956.e0b5da19.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=james.bottomley@hansenpartnership.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=mikem@beardog.cce.hp.com \
--cc=scameron@beardog.cce.hp.com \
--cc=stable@kernel.org \
--cc=stephenmcameron@gmail.com \
--cc=thenzl@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.