All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andrew Morton <akpm@linux-foundation.org>
To: "Nicholas A. Bellinger" <nab@linux-iscsi.org>,
	Linus Torvalds <torvalds@linux-foundation.org>,
	target-devel <target-devel@vger.kernel.org>,
	linux-scsi <linux-scsi@vger.kernel.org>L
Subject: Re: [GIT PULL] iscsi-target merge for v3.1-rc1
Date: Mon, 25 Jul 2011 16:50:57 -0700	[thread overview]
Message-ID: <20110725165057.9701f16b.akpm@linux-foundation.org> (raw)
In-Reply-To: <20110725163739.5c19b04d.akpm@linux-foundation.org>

On Mon, 25 Jul 2011 16:37:39 -0700
Andrew Morton <akpm@linux-foundation.org> wrote:

> On Sat, 23 Jul 2011 16:16:15 -0700
> "Nicholas A. Bellinger" <nab@linux-iscsi.org> wrote:
> 
> > Please go ahead and pull from:
> > 
> >   master.kernel.org:/pub/scm/linux/kernel/git/nab/target-pending.git for-linus-merge
> 
> i386 allyesconfig:
> 
> ERROR: "__udivdi3" [drivers/target/target_core_mod.ko] undefined!
> 
> somewhere in drivers/target/target_core_transport.c:transport_allocate_data_tasks().

Probably the best place to fix this is within DIV_ROUND_UP(): make it
handle 64-bits on 32-bit.

This will have the pleasing side-effect of breaking
drivers/scsi/cxgbi/cxgb4i/cxgb4i.c, which felt a need to duplicate the
existing DIV_ROUND_UP() implementation.


WARNING: multiple messages have this Message-ID (diff)
From: Andrew Morton <akpm@linux-foundation.org>
To: "Nicholas A. Bellinger" <nab@linux-iscsi.org>,
	Linus Torvalds <torvalds@linux-foundation.org>,
	target-devel <target-devel@vger.kernel.org>,
	linux-scsi <linux-scsi@vger.kernel.org>,
	LKML <linux-kernel@vger.kernel.org>,
	Christoph Hellwig <hch@lst.de>, Andy Grover <agrover@redhat.com>,
	Hannes Reinecke <hare@suse.de>,
	Roland Dreier <roland@purestorage.com>,
	James Bottomley <James.Bottomley@HansenPartnership.com>,
	Boaz Harrosh <openosd@gmail.com>,
	Mike Christie <michaelc@cs.wisc.edu>
Subject: Re: [GIT PULL] iscsi-target merge for v3.1-rc1
Date: Mon, 25 Jul 2011 16:50:57 -0700	[thread overview]
Message-ID: <20110725165057.9701f16b.akpm@linux-foundation.org> (raw)
In-Reply-To: <20110725163739.5c19b04d.akpm@linux-foundation.org>

On Mon, 25 Jul 2011 16:37:39 -0700
Andrew Morton <akpm@linux-foundation.org> wrote:

> On Sat, 23 Jul 2011 16:16:15 -0700
> "Nicholas A. Bellinger" <nab@linux-iscsi.org> wrote:
> 
> > Please go ahead and pull from:
> > 
> >   master.kernel.org:/pub/scm/linux/kernel/git/nab/target-pending.git for-linus-merge
> 
> i386 allyesconfig:
> 
> ERROR: "__udivdi3" [drivers/target/target_core_mod.ko] undefined!
> 
> somewhere in drivers/target/target_core_transport.c:transport_allocate_data_tasks().

Probably the best place to fix this is within DIV_ROUND_UP(): make it
handle 64-bits on 32-bit.

This will have the pleasing side-effect of breaking
drivers/scsi/cxgbi/cxgb4i/cxgb4i.c, which felt a need to duplicate the
existing DIV_ROUND_UP() implementation.


  parent reply	other threads:[~2011-07-25 23:51 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-07-23 23:16 [GIT PULL] iscsi-target merge for v3.1-rc1 Nicholas A. Bellinger
2011-07-23 23:33 ` Andrew Morton
2011-07-24  0:19   ` Nicholas A. Bellinger
2011-07-24  2:27     ` Stephen Rothwell
2011-07-25 23:37 ` Andrew Morton
2011-07-25 23:46   ` Linus Torvalds
2011-07-25 23:52     ` Andrew Morton
2011-07-25 23:50   ` Andrew Morton [this message]
2011-07-25 23:50     ` Andrew Morton
2011-07-26  6:51     ` Nicholas A. Bellinger
2011-07-26  7:09       ` Linus Torvalds
2011-07-26  7:09         ` Linus Torvalds
2011-07-26  7:26         ` Nicholas A. Bellinger
2011-07-26  7:43         ` Andrew Morton
2011-07-26  7:51           ` Nicholas A. Bellinger
2011-07-26 10:08         ` Olivier Galibert
2011-07-26 10:14           ` Alexey Dobriyan
2011-07-26 10:14             ` Alexey Dobriyan
2011-07-26  0:32   ` Nicholas A. Bellinger
2011-07-26  0:32     ` Nicholas A. Bellinger
2011-07-26  1:09     ` Andy Grover

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110725165057.9701f16b.akpm@linux-foundation.org \
    --to=akpm@linux-foundation.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=nab@linux-iscsi.org \
    --cc=target-devel@vger.kernel.org \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.