From: Alan Cox <alan@linux.intel.com>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Ryan Mallon <rmallon@gmail.com>, Jesper Juhl <jj@chaosbits.net>,
linux-kernel@vger.kernel.org, Greg Kroah-Hartman <gregkh@suse.de>,
devel@driverdev.osuosl.org
Subject: Re: GMA500: ERROR: "__bad_udelay" undefined!
Date: Mon, 25 Jul 2011 22:42:50 +0100 [thread overview]
Message-ID: <20110725224250.7d6edb83@bob.linux.org.uk> (raw)
In-Reply-To: <62472696.BtqhiR95vr@wuerfel>
On Mon, 25 Jul 2011 23:08:42 +0200
Arnd Bergmann <arnd@arndb.de> wrote:
> On Monday 25 July 2011 11:28:44 Ryan Mallon wrote:
> >
> > diff --git a/drivers/staging/gma500/psb_intel_display.c
> > b/drivers/staging/gma500/psb_intel_display.c index 4f47d09..09e378d
> > 100644 --- a/drivers/staging/gma500/psb_intel_display.c
> > +++ b/drivers/staging/gma500/psb_intel_display.c
> > @@ -331,7 +331,7 @@ static bool psb_intel_find_best_PLL(struct
> > drm_crtc *crtc, int target, void psb_intel_wait_for_vblank(struct
> > drm_device *dev) {
> > /* Wait for 20ms, i.e. one cycle at 50hz. */
> > - udelay(20000);
> > + mdelay(20);
> > }
> >
> > int psb_intel_pipe_set_base(struct drm_crtc *crtc,
>
> A 20 ms busy wait is rather nasty. Can't this be replaced with a
> sleeping wait (msleep)?
Don't know yet - its on the fixme list to dig into - I think the answer
is some cases but not all.
next prev parent reply other threads:[~2011-07-25 21:40 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-24 21:37 GMA500: ERROR: "__bad_udelay" undefined! Jesper Juhl
2011-07-25 1:22 ` Ryan Mallon
2011-07-25 1:28 ` Ryan Mallon
2011-07-25 2:15 ` Arnaud Lacombe
2011-07-25 21:08 ` Arnd Bergmann
2011-07-25 21:42 ` Alan Cox [this message]
2011-07-26 9:06 ` Patrik Jakobsson
2011-07-26 10:19 ` Alan Cox
2011-07-26 14:07 ` Patrik Jakobsson
2011-07-26 15:07 ` Alan Cox
2011-08-01 1:54 ` Patrik Jakobsson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110725224250.7d6edb83@bob.linux.org.uk \
--to=alan@linux.intel.com \
--cc=arnd@arndb.de \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@suse.de \
--cc=jj@chaosbits.net \
--cc=linux-kernel@vger.kernel.org \
--cc=rmallon@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.