From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: alsa-devel@alsa-project.org
Cc: Linux-MIPS <linux-mips@linux-mips.org>,
alsa-devel@vger.kernel.org, Liam Girdwood <lrg@ti.com>
Subject: Re: [PATCH V5 1/3] ASoC: Alchemy AC97C/I2SC audio support
Date: Tue, 26 Jul 2011 15:31:13 +0100 [thread overview]
Message-ID: <20110726143112.GF7285@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <1311594287-31576-2-git-send-email-manuel.lauss@googlemail.com>
On Mon, Jul 25, 2011 at 01:44:45PM +0200, Manuel Lauss wrote:
Looks good, I'll apply this but a few minor comments you might want to
look at incrementally.
> +#define ALCHEMY_PCM_FMTS \
> + (SNDRV_PCM_FMTBIT_S8 | SNDRV_PCM_FMTBIT_U8 | \
> + SNDRV_PCM_FMTBIT_S16_LE | SNDRV_PCM_FMTBIT_S16_BE | \
> + SNDRV_PCM_FMTBIT_U16_LE | SNDRV_PCM_FMTBIT_U16_BE | \
> + SNDRV_PCM_FMTBIT_S32_LE | SNDRV_PCM_FMTBIT_S32_BE | \
> + SNDRV_PCM_FMTBIT_U32_LE | SNDRV_PCM_FMTBIT_U32_BE | \
> + 0)
Why the | 0? Same for the other one.
> + case (DMA_D0 | DMA_D1):
> + pr_debug("DMA %d missed interrupt.\n", stream->dma);
> + au1000_dma_stop(stream);
> + au1000_dma_start(stream);
> + break;
> + case (~DMA_D0 & ~DMA_D1):
> + pr_debug("DMA %d empty irq.\n", stream->dma);
This case should return IRQ_NONE really since it didn't handle an
interrupt...
WARNING: multiple messages have this Message-ID (diff)
From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Manuel Lauss <manuel.lauss@googlemail.com>
Cc: alsa-devel@vger.kernel.org, Liam Girdwood <lrg@ti.com>,
Linux-MIPS <linux-mips@linux-mips.org>
Subject: Re: [PATCH V5 1/3] ASoC: Alchemy AC97C/I2SC audio support
Date: Tue, 26 Jul 2011 15:31:13 +0100 [thread overview]
Message-ID: <20110726143112.GF7285@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <1311594287-31576-2-git-send-email-manuel.lauss@googlemail.com>
On Mon, Jul 25, 2011 at 01:44:45PM +0200, Manuel Lauss wrote:
Looks good, I'll apply this but a few minor comments you might want to
look at incrementally.
> +#define ALCHEMY_PCM_FMTS \
> + (SNDRV_PCM_FMTBIT_S8 | SNDRV_PCM_FMTBIT_U8 | \
> + SNDRV_PCM_FMTBIT_S16_LE | SNDRV_PCM_FMTBIT_S16_BE | \
> + SNDRV_PCM_FMTBIT_U16_LE | SNDRV_PCM_FMTBIT_U16_BE | \
> + SNDRV_PCM_FMTBIT_S32_LE | SNDRV_PCM_FMTBIT_S32_BE | \
> + SNDRV_PCM_FMTBIT_U32_LE | SNDRV_PCM_FMTBIT_U32_BE | \
> + 0)
Why the | 0? Same for the other one.
> + case (DMA_D0 | DMA_D1):
> + pr_debug("DMA %d missed interrupt.\n", stream->dma);
> + au1000_dma_stop(stream);
> + au1000_dma_start(stream);
> + break;
> + case (~DMA_D0 & ~DMA_D1):
> + pr_debug("DMA %d empty irq.\n", stream->dma);
This case should return IRQ_NONE really since it didn't handle an
interrupt...
next prev parent reply other threads:[~2011-07-26 14:31 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-25 11:44 [PATCH V5 0/3] ASoC for Alchemy Au1000/1500/1100 Manuel Lauss
2011-07-25 11:44 ` Manuel Lauss
2011-07-25 11:44 ` [PATCH V5 1/3] ASoC: Alchemy AC97C/I2SC audio support Manuel Lauss
2011-07-25 11:44 ` Manuel Lauss
2011-07-26 14:31 ` Mark Brown [this message]
2011-07-26 14:31 ` Mark Brown
2011-07-26 14:43 ` Manuel Lauss
2011-07-26 14:43 ` Manuel Lauss
2011-07-26 14:47 ` Mark Brown
2011-07-26 14:47 ` Mark Brown
2011-07-25 11:44 ` [PATCH V5 2/3] ASoC: Add a DB1x00 AC97 machine driver Manuel Lauss
2011-07-25 11:44 ` Manuel Lauss
2011-07-26 14:39 ` Mark Brown
2011-07-26 14:39 ` Mark Brown
2011-07-27 14:56 ` Ralf Baechle
2011-07-27 14:56 ` Ralf Baechle
2011-07-27 18:11 ` Mark Brown
2011-07-27 18:11 ` Mark Brown
2011-07-25 11:44 ` [PATCH V5 3/3] ALSA: deprecate MIPS AU1X00 AC97 driver Manuel Lauss
2011-07-25 11:44 ` Manuel Lauss
2011-07-27 18:12 ` Mark Brown
2011-07-27 18:12 ` Mark Brown
2011-07-26 10:48 ` [PATCH V5 0/3] ASoC for Alchemy Au1000/1500/1100 Liam Girdwood
2011-07-26 10:48 ` Liam Girdwood
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110726143112.GF7285@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=alsa-devel@alsa-project.org \
--cc=alsa-devel@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
--cc=lrg@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.