[Qemu-devel] vt82686b query

[Qemu-devel] vt82686b query

[Michael S. Tsirkin]

Does one of you maintain the vt82686b emulation?
I was doing an overview of pci devices and have some questions on it:

vt82c686b_write_config - this seems to assume that
config writes are done using single byte accesses.
E.g. a two byte access at 0x84 will modify the
register at offset 0x85 but isn't handled by the
emulation.  Is this intentional?

PCI_STATUS and PCI_CAPABILITY_LIST are initialized
in the reset callback. These are readonly so
should go into init - there's no guarantee
reset is invoked in time to set these correctly,
is there?

PCI_CAPABILITY_LIST is a single byte register.
Better set it using pci_set_byte or simple memory access?
Higer bytes in that word are reserved so zeroing them out is
harmless, but still ...

via_pm_info has a config write method that simply
invokes the pci_default_write_config directly -
makes sense to remove it and save some lines of code?

Will you be able to review/test patches addressing the above?
Thanks!

-- 
MST