From: Supriya Kannery <supriyak@linux.vnet.ibm.com>
To: qemu-devel@nongnu.org
Cc: Kevin Wolf <kwolf@redhat.com>,
Stefan Hajnoczi <stefanha@gmail.com>,
Christoph Hellwig <hch@lst.de>,
Supriya Kannery <supriyak@linux.vnet.ibm.com>
Subject: [Qemu-devel] [V5 Patch 2/4]Qemu: qerrors for file reopen, data sync and cmd syntax
Date: Wed, 27 Jul 2011 17:00:27 +0530 [thread overview]
Message-ID: <20110727113027.25109.33096.sendpatchset@skannery> (raw)
In-Reply-To: <20110727113000.25109.16204.sendpatchset@skannery>
New error classes defined for file reopen failure, data
sync error and incorrect command syntax
Signed-off-by: Supriya Kannery <supriyak@in.ibm.com>
---
qerror.c | 12 ++++++++++++
qerror.h | 8 ++++++++
2 files changed, 20 insertions(+)
Index: qemu/qerror.c
===================================================================
--- qemu.orig/qerror.c
+++ qemu/qerror.c
@@ -97,6 +97,14 @@ static const QErrorStringTable qerror_ta
.desc = "Device '%(device)' is not removable",
},
{
+ .error_fmt = QERR_DATA_SYNC_FAILED,
+ .desc = "Syncing of data failed for device '%(device)'",
+ },
+ {
+ .error_fmt = QERR_REOPEN_FILE_FAILED,
+ .desc = "Could not reopen '%(filename)'",
+ },
+ {
.error_fmt = QERR_DEVICE_NO_BUS,
.desc = "Device '%(device)' has no child bus",
},
@@ -230,6 +238,10 @@ static const QErrorStringTable qerror_ta
.error_fmt = QERR_QGA_COMMAND_FAILED,
.desc = "Guest agent command failed, error was '%(message)'",
},
+ {
+ .error_fmt = QERR_INCORRECT_COMMAND_SYNTAX,
+ .desc = "Usage: %(syntax)",
+ },
{}
};
Index: qemu/qerror.h
===================================================================
--- qemu.orig/qerror.h
+++ qemu/qerror.h
@@ -85,6 +85,9 @@ QError *qobject_to_qerror(const QObject
#define QERR_DEVICE_NOT_FOUND \
"{ 'class': 'DeviceNotFound', 'data': { 'device': %s } }"
+#define QERR_DATA_SYNC_FAILED \
+ "{ 'class': 'DataSyncFailed', 'data': { 'device': %s } }"
+
#define QERR_DEVICE_NOT_REMOVABLE \
"{ 'class': 'DeviceNotRemovable', 'data': { 'device': %s } }"
@@ -142,6 +145,9 @@ QError *qobject_to_qerror(const QObject
#define QERR_OPEN_FILE_FAILED \
"{ 'class': 'OpenFileFailed', 'data': { 'filename': %s } }"
+#define QERR_REOPEN_FILE_FAILED \
+ "{ 'class': 'ReopenFileFailed', 'data': { 'filename': %s } }"
+
#define QERR_PROPERTY_NOT_FOUND \
"{ 'class': 'PropertyNotFound', 'data': { 'device': %s, 'property': %s } }"
@@ -193,4 +199,6 @@ QError *qobject_to_qerror(const QObject
#define QERR_QGA_COMMAND_FAILED \
"{ 'class': 'QgaCommandFailed', 'data': { 'message': %s } }"
+#define QERR_INCORRECT_COMMAND_SYNTAX \
+ "{ 'class': 'IncorrectCommandSyntax', 'data': { 'syntax': %s } }"
#endif /* QERROR_H */
next prev parent reply other threads:[~2011-07-27 11:18 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-27 11:30 [Qemu-devel] [V5 Patch 0/4]Qemu: Set host cache from cmdline and monitor Supriya Kannery
2011-07-27 11:30 ` [Qemu-devel] [V5 Patch 1/4]Qemu: Enhance "info block" to display host cache setting Supriya Kannery
2011-07-27 14:19 ` Stefan Hajnoczi
2011-07-28 10:39 ` Supriya Kannery
2011-07-27 11:30 ` Supriya Kannery [this message]
2011-07-27 11:30 ` [Qemu-devel] [V5 Patch 3/4]Qemu: Command "block_set" for dynamic block params change Supriya Kannery
2011-07-27 12:58 ` Anthony Liguori
2011-07-27 14:31 ` Stefan Hajnoczi
2011-07-27 16:02 ` Anthony Liguori
2011-07-28 9:29 ` Stefan Hajnoczi
2011-08-01 15:22 ` Stefan Hajnoczi
2011-08-01 15:28 ` Anthony Liguori
2011-08-01 15:34 ` Stefan Hajnoczi
2011-08-01 15:44 ` Kevin Wolf
2011-08-01 15:44 ` Anthony Liguori
2011-08-04 8:32 ` Supriya Kannery
2011-08-04 8:31 ` Stefan Hajnoczi
2011-08-04 9:33 ` Supriya Kannery
2011-08-04 9:17 ` Supriya Kannery
2011-08-01 15:44 ` Stefan Hajnoczi
2011-08-01 15:46 ` Anthony Liguori
2011-07-28 10:13 ` Supriya Kannery
2011-07-28 12:48 ` Anthony Liguori
2011-07-27 13:43 ` Michael Tokarev
2011-07-27 13:52 ` Anthony Liguori
2011-07-27 14:51 ` Stefan Hajnoczi
2011-07-28 10:23 ` Kevin Wolf
2011-07-28 13:10 ` Stefan Hajnoczi
2011-07-28 13:23 ` Kevin Wolf
2011-07-27 11:31 ` [Qemu-devel] [V5 Patch 4/4]Qemu: Add commandline -drive option 'hostcache' Supriya Kannery
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110727113027.25109.33096.sendpatchset@skannery \
--to=supriyak@linux.vnet.ibm.com \
--cc=hch@lst.de \
--cc=kwolf@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.