From: Stefan Richter <stefanr@s5r6.in-berlin.de>
To: Dan Williams <dan.j.williams@intel.com>
Cc: JBottomley@parallels.com, linux-scsi@vger.kernel.org
Subject: Re: [PATCH 9/9] isci: add version number
Date: Sat, 30 Jul 2011 18:55:07 +0200 [thread overview]
Message-ID: <20110730185507.7b68c0a7@stein> (raw)
In-Reply-To: <20110730001721.28430.28086.stgit@localhost6.localdomain6>
On Jul 29 Dan Williams wrote:
> @@ -540,7 +548,8 @@ static __init int isci_init(void)
> {
> int err;
>
> - pr_info("%s: Intel(R) C600 SAS Controller Driver\n", DRV_NAME);
> + pr_info("%s: Intel(R) C600 SAS Controller Driver - version %s\n",
> + DRV_NAME, DRV_VERSION);
Why? There is already a version number. Like 2.6.39, 3.0, 3.1.
Besides, just
- pr_info("%s: Intel(R) C600 SAS Controller Driver\n", DRV_NAME);
would be the most correct thing to do here.
--
Stefan Richter
-=====-==-== -=== ====-
http://arcgraph.de/sr/
next prev parent reply other threads:[~2011-07-30 16:56 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-30 0:16 [GIT PATCH 0/9] isci updates for 3.1 Dan Williams
2011-07-30 0:16 ` [PATCH 1/9] isci: fix sata response handling Dan Williams
2011-07-30 0:16 ` [PATCH 2/9] isci: fix 32-bit operation when CONFIG_HIGHMEM64G=n Dan Williams
2011-07-30 0:16 ` [PATCH 3/9] isci: change sas phy timeouts from 54us to 59us Dan Williams
2011-07-30 0:16 ` [PATCH 4/9] isci: Update MAINTAINERS entry for the isci driver Dan Williams
2011-07-30 0:17 ` [PATCH 5/9] isci: Adding documentation to API change and fixup sysfs registration Dan Williams
2011-07-30 0:17 ` [PATCH 6/9] isci: Leave requests alone if already terminating Dan Williams
2011-07-30 0:17 ` [PATCH 7/9] isci: dynamic interrupt coalescing Dan Williams
2011-07-30 0:17 ` [PATCH 8/9] isci: fix event-get pointer increment Dan Williams
2011-07-30 0:17 ` [PATCH 9/9] isci: add version number Dan Williams
2011-07-30 16:55 ` Stefan Richter [this message]
2011-08-01 16:24 ` Dan Williams
2011-08-01 17:38 ` Stefan Richter
2011-08-01 17:54 ` James Bottomley
2011-08-01 18:29 ` Stefan Richter
2011-08-01 18:40 ` Stefan Richter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110730185507.7b68c0a7@stein \
--to=stefanr@s5r6.in-berlin.de \
--cc=JBottomley@parallels.com \
--cc=dan.j.williams@intel.com \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.