From: Stefan Richter <stefanr@s5r6.in-berlin.de>
To: James Bottomley <James.Bottomley@HansenPartnership.com>,
Dan Williams <dan.j.williams@intel.com>
Cc: linux-scsi@vger.kernel.org
Subject: Re: [PATCH 9/9] isci: add version number
Date: Mon, 1 Aug 2011 20:29:16 +0200 [thread overview]
Message-ID: <20110801202916.3d78752f@stein> (raw)
In-Reply-To: <1312221286.8212.29.camel@mulgrave>
On Aug 01 James Bottomley wrote:
> On Mon, 2011-08-01 at 19:38 +0200, Stefan Richter wrote:
> > The mainline doesn't generally carry stubs and macros that are only there
> > for backporting. Well, I guess SCSI drivers are different in that regard.
>
> This is hardly a stub for a backport. It's a printk printing the
> version.
It is a printk printing a version that is only of interest in conjuction
with backports. And even in that context a "major.minor.build"
naming scheme for a device driver is quite naive. For example, a backport
of a driver which directly or indirectly uses the workqueue infrastructure
back into a kernel from before concurrency managed workqueues will behave
quite differently, regardless what its local version numbers say.
> At least 25% of drivers seem to do this (not that I entirely
> approve ... it does tend to clutter the boot sequence a bit)
25% of SCSI drivers perhaps (surely more than that if we consider only
SCSI drivers). My random sample of 46 loaded modules on a desktop PC
contains 3 drivers whose modinfo | grep -E '^version' is nonempty
(pata_atiixp, sg, r8169).
However, what 25% or 85% of all drivers do is not quite relevant to a new
driver.
> The whole reason for MODULE_VERSION() is to mark this correctly.
If you (the author, the subsystem maintainer) prefer to have a driver
version, consider to omit the driver init()'s printk at least. It is
redundant with lsmod, modinfo, or /sys/module/*{,/version}.
--
Stefan Richter
-=====-==-== =--- ----=
http://arcgraph.de/sr/
next prev parent reply other threads:[~2011-08-01 18:29 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-30 0:16 [GIT PATCH 0/9] isci updates for 3.1 Dan Williams
2011-07-30 0:16 ` [PATCH 1/9] isci: fix sata response handling Dan Williams
2011-07-30 0:16 ` [PATCH 2/9] isci: fix 32-bit operation when CONFIG_HIGHMEM64G=n Dan Williams
2011-07-30 0:16 ` [PATCH 3/9] isci: change sas phy timeouts from 54us to 59us Dan Williams
2011-07-30 0:16 ` [PATCH 4/9] isci: Update MAINTAINERS entry for the isci driver Dan Williams
2011-07-30 0:17 ` [PATCH 5/9] isci: Adding documentation to API change and fixup sysfs registration Dan Williams
2011-07-30 0:17 ` [PATCH 6/9] isci: Leave requests alone if already terminating Dan Williams
2011-07-30 0:17 ` [PATCH 7/9] isci: dynamic interrupt coalescing Dan Williams
2011-07-30 0:17 ` [PATCH 8/9] isci: fix event-get pointer increment Dan Williams
2011-07-30 0:17 ` [PATCH 9/9] isci: add version number Dan Williams
2011-07-30 16:55 ` Stefan Richter
2011-08-01 16:24 ` Dan Williams
2011-08-01 17:38 ` Stefan Richter
2011-08-01 17:54 ` James Bottomley
2011-08-01 18:29 ` Stefan Richter [this message]
2011-08-01 18:40 ` Stefan Richter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110801202916.3d78752f@stein \
--to=stefanr@s5r6.in-berlin.de \
--cc=James.Bottomley@HansenPartnership.com \
--cc=dan.j.williams@intel.com \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.