From: Al Viro <viro@ZenIV.linux.org.uk>
To: richard -rw- weinberger <richard.weinberger@gmail.com>
Cc: David Woodhouse <dwmw2@infradead.org>,
Arnaud Lacombe <lacombar@gmail.com>,
"H. Peter Anvin" <hpa@zytor.com>,
linux-kernel@vger.kernel.org, linux-kbuild@vger.kernel.org,
user-mode-linux-devel@lists.sourceforge.net
Subject: Re: [PATCH 1/5] um: Use __i386__ in ifdef for vsyscall exports, not SUBARCH_i386
Date: Mon, 1 Aug 2011 05:32:08 +0100 [thread overview]
Message-ID: <20110801043207.GE2203@ZenIV.linux.org.uk> (raw)
In-Reply-To: <CAFLxGvyewG70ZgU41Kmu_eOYpjZ0TVXYwYq1AfS1sXONAM6G_w@mail.gmail.com>
On Mon, Aug 01, 2011 at 01:17:17AM +0200, richard -rw- weinberger wrote:
> On Mon, Aug 1, 2011 at 1:13 AM, David Woodhouse <dwmw2@infradead.org> wrote:
> > On Sun, 2011-07-31 at 23:58 +0100, Al Viro wrote:
> >> FWIW, the next step (still not pushed there) is to move arch/um/sys-x86 to
> >> arch/x86/um, with arch/um/os-Linux/sys-x86 becoming arch/x86/um/os-Linux,
> >> Kconfig.x86 moving to arch/x86/um/Kconfig and Makefile-x86 - to
> >> arch/x86/um/Makefile.defs. ?Next after that - arch/powerpc/um (and yes,
> >> it means resurrected uml/ppc port; for now - only ppc32, since I have no
> >> ppc64 boxen to test on).
> >
> > I can give you an account on a ppc64 box if that would help...
>
> Isn't UML on ppc broken since ages?
Yes. Resurrected is not the right word here, sorry...
Anyway, could you take a look at the git tree at
git://git.kernel.org/pub/scm/linux/kernel/git/viro/um-header.git/,
branch x86_merge and comment? It doesn't include stuff from this
thread (yet); what it does is
* further headers cleanups
* sys-{i386,x86_64} merged; all[1] x86-specific code taken first
to arch/um/sys-x86 and then (by final commit) to arch/x86/um. IMO that's
the right place for it - target-dependent code is better off not hidden
from maintainers of the target arch. When we get other ports to working
shape, their target-specific parts ought to go into arch/<target>/um.
* hopefully saner treatment of sigcontext; should make life easier
for other ports.
[1] theoretically - in reality we still have more than a few x86-isms in
"generic" um headers in arch/um/include/asm.
WARNING: multiple messages have this Message-ID (diff)
From: Al Viro <viro@ZenIV.linux.org.uk>
To: richard -rw- weinberger <richard.weinberger@gmail.com>
Cc: user-mode-linux-devel@lists.sourceforge.net,
linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org,
Arnaud Lacombe <lacombar@gmail.com>,
"H. Peter Anvin" <hpa@zytor.com>,
David Woodhouse <dwmw2@infradead.org>
Subject: Re: [uml-devel] [PATCH 1/5] um: Use __i386__ in ifdef for vsyscall exports, not SUBARCH_i386
Date: Mon, 1 Aug 2011 05:32:08 +0100 [thread overview]
Message-ID: <20110801043207.GE2203@ZenIV.linux.org.uk> (raw)
In-Reply-To: <CAFLxGvyewG70ZgU41Kmu_eOYpjZ0TVXYwYq1AfS1sXONAM6G_w@mail.gmail.com>
On Mon, Aug 01, 2011 at 01:17:17AM +0200, richard -rw- weinberger wrote:
> On Mon, Aug 1, 2011 at 1:13 AM, David Woodhouse <dwmw2@infradead.org> wrote:
> > On Sun, 2011-07-31 at 23:58 +0100, Al Viro wrote:
> >> FWIW, the next step (still not pushed there) is to move arch/um/sys-x86 to
> >> arch/x86/um, with arch/um/os-Linux/sys-x86 becoming arch/x86/um/os-Linux,
> >> Kconfig.x86 moving to arch/x86/um/Kconfig and Makefile-x86 - to
> >> arch/x86/um/Makefile.defs. ?Next after that - arch/powerpc/um (and yes,
> >> it means resurrected uml/ppc port; for now - only ppc32, since I have no
> >> ppc64 boxen to test on).
> >
> > I can give you an account on a ppc64 box if that would help...
>
> Isn't UML on ppc broken since ages?
Yes. Resurrected is not the right word here, sorry...
Anyway, could you take a look at the git tree at
git://git.kernel.org/pub/scm/linux/kernel/git/viro/um-header.git/,
branch x86_merge and comment? It doesn't include stuff from this
thread (yet); what it does is
* further headers cleanups
* sys-{i386,x86_64} merged; all[1] x86-specific code taken first
to arch/um/sys-x86 and then (by final commit) to arch/x86/um. IMO that's
the right place for it - target-dependent code is better off not hidden
from maintainers of the target arch. When we get other ports to working
shape, their target-specific parts ought to go into arch/<target>/um.
* hopefully saner treatment of sigcontext; should make life easier
for other ports.
[1] theoretically - in reality we still have more than a few x86-isms in
"generic" um headers in arch/um/include/asm.
------------------------------------------------------------------------------
Got Input? Slashdot Needs You.
Take our quick survey online. Come on, we don't ask for help often.
Plus, you'll get a chance to win $100 to spend on ThinkGeek.
http://p.sf.net/sfu/slashdot-survey
_______________________________________________
User-mode-linux-devel mailing list
User-mode-linux-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/user-mode-linux-devel
next prev parent reply other threads:[~2011-08-01 4:32 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1312066693.22074.50.camel@i7.infradead.org>
2011-07-30 23:01 ` [PATCH 2/5] um: Remove gratuitous use of $(SUBARCH) in Makefile-i386 David Woodhouse
2011-07-30 23:02 ` [PATCH 1/5] um: Use __i386__ in ifdef for vsyscall exports, not SUBARCH_i386 David Woodhouse
2011-07-31 22:11 ` richard -rw- weinberger
2011-07-31 22:11 ` richard -rw- weinberger
2011-07-31 22:24 ` David Woodhouse
2011-07-31 22:48 ` Al Viro
2011-07-31 22:58 ` Al Viro
2011-07-31 22:58 ` [uml-devel] " Al Viro
2011-07-31 23:13 ` David Woodhouse
2011-07-31 23:13 ` [uml-devel] " David Woodhouse
2011-07-31 23:17 ` richard -rw- weinberger
2011-07-31 23:17 ` [uml-devel] " richard -rw- weinberger
2011-07-31 23:24 ` David Woodhouse
2011-07-31 23:24 ` [uml-devel] " David Woodhouse
2011-08-01 4:32 ` Al Viro [this message]
2011-08-01 4:32 ` Al Viro
2011-08-01 10:04 ` Geert Uytterhoeven
2011-08-01 10:40 ` richard -rw- weinberger
2011-08-01 17:23 ` Al Viro
2011-08-01 17:52 ` richard -rw- weinberger
2011-08-01 17:52 ` richard -rw- weinberger
2011-08-09 23:38 ` Al Viro
2011-08-10 4:04 ` Al Viro
2011-08-10 17:44 ` Al Viro
2011-08-11 4:23 ` Al Viro
2011-08-11 12:13 ` richard -rw- weinberger
2011-08-11 12:13 ` richard -rw- weinberger
2011-08-11 14:05 ` Al Viro
2011-07-31 23:09 ` David Woodhouse
2011-07-31 23:09 ` [uml-devel] " David Woodhouse
2011-07-30 23:02 ` [PATCH 3/5] um: Always use -m32 when building for i386 David Woodhouse
2011-07-30 23:02 ` [PATCH 4/5] um: Do not define SUBARCH in CFLAGS David Woodhouse
2011-07-30 23:04 ` [PATCH 5/5] um: Fix SUBARCH=x86 build David Woodhouse
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110801043207.GE2203@ZenIV.linux.org.uk \
--to=viro@zeniv.linux.org.uk \
--cc=dwmw2@infradead.org \
--cc=hpa@zytor.com \
--cc=lacombar@gmail.com \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=richard.weinberger@gmail.com \
--cc=user-mode-linux-devel@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.