All of lore.kernel.org
 help / color / mirror / Atom feed
* [ath9k-devel] Important misprint in ar9003_phy.h
@ 2011-08-02  7:55 Alex Hacker
  2011-08-02  8:10 ` Mohammed Shafi
  0 siblings, 1 reply; 3+ messages in thread
From: Alex Hacker @ 2011-08-02  7:55 UTC (permalink / raw)
  To: ath9k-devel

I think it looks like misprint which can lead to incorrect calibration process.

--- ar9003_phy.h.orig	2011-08-01 09:53:05.000000000 +0600
+++ ar9003_phy.h	2011-08-02 13:47:07.000000000 +0600
@@ -850,7 +850,7 @@
 #define AR_PHY_TPC_11_B1         (AR_SM1_BASE + 0x220)
 #define AR_PHY_PDADC_TAB_1       (AR_SM1_BASE + 0x240)
 #define AR_PHY_TX_IQCAL_STATUS_B1   (AR_SM1_BASE + 0x48c)
-#define AR_PHY_TX_IQCAL_CORR_COEFF_B1(_i)    (AR_SM_BASE + 0x450 + ((_i) << 2))
+#define AR_PHY_TX_IQCAL_CORR_COEFF_B1(_i)    (AR_SM1_BASE + 0x450 + ((_i) << 2))
 
 /*
  * Channel 2 Register Map

Best regrads,
Alex.

^ permalink raw reply	[flat|nested] 3+ messages in thread

* [ath9k-devel] Important misprint in ar9003_phy.h
  2011-08-02  7:55 [ath9k-devel] Important misprint in ar9003_phy.h Alex Hacker
@ 2011-08-02  8:10 ` Mohammed Shafi
  2011-08-02 10:07   ` Mohammed Shafi
  0 siblings, 1 reply; 3+ messages in thread
From: Mohammed Shafi @ 2011-08-02  8:10 UTC (permalink / raw)
  To: ath9k-devel

On Tue, Aug 2, 2011 at 1:25 PM, Alex Hacker <hacker@epn.ru> wrote:
> I think it looks like misprint which can lead to incorrect calibration process.

true. looks like a typo, I will check with Vasanth. thanks.

>
> --- ar9003_phy.h.orig ? 2011-08-01 09:53:05.000000000 +0600
> +++ ar9003_phy.h ? ? ? ?2011-08-02 13:47:07.000000000 +0600
> @@ -850,7 +850,7 @@
> ?#define AR_PHY_TPC_11_B1 ? ? ? ? (AR_SM1_BASE + 0x220)
> ?#define AR_PHY_PDADC_TAB_1 ? ? ? (AR_SM1_BASE + 0x240)
> ?#define AR_PHY_TX_IQCAL_STATUS_B1 ? (AR_SM1_BASE + 0x48c)
> -#define AR_PHY_TX_IQCAL_CORR_COEFF_B1(_i) ? ?(AR_SM_BASE + 0x450 + ((_i) << 2))
> +#define AR_PHY_TX_IQCAL_CORR_COEFF_B1(_i) ? ?(AR_SM1_BASE + 0x450 + ((_i) << 2))
>
> ?/*
> ?* Channel 2 Register Map
>
> Best regrads,
> Alex.
>



-- 
shafi

^ permalink raw reply	[flat|nested] 3+ messages in thread

* [ath9k-devel] Important misprint in ar9003_phy.h
  2011-08-02  8:10 ` Mohammed Shafi
@ 2011-08-02 10:07   ` Mohammed Shafi
  0 siblings, 0 replies; 3+ messages in thread
From: Mohammed Shafi @ 2011-08-02 10:07 UTC (permalink / raw)
  To: ath9k-devel

On Tue, Aug 2, 2011 at 1:40 PM, Mohammed Shafi <shafi.wireless@gmail.com> wrote:
> On Tue, Aug 2, 2011 at 1:25 PM, Alex Hacker <hacker@epn.ru> wrote:
>> I think it looks like misprint which can lead to incorrect calibration process.
>
> true. looks like a typo, I will check with Vasanth. thanks.

this change looks fine. Alex, please send a patch to wireless-testing.  thanks.

>
>>
>> --- ar9003_phy.h.orig ? 2011-08-01 09:53:05.000000000 +0600
>> +++ ar9003_phy.h ? ? ? ?2011-08-02 13:47:07.000000000 +0600
>> @@ -850,7 +850,7 @@
>> ?#define AR_PHY_TPC_11_B1 ? ? ? ? (AR_SM1_BASE + 0x220)
>> ?#define AR_PHY_PDADC_TAB_1 ? ? ? (AR_SM1_BASE + 0x240)
>> ?#define AR_PHY_TX_IQCAL_STATUS_B1 ? (AR_SM1_BASE + 0x48c)
>> -#define AR_PHY_TX_IQCAL_CORR_COEFF_B1(_i) ? ?(AR_SM_BASE + 0x450 + ((_i) << 2))
>> +#define AR_PHY_TX_IQCAL_CORR_COEFF_B1(_i) ? ?(AR_SM1_BASE + 0x450 + ((_i) << 2))
>>
>> ?/*
>> ?* Channel 2 Register Map
>>
>> Best regrads,
>> Alex.
>>
>
>
>
> --
> shafi
>



-- 
shafi

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2011-08-02 10:07 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-08-02  7:55 [ath9k-devel] Important misprint in ar9003_phy.h Alex Hacker
2011-08-02  8:10 ` Mohammed Shafi
2011-08-02 10:07   ` Mohammed Shafi

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.