All of lore.kernel.org
 help / color / mirror / Atom feed
From: Marek Lindner <lindner_marek@yahoo.de>
To: ath9k-devel@lists.ath9k.org
Subject: [ath9k-devel] eeprom txGainType overridden if minor version < 19
Date: Tue, 2 Aug 2011 10:28:21 +0200	[thread overview]
Message-ID: <201108021028.21637.lindner_marek@yahoo.de> (raw)


Hi,

I was having some output power problems with a device using AR7240/AR9285. 
After digging into the ath9k driver I realized that it would override the 
power settings (txGainType) configured in the eeprom if the minor version does 
not meet its expectations. This is why it would not use the appropriate high 
power settings. The offending lines from eeprom_4k.c:

if (ver_minor >= AR5416_EEP_MINOR_VER_19)
return pBase->txGainType;
else
return AR5416_EEP_TXGAIN_ORIGINAL;

My minor version is 14 and consequently fell through the cracks. The commit 
introducing the check in question was 970bf9d40c03e48cc34ee2c1a70693a0e0fca3f6 
but it does not explain why the minor version has to be 19 or higher. Does 
anyone know the magic behind version 19 ? I could easily post a patch to 
remove that check if it causes no harm.

Regards,
Marek

             reply	other threads:[~2011-08-02  8:28 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-08-02  8:28 Marek Lindner [this message]
2011-08-02  8:59 ` [ath9k-devel] eeprom txGainType overridden if minor version < 19 Adrian Chadd
2011-08-02  9:03   ` Marek Lindner
2011-08-02 10:38     ` Adrian Chadd
2011-08-02 10:48       ` Marek Lindner
2011-08-02 11:13         ` Adrian Chadd
2011-08-02 14:37           ` Marek Lindner
2011-08-02 15:06             ` Mohammed Shafi
2011-08-02 15:37               ` Mohammed Shafi
2011-08-02 16:11                 ` Gabor Juhos
2011-08-03  4:59                   ` Mohammed Shafi
2011-08-03  6:48                     ` Adrian Chadd
2011-08-03  7:03                       ` Marek Lindner
2011-08-03  7:10                         ` Mohammed Shafi
2011-08-02 16:29             ` Adrian Chadd
2011-08-02 10:09 ` Mohammed Shafi
2011-08-02 10:15   ` Marek Lindner
2011-08-02 10:36     ` Mohammed Shafi
2011-08-02 10:49       ` Marek Lindner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201108021028.21637.lindner_marek@yahoo.de \
    --to=lindner_marek@yahoo.de \
    --cc=ath9k-devel@lists.ath9k.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.