All of lore.kernel.org
 help / color / mirror / Atom feed
From: Vivek Goyal <vgoyal@redhat.com>
To: Michael Holzheu <holzheu@linux.vnet.ibm.com>
Cc: oomichi@mxs.nes.nec.co.jp, linux-s390@vger.kernel.org,
	mahesh@linux.vnet.ibm.com, heiko.carstens@de.ibm.com,
	linux-kernel@vger.kernel.org, hbabu@us.ibm.com,
	horms@verge.net.au, ebiederm@xmission.com,
	schwidefsky@de.ibm.com, kexec@lists.infradead.org
Subject: Re: [patch v2 02/10] kdump: Make kimage_load_crash_segment() weak
Date: Tue, 2 Aug 2011 14:55:30 -0400	[thread overview]
Message-ID: <20110802185530.GH6399@redhat.com> (raw)
In-Reply-To: <1312277403.4881.26.camel@br98xy6r>

On Tue, Aug 02, 2011 at 11:30:03AM +0200, Michael Holzheu wrote:
> Hello Vivek,
> 
> On Mon, 2011-08-01 at 16:31 -0400, Vivek Goyal wrote:
> > On Wed, Jul 27, 2011 at 02:55:06PM +0200, Michael Holzheu wrote:
> 
> [snip]
> 
> > > --- a/kernel/kexec.c
> > > +++ b/kernel/kexec.c
> > > @@ -842,8 +842,8 @@ out:
> > >  	return result;
> > >  }
> > >  
> > > -static int kimage_load_crash_segment(struct kimage *image,
> > > -					struct kexec_segment *segment)
> > > +int __weak kimage_load_crash_segment(struct kimage *image,
> > > +				     struct kexec_segment *segment)
> > 
> > A comment here why we are making it weak should help in increasing
> > the code readability.
> 
> What about the following:
> 
> /*
>  * Load crash segment into memory. Architecture code can override this
>  * function. E.g. this is necessary for architectures that do not
>  * create page tables for crashkernel memory.
>  */
> int __weak kimage_load_crash_segment(struct kimage *image,

This looks better.

Thanks
Vivek

_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec

WARNING: multiple messages have this Message-ID (diff)
From: Vivek Goyal <vgoyal@redhat.com>
To: Michael Holzheu <holzheu@linux.vnet.ibm.com>
Cc: ebiederm@xmission.com, mahesh@linux.vnet.ibm.com,
	hbabu@us.ibm.com, oomichi@mxs.nes.nec.co.jp, horms@verge.net.au,
	schwidefsky@de.ibm.com, heiko.carstens@de.ibm.com,
	kexec@lists.infradead.org, linux-kernel@vger.kernel.org,
	linux-s390@vger.kernel.org
Subject: Re: [patch v2 02/10] kdump: Make kimage_load_crash_segment() weak
Date: Tue, 2 Aug 2011 14:55:30 -0400	[thread overview]
Message-ID: <20110802185530.GH6399@redhat.com> (raw)
In-Reply-To: <1312277403.4881.26.camel@br98xy6r>

On Tue, Aug 02, 2011 at 11:30:03AM +0200, Michael Holzheu wrote:
> Hello Vivek,
> 
> On Mon, 2011-08-01 at 16:31 -0400, Vivek Goyal wrote:
> > On Wed, Jul 27, 2011 at 02:55:06PM +0200, Michael Holzheu wrote:
> 
> [snip]
> 
> > > --- a/kernel/kexec.c
> > > +++ b/kernel/kexec.c
> > > @@ -842,8 +842,8 @@ out:
> > >  	return result;
> > >  }
> > >  
> > > -static int kimage_load_crash_segment(struct kimage *image,
> > > -					struct kexec_segment *segment)
> > > +int __weak kimage_load_crash_segment(struct kimage *image,
> > > +				     struct kexec_segment *segment)
> > 
> > A comment here why we are making it weak should help in increasing
> > the code readability.
> 
> What about the following:
> 
> /*
>  * Load crash segment into memory. Architecture code can override this
>  * function. E.g. this is necessary for architectures that do not
>  * create page tables for crashkernel memory.
>  */
> int __weak kimage_load_crash_segment(struct kimage *image,

This looks better.

Thanks
Vivek

  reply	other threads:[~2011-08-02 18:55 UTC|newest]

Thread overview: 66+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-07-27 12:55 [patch v2 00/10] kdump: Patch series for s390 support (version 2) Michael Holzheu
2011-07-27 12:55 ` Michael Holzheu
2011-07-27 12:55 ` [patch v2 01/10] kdump: Add KEXEC_CRASH_CONTROL_MEMORY_LIMIT Michael Holzheu
2011-07-27 12:55   ` Michael Holzheu
2011-08-01 20:16   ` Vivek Goyal
2011-08-01 20:16     ` Vivek Goyal
2011-08-02  9:51     ` Michael Holzheu
2011-08-02  9:51       ` Michael Holzheu
2011-08-02 19:16       ` Vivek Goyal
2011-08-02 19:16         ` Vivek Goyal
2011-08-03  9:27         ` Michael Holzheu
2011-08-03  9:27           ` Michael Holzheu
2011-07-27 12:55 ` [patch v2 02/10] kdump: Make kimage_load_crash_segment() weak Michael Holzheu
2011-07-27 12:55   ` Michael Holzheu
2011-08-01 20:31   ` Vivek Goyal
2011-08-01 20:31     ` Vivek Goyal
2011-08-02  9:30     ` Michael Holzheu
2011-08-02  9:30       ` Michael Holzheu
2011-08-02 18:55       ` Vivek Goyal [this message]
2011-08-02 18:55         ` Vivek Goyal
2011-08-03 10:41         ` Michael Holzheu
2011-08-03 10:41           ` Michael Holzheu
2011-08-04 20:25           ` Vivek Goyal
2011-08-04 20:25             ` Vivek Goyal
2011-07-27 12:55 ` [patch v2 03/10] kdump: Add size to elfcorehdr kernel parameter Michael Holzheu
2011-07-27 12:55   ` Michael Holzheu
2011-08-01 20:36   ` Vivek Goyal
2011-08-01 20:36     ` Vivek Goyal
2011-08-02  9:08     ` Michael Holzheu
2011-08-02  9:08       ` Michael Holzheu
2011-08-02 18:55       ` Vivek Goyal
2011-08-02 18:55         ` Vivek Goyal
2011-08-03 10:40         ` Michael Holzheu
2011-08-03 10:40           ` Michael Holzheu
2011-07-27 12:55 ` [patch v2 04/10] kdump: Trigger kdump via panic notifier chain on s390 Michael Holzheu
2011-07-27 12:55   ` Michael Holzheu
2011-08-01 20:41   ` Vivek Goyal
2011-08-01 20:41     ` Vivek Goyal
2011-08-02  8:37     ` Michael Holzheu
2011-08-02  8:37       ` Michael Holzheu
2011-08-02 19:21       ` Vivek Goyal
2011-08-02 19:21         ` Vivek Goyal
2011-08-03  9:50         ` Michael Holzheu
2011-08-03  9:50           ` Michael Holzheu
2011-08-04 21:14           ` Vivek Goyal
2011-08-04 21:14             ` Vivek Goyal
2011-08-08 17:47             ` Michael Holzheu
2011-08-08 17:47               ` Michael Holzheu
2011-08-09 21:19               ` Vivek Goyal
2011-08-09 21:19                 ` Vivek Goyal
2011-07-27 12:55 ` [patch v2 05/10] s390: Add PSW restart shutdown trigger Michael Holzheu
2011-07-27 12:55   ` Michael Holzheu
2011-08-01 20:54   ` Vivek Goyal
2011-08-01 20:54     ` Vivek Goyal
2011-08-02  8:05     ` Michael Holzheu
2011-08-02  8:05       ` Michael Holzheu
2011-07-27 12:55 ` [patch v2 06/10] s390: Export store_status() function Michael Holzheu
2011-07-27 12:55   ` Michael Holzheu
2011-07-27 12:55 ` [patch v2 07/10] s390: Use diagnose 308 for system reset Michael Holzheu
2011-07-27 12:55   ` Michael Holzheu
2011-07-27 12:55 ` [patch v2 08/10] s390: Add real memory access functions Michael Holzheu
2011-07-27 12:55   ` Michael Holzheu
2011-07-27 12:55 ` [patch v2 09/10] s390: kdump backend code Michael Holzheu
2011-07-27 12:55   ` Michael Holzheu
2011-07-27 12:55 ` [patch v2 10/10] kexec-tools: Add s390 kdump support Michael Holzheu
2011-07-27 12:55   ` Michael Holzheu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110802185530.GH6399@redhat.com \
    --to=vgoyal@redhat.com \
    --cc=ebiederm@xmission.com \
    --cc=hbabu@us.ibm.com \
    --cc=heiko.carstens@de.ibm.com \
    --cc=holzheu@linux.vnet.ibm.com \
    --cc=horms@verge.net.au \
    --cc=kexec@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-s390@vger.kernel.org \
    --cc=mahesh@linux.vnet.ibm.com \
    --cc=oomichi@mxs.nes.nec.co.jp \
    --cc=schwidefsky@de.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.