From: Mika Westerberg <mika.westerberg@linux.intel.com>
To: H Hartley Sweeten <hartleys@visionengravers.com>
Cc: Linux Kernel <linux-kernel@vger.kernel.org>,
"linux-watchdog@vger.kernel.org" <linux-watchdog@vger.kernel.org>,
"wim@iguana.be" <wim@iguana.be>
Subject: Re: [RFC PATCH] watchdog: ep93xx: Use the WatchDog Timer Driver Core.
Date: Wed, 3 Aug 2011 11:15:59 +0300 [thread overview]
Message-ID: <20110803081559.GI13218@intel.com> (raw)
In-Reply-To: <ADE657CA350FB648AAC2C43247A983F001F3882B8535@AUSP01VMBX24.collaborationhost.net>
On Tue, Aug 02, 2011 at 11:55:36AM -0500, H Hartley Sweeten wrote:
> >> -static const struct watchdog_info ident = {
> >> - .options = WDIOF_CARDRESET | WDIOF_MAGICCLOSE,
> >> - .identity = "EP93xx Watchdog",
> >> +static const struct watchdog_info ep93xx_wdt_ident = {
> >> + .options = WDIOF_CARDRESET | WDIOF_MAGICCLOSE,
> >> + .identity = "EP93xx Watchdog",
> >> };
One more thing I noticed: you should add WDIOF_KEEPALIVEPING to the options
field. Otherwise it doesn't support ioctl(..., WDIOC_KEEPALIVE) which was
supported in the original driver.
next prev parent reply other threads:[~2011-08-03 8:15 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-01 20:57 [RFC PATCH] watchdog: ep93xx: Use the WatchDog Timer Driver Core H Hartley Sweeten
2011-08-02 9:16 ` Mika Westerberg
2011-08-02 16:55 ` H Hartley Sweeten
2011-08-02 16:55 ` H Hartley Sweeten
2011-08-03 8:15 ` Mika Westerberg [this message]
2011-08-03 16:22 ` H Hartley Sweeten
2011-08-03 16:22 ` H Hartley Sweeten
2011-08-03 9:56 ` Wim Van Sebroeck
2011-08-02 9:57 ` Wim Van Sebroeck
2011-08-02 17:02 ` H Hartley Sweeten
2011-08-02 17:02 ` H Hartley Sweeten
2011-08-03 10:07 ` Wim Van Sebroeck
2011-08-03 16:34 ` H Hartley Sweeten
2011-08-03 16:34 ` H Hartley Sweeten
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110803081559.GI13218@intel.com \
--to=mika.westerberg@linux.intel.com \
--cc=hartleys@visionengravers.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=wim@iguana.be \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.