All of lore.kernel.org
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@infradead.org>
To: Jan Kara <jack@suse.cz>
Cc: Christoph Hellwig <hch@infradead.org>,
	linux-fsdevel@vger.kernel.org, xfs@oss.sgi.com
Subject: Re: [PATCH 0/2] Improve writeout pattern from xfs_flush_pages()
Date: Thu, 4 Aug 2011 08:19:16 -0400	[thread overview]
Message-ID: <20110804121916.GA17783@infradead.org> (raw)
In-Reply-To: <20110804120724.GA20800@quack.suse.cz>

On Thu, Aug 04, 2011 at 02:07:24PM +0200, Jan Kara wrote:
>   Hmm, BTW, shouldn't the call to xfs_flush_pages() in
> xfs_file_buffered_aio_write() be converted to an asynchronous one? I don't
> quite see a point in waiting for io completion... Generally, flushing of
> the inode there seems of limited usefulness to me since that inode could be
> just a tiny victim not holding much delayallocated blocks.

This comes from commit

	xfs: make inode flush at ENOSPC synchronous

from Dave - before that it was asynchronous and in weird context, so
it seems we defintively need it to be synchronous.  I agree that just
flushing this inode seems like a rather odd handling for ENOSPC.  It's
even more odd as we already use the big hammer before in when we
git ENOSPC in ->write_begin.  The only thing I can imagine is that
this is the last attempt to get anything freed.

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch@infradead.org>
To: Jan Kara <jack@suse.cz>
Cc: Christoph Hellwig <hch@infradead.org>,
	xfs@oss.sgi.com, linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH 0/2] Improve writeout pattern from xfs_flush_pages()
Date: Thu, 4 Aug 2011 08:19:16 -0400	[thread overview]
Message-ID: <20110804121916.GA17783@infradead.org> (raw)
In-Reply-To: <20110804120724.GA20800@quack.suse.cz>

On Thu, Aug 04, 2011 at 02:07:24PM +0200, Jan Kara wrote:
>   Hmm, BTW, shouldn't the call to xfs_flush_pages() in
> xfs_file_buffered_aio_write() be converted to an asynchronous one? I don't
> quite see a point in waiting for io completion... Generally, flushing of
> the inode there seems of limited usefulness to me since that inode could be
> just a tiny victim not holding much delayallocated blocks.

This comes from commit

	xfs: make inode flush at ENOSPC synchronous

from Dave - before that it was asynchronous and in weird context, so
it seems we defintively need it to be synchronous.  I agree that just
flushing this inode seems like a rather odd handling for ENOSPC.  It's
even more odd as we already use the big hammer before in when we
git ENOSPC in ->write_begin.  The only thing I can imagine is that
this is the last attempt to get anything freed.


  reply	other threads:[~2011-08-04 12:19 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-08-03 20:49 [PATCH 0/2] Improve writeout pattern from xfs_flush_pages() Jan Kara
2011-08-03 20:49 ` Jan Kara
2011-08-03 20:49 ` [PATCH 1/2] vfs: Create filemap_flush_range() Jan Kara
2011-08-03 20:49   ` Jan Kara
2011-08-03 20:49 ` [PATCH 2/2] xfs: Call filemap_flush_range() for async xfs_flush_pages() call Jan Kara
2011-08-03 20:49   ` Jan Kara
2011-08-03 22:03   ` Christoph Hellwig
2011-08-03 22:03     ` Christoph Hellwig
2011-08-03 22:34   ` Vivek Goyal
2011-08-03 22:34     ` Vivek Goyal
2011-08-04 10:03     ` Jan Kara
2011-08-04 10:03       ` Jan Kara
2011-08-03 21:42 ` [PATCH 0/2] Improve writeout pattern from xfs_flush_pages() Christoph Hellwig
2011-08-03 21:42   ` Christoph Hellwig
2011-08-04 10:36   ` Jan Kara
2011-08-04 10:36     ` Jan Kara
2011-08-04 10:42     ` Christoph Hellwig
2011-08-04 10:42       ` Christoph Hellwig
2011-08-04 12:07       ` Jan Kara
2011-08-04 12:07         ` Jan Kara
2011-08-04 12:19         ` Christoph Hellwig [this message]
2011-08-04 12:19           ` Christoph Hellwig
2011-08-04 12:37           ` Jan Kara
2011-08-04 12:37             ` Jan Kara
2011-08-04 12:41             ` Christoph Hellwig
2011-08-04 12:41               ` Christoph Hellwig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110804121916.GA17783@infradead.org \
    --to=hch@infradead.org \
    --cc=jack@suse.cz \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=xfs@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.