From: zkabelac@sourceware.org <zkabelac@sourceware.org>
To: lvm-devel@redhat.com
Subject: LVM2 ./WHATS_NEW lib/metadata/metadata.c
Date: 4 Aug 2011 15:18:11 -0000 [thread overview]
Message-ID: <20110804151811.479.qmail@sourceware.org> (raw)
CVSROOT: /cvs/lvm2
Module name: LVM2
Changes by: zkabelac at sourceware.org 2011-08-04 15:18:11
Modified files:
. : WHATS_NEW
lib/metadata : metadata.c
Log message:
Remove unused inconsistent_seqno
Last usage was removed in Petr's commit related to VG mda repair fix
where relaxed check starts to ignore inconsistencies coming from
PVs that are marked MISSING - thus removing unused variable.
Patches:
http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/WHATS_NEW.diff?cvsroot=lvm2&r1=1.2051&r2=1.2052
http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/lib/metadata/metadata.c.diff?cvsroot=lvm2&r1=1.459&r2=1.460
--- LVM2/WHATS_NEW 2011/08/04 14:30:51 1.2051
+++ LVM2/WHATS_NEW 2011/08/04 15:18:10 1.2052
@@ -1,5 +1,6 @@
Version 2.02.87 -
===============================
+ Remove unused inconsistent_seqno variable in _vg_read().
Remove meaningless const type qualifiers on cast type.
Fix memory leak in dmsetup _message() memory allocation error path.
Add test for fcntl error in singlenode client code.
--- LVM2/lib/metadata/metadata.c 2011/06/17 14:39:10 1.459
+++ LVM2/lib/metadata/metadata.c 2011/08/04 15:18:11 1.460
@@ -2835,7 +2835,6 @@
int inconsistent = 0;
int inconsistent_vgid = 0;
int inconsistent_pvs = 0;
- int inconsistent_seqno = 0;
int inconsistent_mdas = 0;
int inconsistent_mda_count = 0;
unsigned use_precommitted = precommitted;
@@ -2931,10 +2930,9 @@
log_very_verbose("Not repairing VG %s metadata seqno (%d != %d) "
"as global/metadata_read_only is set.",
vgname, vg->seqno, correct_vg->seqno);
- else {
+ else
inconsistent = 1;
- inconsistent_seqno = 1;
- }
+
if (vg->seqno > correct_vg->seqno) {
free_vg(correct_vg);
correct_vg = vg;
@@ -3100,10 +3098,9 @@
log_very_verbose("Not repairing VG %s metadata seqno (%d != %d) "
"as global/metadata_read_only is set.",
vgname, vg->seqno, correct_vg->seqno);
- else {
+ else
inconsistent = 1;
- inconsistent_seqno = 1;
- }
+
if (!_update_pv_list(cmd->mem, &all_pvs, vg)) {
_free_pv_list(&all_pvs);
free_vg(vg);
next reply other threads:[~2011-08-04 15:18 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-04 15:18 zkabelac [this message]
-- strict thread matches above, loose matches on Subject: below --
2012-03-12 14:18 LVM2 ./WHATS_NEW lib/metadata/metadata.c zkabelac
2012-02-23 0:11 agk
2012-02-13 11:01 zkabelac
2012-02-13 10:58 zkabelac
2012-02-13 10:51 zkabelac
2011-11-18 19:28 zkabelac
2011-10-24 10:24 zkabelac
2011-08-11 16:31 prajnoha
2011-03-29 21:57 zkabelac
2011-03-11 15:06 prajnoha
2011-03-10 13:12 zkabelac
2010-12-08 10:45 zkabelac
2010-11-29 11:08 zkabelac
2010-08-19 23:03 mbroz
2010-06-22 21:10 mbroz
2010-05-21 12:45 zkabelac
2010-04-01 11:43 agk
2010-03-02 21:56 snitzer
2010-01-21 21:09 wysochanski
2010-01-05 16:01 mbroz
2009-12-18 12:45 mbroz
2009-12-18 12:44 mbroz
2009-12-11 13:14 zkabelac
2009-12-09 19:29 mbroz
2009-08-20 7:03 mbroz
2009-07-16 3:25 wysochanski
2009-05-27 13:19 agk
2009-05-12 19:09 mbroz
2009-05-13 1:43 ` Alasdair G Kergon
2009-04-22 9:31 mbroz
2009-04-10 9:56 mbroz
2009-01-26 22:43 agk
2008-09-25 15:59 mbroz
2008-06-03 17:56 agk
2008-05-08 18:06 agk
2008-04-07 22:12 agk
2008-04-08 10:55 ` Bryn M. Reeves
2008-04-10 16:26 ` Alasdair G Kergon
2008-04-04 15:41 wysochanski
2007-10-12 18:37 wysochanski
2007-10-12 21:18 ` Jun'ichi Nomura
2007-07-02 21:48 wysochanski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110804151811.479.qmail@sourceware.org \
--to=zkabelac@sourceware.org \
--cc=lvm-devel@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.