All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jun'ichi Nomura <j-nomura@ce.jp.nec.com>
To: lvm-devel@redhat.com
Subject: LVM2 ./WHATS_NEW lib/metadata/metadata.c
Date: Fri, 12 Oct 2007 17:18:43 -0400	[thread overview]
Message-ID: <470FE4B3.7040205@ce.jp.nec.com> (raw)
In-Reply-To: <20071012183720.31244.qmail@sourceware.org>

Hi Dave,

Thanks for committing the patches to CVS.

I found a comment below:

wysochanski at sourceware.org wrote:
> +	 * FIXME: leak pv->vg_name
> +	 * Adding dm_pool_free(mem, pv->vg_name) - causes warning w/'const'

since 'pv->vg_name' is allocated after 'pv' from the same pool,
freeing 'pv' will free 'pv->vg_name' as well.
So we don't have to do dm_pool_free(mem, pv->vg_name) here.

However,

> +	 * Perhaps pv->vg_name should be initialized to ORPHAN, not alloc'd
> +	 * memory?

I agree moving pv->vg_name allocation outside of _alloc_pv() is better.

Thanks,
-- 
Jun'ichi Nomura, NEC Corporation of America



  reply	other threads:[~2007-10-12 21:18 UTC|newest]

Thread overview: 43+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-10-12 18:37 LVM2 ./WHATS_NEW lib/metadata/metadata.c wysochanski
2007-10-12 21:18 ` Jun'ichi Nomura [this message]
  -- strict thread matches above, loose matches on Subject: below --
2012-03-12 14:18 zkabelac
2012-02-23  0:11 agk
2012-02-13 11:01 zkabelac
2012-02-13 10:58 zkabelac
2012-02-13 10:51 zkabelac
2011-11-18 19:28 zkabelac
2011-10-24 10:24 zkabelac
2011-08-11 16:31 prajnoha
2011-08-04 15:18 zkabelac
2011-03-29 21:57 zkabelac
2011-03-11 15:06 prajnoha
2011-03-10 13:12 zkabelac
2010-12-08 10:45 zkabelac
2010-11-29 11:08 zkabelac
2010-08-19 23:03 mbroz
2010-06-22 21:10 mbroz
2010-05-21 12:45 zkabelac
2010-04-01 11:43 agk
2010-03-02 21:56 snitzer
2010-01-21 21:09 wysochanski
2010-01-05 16:01 mbroz
2009-12-18 12:45 mbroz
2009-12-18 12:44 mbroz
2009-12-11 13:14 zkabelac
2009-12-09 19:29 mbroz
2009-08-20  7:03 mbroz
2009-07-16  3:25 wysochanski
2009-05-27 13:19 agk
2009-05-12 19:09 mbroz
2009-05-13  1:43 ` Alasdair G Kergon
2009-04-22  9:31 mbroz
2009-04-10  9:56 mbroz
2009-01-26 22:43 agk
2008-09-25 15:59 mbroz
2008-06-03 17:56 agk
2008-05-08 18:06 agk
2008-04-07 22:12 agk
2008-04-08 10:55 ` Bryn M. Reeves
2008-04-10 16:26   ` Alasdair G Kergon
2008-04-04 15:41 wysochanski
2007-07-02 21:48 wysochanski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=470FE4B3.7040205@ce.jp.nec.com \
    --to=j-nomura@ce.jp.nec.com \
    --cc=lvm-devel@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.