From: Greg KH <gregkh@suse.de>
To: Randy Dunlap <rdunlap@xenotime.net>
Cc: Nitin Gupta <ngupta@vflare.org>,
Stephen Rothwell <sfr@canb.auug.org.au>,
Andrew Morton <akpm@linux-foundation.org>,
Dan Magenheimer <dan.magenheimer@oracle.com>,
Valdis Kletnieks <Valdis.Kletnieks@vt.edu>,
linux-mm <linux-mm@kvack.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
linux-fsdevel <linux-fsdevel@vger.kernel.org>
Subject: Re: [PATCH] zcache: Fix build error when sysfs is not defined
Date: Thu, 4 Aug 2011 15:11:31 -0700 [thread overview]
Message-ID: <20110804221131.GA1401@suse.de> (raw)
In-Reply-To: <20110804150524.2dcfcecf.rdunlap@xenotime.net>
On Thu, Aug 04, 2011 at 03:05:24PM -0700, Randy Dunlap wrote:
> On Fri, 11 Feb 2011 23:14:39 -0500 Nitin Gupta wrote:
>
> > Signed-off-by: Nitin Gupta <ngupta@vflare.org>
> > ---
> > drivers/staging/zcache/zcache.c | 2 +-
> > 1 files changed, 1 insertions(+), 1 deletions(-)
> >
> > diff --git a/drivers/staging/zcache/zcache.c b/drivers/staging/zcache/zcache.c
> > index 61be849..8cd3fd8 100644
> > --- a/drivers/staging/zcache/zcache.c
> > +++ b/drivers/staging/zcache/zcache.c
> > @@ -1590,9 +1590,9 @@ __setup("nofrontswap", no_frontswap);
> >
> > static int __init zcache_init(void)
> > {
> > -#ifdef CONFIG_SYSFS
> > int ret = 0;
> >
> > +#ifdef CONFIG_SYSFS
> > ret = sysfs_create_group(mm_kobj, &zcache_attr_group);
> > if (ret) {
> > pr_err("zcache: can't create sysfs\n");
> > --
>
> OMG. This patch still needs to be applied to linux-next 20110804..........
> sad.
Heh, thanks, I'll queue it up soon.
greg k-h
WARNING: multiple messages have this Message-ID (diff)
From: Greg KH <gregkh@suse.de>
To: Randy Dunlap <rdunlap@xenotime.net>
Cc: Nitin Gupta <ngupta@vflare.org>,
Stephen Rothwell <sfr@canb.auug.org.au>,
Andrew Morton <akpm@linux-foundation.org>,
Dan Magenheimer <dan.magenheimer@oracle.com>,
Valdis Kletnieks <Valdis.Kletnieks@vt.edu>,
linux-mm <linux-mm@kvack.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
linux-fsdevel <linux-fsdevel@vger.kernel.org>
Subject: Re: [PATCH] zcache: Fix build error when sysfs is not defined
Date: Thu, 4 Aug 2011 15:11:31 -0700 [thread overview]
Message-ID: <20110804221131.GA1401@suse.de> (raw)
In-Reply-To: <20110804150524.2dcfcecf.rdunlap@xenotime.net>
On Thu, Aug 04, 2011 at 03:05:24PM -0700, Randy Dunlap wrote:
> On Fri, 11 Feb 2011 23:14:39 -0500 Nitin Gupta wrote:
>
> > Signed-off-by: Nitin Gupta <ngupta@vflare.org>
> > ---
> > drivers/staging/zcache/zcache.c | 2 +-
> > 1 files changed, 1 insertions(+), 1 deletions(-)
> >
> > diff --git a/drivers/staging/zcache/zcache.c b/drivers/staging/zcache/zcache.c
> > index 61be849..8cd3fd8 100644
> > --- a/drivers/staging/zcache/zcache.c
> > +++ b/drivers/staging/zcache/zcache.c
> > @@ -1590,9 +1590,9 @@ __setup("nofrontswap", no_frontswap);
> >
> > static int __init zcache_init(void)
> > {
> > -#ifdef CONFIG_SYSFS
> > int ret = 0;
> >
> > +#ifdef CONFIG_SYSFS
> > ret = sysfs_create_group(mm_kobj, &zcache_attr_group);
> > if (ret) {
> > pr_err("zcache: can't create sysfs\n");
> > --
>
> OMG. This patch still needs to be applied to linux-next 20110804..........
> sad.
Heh, thanks, I'll queue it up soon.
greg k-h
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2011-08-04 22:12 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-12 4:14 [PATCH] zcache: Fix build error when sysfs is not defined Nitin Gupta
2011-02-12 4:14 ` Nitin Gupta
2011-08-04 22:05 ` Randy Dunlap
2011-08-04 22:05 ` Randy Dunlap
2011-08-04 22:11 ` Greg KH [this message]
2011-08-04 22:11 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110804221131.GA1401@suse.de \
--to=gregkh@suse.de \
--cc=Valdis.Kletnieks@vt.edu \
--cc=akpm@linux-foundation.org \
--cc=dan.magenheimer@oracle.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=ngupta@vflare.org \
--cc=rdunlap@xenotime.net \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.