From: Dave Chinner <david@fromorbit.com>
To: Josef Bacik <josef@redhat.com>
Cc: linux-fsdevel@vger.kernel.org, xfs@oss.sgi.com
Subject: Re: [PATCH] xfstests: fsx: fix fallocate logging
Date: Tue, 9 Aug 2011 20:06:58 +1000 [thread overview]
Message-ID: <20110809100658.GQ3162@dastard> (raw)
In-Reply-To: <1312818914-9950-1-git-send-email-josef@redhat.com>
On Mon, Aug 08, 2011 at 11:55:14AM -0400, Josef Bacik wrote:
> I've been getting segfaults on fsx tests with btrfs because we're using the
> wrong values for the logging with fallocate. We were using the numbers 1,2 and
> 3 to indicate the type of preallocate we were doing, however we use these to
> point to an array, so obviously array[3] for a 3 element array is wrong, so fix
> these to do 0,1, and 2. Also spit out of we're using KEEP_SIZE in the log to
> make it easier to figure out what's going on. Thanks,
>
> Signed-off-by: Josef Bacik <josef@redhat.com>
Already fixed.
http://git.kernel.org/?p=fs/xfs/xfstests-dev.git;a=commit;h=77c06202484237e26774efbd1774c251b6bef0a9
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
WARNING: multiple messages have this Message-ID (diff)
From: Dave Chinner <david@fromorbit.com>
To: Josef Bacik <josef@redhat.com>
Cc: xfs@oss.sgi.com, linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH] xfstests: fsx: fix fallocate logging
Date: Tue, 9 Aug 2011 20:06:58 +1000 [thread overview]
Message-ID: <20110809100658.GQ3162@dastard> (raw)
In-Reply-To: <1312818914-9950-1-git-send-email-josef@redhat.com>
On Mon, Aug 08, 2011 at 11:55:14AM -0400, Josef Bacik wrote:
> I've been getting segfaults on fsx tests with btrfs because we're using the
> wrong values for the logging with fallocate. We were using the numbers 1,2 and
> 3 to indicate the type of preallocate we were doing, however we use these to
> point to an array, so obviously array[3] for a 3 element array is wrong, so fix
> these to do 0,1, and 2. Also spit out of we're using KEEP_SIZE in the log to
> make it easier to figure out what's going on. Thanks,
>
> Signed-off-by: Josef Bacik <josef@redhat.com>
Already fixed.
http://git.kernel.org/?p=fs/xfs/xfstests-dev.git;a=commit;h=77c06202484237e26774efbd1774c251b6bef0a9
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
next prev parent reply other threads:[~2011-08-09 10:07 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-08 15:55 [PATCH] xfstests: fsx: fix fallocate logging Josef Bacik
2011-08-08 15:55 ` Josef Bacik
2011-08-09 10:06 ` Dave Chinner [this message]
2011-08-09 10:06 ` Dave Chinner
2011-08-09 12:03 ` Josef Bacik
2011-08-09 12:03 ` Josef Bacik
2011-08-14 16:18 ` Christoph Hellwig
2011-08-14 16:18 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110809100658.GQ3162@dastard \
--to=david@fromorbit.com \
--cc=josef@redhat.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.