From: Tony Lindgren <tony@atomide.com>
To: Russell King - ARM Linux <linux@arm.linux.org.uk>
Cc: Santosh <santosh.shilimkar@ti.com>,
linux-arm-kernel@lists.infradead.org, linux-omap@vger.kernel.org,
Peter Ujfalusi <peter.ujfalusi@ti.com>,
Felipe Balbi <balbi@ti.com>, Arnd Bergmann <arnd@arndb.de>
Subject: Re: OMAP3 kernels fail to build
Date: Tue, 9 Aug 2011 06:16:22 -0700 [thread overview]
Message-ID: <20110809131622.GS1866@atomide.com> (raw)
In-Reply-To: <20110808113039.GB15134@n2100.arm.linux.org.uk>
* Russell King - ARM Linux <linux@arm.linux.org.uk> [110808 04:25]:
> On Mon, Aug 08, 2011 at 04:39:32PM +0530, Santosh wrote:
> > + Felipe,
> >
> > On Monday 08 August 2011 04:30 PM, Russell King - ARM Linux wrote:
> >> With CONFIG_ARCH_OMAP3=y and CONFIG_ARCH_OMAP4=n, I'm getting this:
> >>
> >> arch/arm/mach-omap2/built-in.o:(.data+0xf99c): undefined reference to `omap4430_phy_init'
> >> arch/arm/mach-omap2/built-in.o:(.data+0xf9a0): undefined reference to `omap4430_phy_exit'
> >> arch/arm/mach-omap2/built-in.o:(.data+0xf9a4): undefined reference to `omap4430_phy_power'
> >> arch/arm/mach-omap2/built-in.o:(.data+0xf9a8): undefined reference to `omap4430_phy_set_clk'
> >> arch/arm/mach-omap2/built-in.o:(.data+0xf9ac): undefined reference to `omap4430_phy_suspend'
> >>
> > I thought below patch was suppose to fix it.
> > https://patchwork.kernel.org/patch/963462/
>
> So, the problem has been known about for around a month. Yet the broken
> patch still went upstream.
>
> vvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvv
> IF IT IS KNOWN THAT A PATCH IS BROKEN IT MUST NOT BE SUBMITTED TO MAINLINE
> ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
>
> We've seen other instances of that during this merge window, and Linus
> has responded thusly to these incidents:
Sorry I guess I just went into vacation mode and stopped applying patches.
Regards,
Tony
WARNING: multiple messages have this Message-ID (diff)
From: tony@atomide.com (Tony Lindgren)
To: linux-arm-kernel@lists.infradead.org
Subject: OMAP3 kernels fail to build
Date: Tue, 9 Aug 2011 06:16:22 -0700 [thread overview]
Message-ID: <20110809131622.GS1866@atomide.com> (raw)
In-Reply-To: <20110808113039.GB15134@n2100.arm.linux.org.uk>
* Russell King - ARM Linux <linux@arm.linux.org.uk> [110808 04:25]:
> On Mon, Aug 08, 2011 at 04:39:32PM +0530, Santosh wrote:
> > + Felipe,
> >
> > On Monday 08 August 2011 04:30 PM, Russell King - ARM Linux wrote:
> >> With CONFIG_ARCH_OMAP3=y and CONFIG_ARCH_OMAP4=n, I'm getting this:
> >>
> >> arch/arm/mach-omap2/built-in.o:(.data+0xf99c): undefined reference to `omap4430_phy_init'
> >> arch/arm/mach-omap2/built-in.o:(.data+0xf9a0): undefined reference to `omap4430_phy_exit'
> >> arch/arm/mach-omap2/built-in.o:(.data+0xf9a4): undefined reference to `omap4430_phy_power'
> >> arch/arm/mach-omap2/built-in.o:(.data+0xf9a8): undefined reference to `omap4430_phy_set_clk'
> >> arch/arm/mach-omap2/built-in.o:(.data+0xf9ac): undefined reference to `omap4430_phy_suspend'
> >>
> > I thought below patch was suppose to fix it.
> > https://patchwork.kernel.org/patch/963462/
>
> So, the problem has been known about for around a month. Yet the broken
> patch still went upstream.
>
> vvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvv
> IF IT IS KNOWN THAT A PATCH IS BROKEN IT MUST NOT BE SUBMITTED TO MAINLINE
> ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
>
> We've seen other instances of that during this merge window, and Linus
> has responded thusly to these incidents:
Sorry I guess I just went into vacation mode and stopped applying patches.
Regards,
Tony
next prev parent reply other threads:[~2011-08-09 13:16 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-08 11:00 OMAP3 kernels fail to build Russell King - ARM Linux
2011-08-08 11:00 ` Russell King - ARM Linux
2011-08-08 11:09 ` Santosh
2011-08-08 11:09 ` Santosh
2011-08-08 11:30 ` Russell King - ARM Linux
2011-08-08 11:30 ` Russell King - ARM Linux
2011-08-09 13:16 ` Tony Lindgren [this message]
2011-08-09 13:16 ` Tony Lindgren
2011-08-10 5:26 ` Paul Walmsley
2011-08-10 5:26 ` Paul Walmsley
2011-08-10 7:27 ` Russell King - ARM Linux
2011-08-10 7:27 ` Russell King - ARM Linux
2011-08-10 9:18 ` Tony Lindgren
2011-08-10 9:18 ` Tony Lindgren
2011-08-09 11:17 ` Péter Ujfalusi
2011-08-09 11:17 ` Péter Ujfalusi
2011-08-09 12:36 ` [PATCH] OMAP: Fix linking error in twl-common.c for OMAP2/3/4 only builds Peter Ujfalusi
2011-08-09 12:36 ` Peter Ujfalusi
2011-08-10 9:15 ` Tony Lindgren
2011-08-10 9:15 ` Tony Lindgren
2011-08-11 15:07 ` Michael Jones
2011-08-11 15:07 ` Michael Jones
2011-09-28 18:28 ` Tony Lindgren
2011-09-28 18:28 ` Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110809131622.GS1866@atomide.com \
--to=tony@atomide.com \
--cc=arnd@arndb.de \
--cc=balbi@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=peter.ujfalusi@ti.com \
--cc=santosh.shilimkar@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.