From: Robin Holt <holt@sgi.com>
To: Scott Wood <scottwood@freescale.com>
Cc: netdev@vger.kernel.org,
"devicetree-discuss@lists.ozlabs.org"
<devicetree-discuss@lists.ozlabs.org>,
U Bhaskar-B22300 <B22300@freescale.com>,
socketcan-core@lists.berlios.de, Robin Holt <holt@sgi.com>,
PPC list <linuxppc-dev@lists.ozlabs.org>
Subject: Re: [PATCH 5/5] [powerpc] Fix up fsl-flexcan device tree binding.
Date: Tue, 9 Aug 2011 15:59:00 -0500 [thread overview]
Message-ID: <20110809205900.GC4926@sgi.com> (raw)
In-Reply-To: <4E419180.3090507@freescale.com>
I guess my poor wording may have gotten me in trouble. I am getting
ready to repost this patch, but I want to ensure I am getting it as
right as possible.
I think I should reword the commit message to indicate we are removing
the Documentation/.../fsl-flexcan.txt file which has essentially become
empty and change the p1010si.dtsi file's can nodes to "fsl,p1010-flexcan",
"fsl,flexcan". Is that correct?
Thanks,
Robin
On Tue, Aug 09, 2011 at 02:58:56PM -0500, Scott Wood wrote:
> On 08/09/2011 02:49 PM, Wolfgang Grandegger wrote:
> > Yes. The doc for the bindings we speak about
> >
> > http://lxr.linux.no/#linux+v3.0.1/Documentation/devicetree/bindings/net/can/fsl-flexcan.txt
> >
> > sneaked into the kernel without been presented on any mailing list and
> > without the corresponding driver patch.
>
> It was posted on linuxppc-dev:
> http://patchwork.ozlabs.org/patch/91980/
>
> Though I agree it should have been posted more widely.
>
> > OK, just
> >
> > "fsl,p1010-flexcan"
> >
> > or
> >
> > "fsl,p1010-flexcan", "fsl,flexcan"
>
> I'm ok with the latter, if there's enough in common that it's
> conceivable that a driver wouldn't care. The more specific compatible
> will be there if the driver wants to make use of it later.
>
> -Scot
WARNING: multiple messages have this Message-ID (diff)
From: Robin Holt <holt@sgi.com>
To: Scott Wood <scottwood@freescale.com>
Cc: Wolfgang Grandegger <wg@grandegger.com>,
Robin Holt <holt@sgi.com>, Marc Kleine-Budde <mkl@pengutronix.de>,
U Bhaskar-B22300 <B22300@freescale.com>,
netdev@vger.kernel.org, socketcan-core@lists.berlios.de,
PPC list <linuxppc-dev@lists.ozlabs.org>,
"devicetree-discuss@lists.ozlabs.org"
<devicetree-discuss@lists.ozlabs.org>
Subject: Re: [PATCH 5/5] [powerpc] Fix up fsl-flexcan device tree binding.
Date: Tue, 9 Aug 2011 15:59:00 -0500 [thread overview]
Message-ID: <20110809205900.GC4926@sgi.com> (raw)
In-Reply-To: <4E419180.3090507@freescale.com>
I guess my poor wording may have gotten me in trouble. I am getting
ready to repost this patch, but I want to ensure I am getting it as
right as possible.
I think I should reword the commit message to indicate we are removing
the Documentation/.../fsl-flexcan.txt file which has essentially become
empty and change the p1010si.dtsi file's can nodes to "fsl,p1010-flexcan",
"fsl,flexcan". Is that correct?
Thanks,
Robin
On Tue, Aug 09, 2011 at 02:58:56PM -0500, Scott Wood wrote:
> On 08/09/2011 02:49 PM, Wolfgang Grandegger wrote:
> > Yes. The doc for the bindings we speak about
> >
> > http://lxr.linux.no/#linux+v3.0.1/Documentation/devicetree/bindings/net/can/fsl-flexcan.txt
> >
> > sneaked into the kernel without been presented on any mailing list and
> > without the corresponding driver patch.
>
> It was posted on linuxppc-dev:
> http://patchwork.ozlabs.org/patch/91980/
>
> Though I agree it should have been posted more widely.
>
> > OK, just
> >
> > "fsl,p1010-flexcan"
> >
> > or
> >
> > "fsl,p1010-flexcan", "fsl,flexcan"
>
> I'm ok with the latter, if there's enough in common that it's
> conceivable that a driver wouldn't care. The more specific compatible
> will be there if the driver wants to make use of it later.
>
> -Scot
next prev parent reply other threads:[~2011-08-09 20:59 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-09 14:43 [Patch 0/5] [flexcan/powerpc] Add support for powerpc flexcan (freescale p1010) -V9 Robin Holt
2011-08-09 14:43 ` Robin Holt
2011-08-09 14:43 ` [PATCH 1/5] [flexcan] Remove #include <mach/clock.h> Robin Holt
2011-08-09 14:43 ` Robin Holt
2011-08-09 14:43 ` [PATCH 2/5] [flexcan] Abstract off read/write for big/little endian Robin Holt
2011-08-09 14:43 ` Robin Holt
2011-08-09 14:43 ` [PATCH 3/5] [flexcan] Add of_match to platform_device definition Robin Holt
2011-08-09 14:43 ` Robin Holt
2011-08-09 14:43 ` [PATCH 4/5] [powerpc] Add flexcan device support for p1010rdb Robin Holt
2011-08-09 14:43 ` Robin Holt
2011-08-09 14:43 ` [PATCH 5/5] [powerpc] Fix up fsl-flexcan device tree binding Robin Holt
2011-08-09 14:43 ` Robin Holt
2011-08-09 18:17 ` Scott Wood
2011-08-09 18:17 ` Scott Wood
2011-08-09 18:45 ` Robin Holt
2011-08-09 18:45 ` Robin Holt
2011-08-09 19:13 ` Scott Wood
2011-08-09 19:13 ` Scott Wood
2011-08-09 19:13 ` Scott Wood
2011-08-09 19:49 ` Wolfgang Grandegger
2011-08-09 19:49 ` Wolfgang Grandegger
2011-08-09 19:58 ` Scott Wood
2011-08-09 19:58 ` Scott Wood
2011-08-09 19:58 ` Scott Wood
2011-08-09 20:59 ` Robin Holt [this message]
2011-08-09 20:59 ` Robin Holt
2011-08-10 14:52 ` Kumar Gala
2011-08-10 14:52 ` Kumar Gala
2011-08-10 16:16 ` Robin Holt
2011-08-10 16:16 ` Robin Holt
2011-08-09 19:32 ` Wolfgang Grandegger
2011-08-09 19:32 ` Wolfgang Grandegger
2011-08-09 20:11 ` Scott Wood
2011-08-09 20:11 ` Scott Wood
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110809205900.GC4926@sgi.com \
--to=holt@sgi.com \
--cc=B22300@freescale.com \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=netdev@vger.kernel.org \
--cc=scottwood@freescale.com \
--cc=socketcan-core@lists.berlios.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.