All of lore.kernel.org
 help / color / mirror / Atom feed
From: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
To: Ian Campbell <Ian.Campbell@eu.citrix.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>,
	Jeremy Fitzhardinge <Jeremy.Fitzhardinge@citrix.com>,
	Stefano Stabellini <Stefano.Stabellini@eu.citrix.com>
Subject: Re: [Xen-devel] Re: [PATCH] xen: modify kernel mappings corresponding to granted pages
Date: Wed, 10 Aug 2011 09:50:33 -0400	[thread overview]
Message-ID: <20110810135033.GA6672@dumpdata.com> (raw)
In-Reply-To: <1312963564.26263.154.camel@zakaz.uk.xensource.com>

On Wed, Aug 10, 2011 at 09:06:04AM +0100, Ian Campbell wrote:
> On Tue, 2011-08-09 at 16:50 +0100, Konrad Rzeszutek Wilk wrote:
> > > > So I hadn't looked at this in detail, but I wonder if we can use the
> > > > MULTIcall for this? It looks like we need to do two hypercalls so why
> > > > not batch it?
> > > 
> > > That was going to be my next question. We should definitely batch these
> > > if possible.
> > > 
> > > > And while we are it - we could change the MMU ops to only do this on
> > > > initial domain and for the domU case do the old mechanism?
> > > 
> > > We need this in domU for driver domains and the like, don't we?
> > 
> > Sure, but I believe the majority of domU domains would not require this.
> 
> The overhead of this stuff is low if not used, isn't it? Compared with
> the complexity of having domains know if they might be used as a driver
> domain or not that seems like the tradeoff to be aiming for.
> 
> > I was thinking that when we start playing with the device/driver domains
> > we would want to escalate the privilige level (or perhaps not)?
> 
> We don't want any escalation of privilege over and above what is
> necessary to be a driver domain, which is generally none.
> 
> >  Or
> > perhaps introcuce a new type - "if (xen_driver_domain())" to recognize
> > that we are special ?
> 
> Where does the information to set xen_driver_domain == TRUE come from?

No idea. Was just thinking about it.. but you have convienced me it
is not worth looking at.

WARNING: multiple messages have this Message-ID (diff)
From: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
To: Ian Campbell <Ian.Campbell@eu.citrix.com>
Cc: Jeremy Fitzhardinge <Jeremy.Fitzhardinge@citrix.com>,
	"xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	Stefano Stabellini <Stefano.Stabellini@eu.citrix.com>
Subject: Re: Re: [PATCH] xen: modify kernel mappings corresponding to granted pages
Date: Wed, 10 Aug 2011 09:50:33 -0400	[thread overview]
Message-ID: <20110810135033.GA6672@dumpdata.com> (raw)
In-Reply-To: <1312963564.26263.154.camel@zakaz.uk.xensource.com>

On Wed, Aug 10, 2011 at 09:06:04AM +0100, Ian Campbell wrote:
> On Tue, 2011-08-09 at 16:50 +0100, Konrad Rzeszutek Wilk wrote:
> > > > So I hadn't looked at this in detail, but I wonder if we can use the
> > > > MULTIcall for this? It looks like we need to do two hypercalls so why
> > > > not batch it?
> > > 
> > > That was going to be my next question. We should definitely batch these
> > > if possible.
> > > 
> > > > And while we are it - we could change the MMU ops to only do this on
> > > > initial domain and for the domU case do the old mechanism?
> > > 
> > > We need this in domU for driver domains and the like, don't we?
> > 
> > Sure, but I believe the majority of domU domains would not require this.
> 
> The overhead of this stuff is low if not used, isn't it? Compared with
> the complexity of having domains know if they might be used as a driver
> domain or not that seems like the tradeoff to be aiming for.
> 
> > I was thinking that when we start playing with the device/driver domains
> > we would want to escalate the privilige level (or perhaps not)?
> 
> We don't want any escalation of privilege over and above what is
> necessary to be a driver domain, which is generally none.
> 
> >  Or
> > perhaps introcuce a new type - "if (xen_driver_domain())" to recognize
> > that we are special ?
> 
> Where does the information to set xen_driver_domain == TRUE come from?

No idea. Was just thinking about it.. but you have convienced me it
is not worth looking at.

  reply	other threads:[~2011-08-10 13:51 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-07-26 16:55 [PATCH] xen: modify kernel mappings corresponding to granted pages stefano.stabellini
2011-08-09  2:34 ` Konrad Rzeszutek Wilk
2011-08-09 12:30   ` Ian Campbell
2011-08-09 12:30     ` Ian Campbell
2011-08-09 15:50     ` Konrad Rzeszutek Wilk
2011-08-10  8:06       ` Ian Campbell
2011-08-10 13:50         ` Konrad Rzeszutek Wilk [this message]
2011-08-10 13:50           ` Konrad Rzeszutek Wilk
2011-09-06 16:19   ` Stefano Stabellini
2011-09-06 16:19     ` Stefano Stabellini
2011-08-09 11:08 ` Ian Campbell
2011-08-10  8:23 ` Ian Campbell
2011-08-10  8:23   ` Ian Campbell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110810135033.GA6672@dumpdata.com \
    --to=konrad.wilk@oracle.com \
    --cc=Ian.Campbell@eu.citrix.com \
    --cc=Jeremy.Fitzhardinge@citrix.com \
    --cc=Stefano.Stabellini@eu.citrix.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=xen-devel@lists.xensource.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.