From: Tony Lindgren <tony@atomide.com>
To: Hemant Pedanekar <hemantp@ti.com>
Cc: linux-omap@vger.kernel.org, Russell King <linux@arm.linux.org.uk>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] omap: timer: Set dmtimer used as clocksource in autoreload mode
Date: Wed, 10 Aug 2011 07:37:32 -0700 [thread overview]
Message-ID: <20110810143732.GN1939@atomide.com> (raw)
In-Reply-To: <1312982375-11848-1-git-send-email-hemantp@ti.com>
* Hemant Pedanekar <hemantp@ti.com> [110810 06:14]:
> If CONFIG_OMAP_32K_TIMER is not selected and dmtimer is used as clocksource, the
> timer stops counting once overflow occurs as it was not set in autoreload mode.
> This results into timekeeping failure: for example, 'sleep 1' at the shell after
> the timer counter overflow would hang.
>
> This patch sets up autoreload when starting the clocksource timer which fixes
> the above issue.
Thanks for updating this, will apply into fixes.
Tony
>
> Signed-off-by: Hemant Pedanekar <hemantp@ti.com>
> ---
> arch/arm/mach-omap2/timer.c | 3 ++-
> 1 files changed, 2 insertions(+), 1 deletions(-)
>
> diff --git a/arch/arm/mach-omap2/timer.c b/arch/arm/mach-omap2/timer.c
> index e964072..cf1de7d 100644
> --- a/arch/arm/mach-omap2/timer.c
> +++ b/arch/arm/mach-omap2/timer.c
> @@ -293,7 +293,8 @@ static void __init omap2_gp_clocksource_init(int gptimer_id,
> pr_info("OMAP clocksource: GPTIMER%d at %lu Hz\n",
> gptimer_id, clksrc.rate);
>
> - __omap_dm_timer_load_start(clksrc.io_base, OMAP_TIMER_CTRL_ST, 0, 1);
> + __omap_dm_timer_load_start(clksrc.io_base,
> + OMAP_TIMER_CTRL_ST | OMAP_TIMER_CTRL_AR, 0, 1);
> init_sched_clock(&cd, dmtimer_update_sched_clock, 32, clksrc.rate);
>
> if (clocksource_register_hz(&clocksource_gpt, clksrc.rate))
> --
> 1.7.3.5
>
WARNING: multiple messages have this Message-ID (diff)
From: tony@atomide.com (Tony Lindgren)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2] omap: timer: Set dmtimer used as clocksource in autoreload mode
Date: Wed, 10 Aug 2011 07:37:32 -0700 [thread overview]
Message-ID: <20110810143732.GN1939@atomide.com> (raw)
In-Reply-To: <1312982375-11848-1-git-send-email-hemantp@ti.com>
* Hemant Pedanekar <hemantp@ti.com> [110810 06:14]:
> If CONFIG_OMAP_32K_TIMER is not selected and dmtimer is used as clocksource, the
> timer stops counting once overflow occurs as it was not set in autoreload mode.
> This results into timekeeping failure: for example, 'sleep 1' at the shell after
> the timer counter overflow would hang.
>
> This patch sets up autoreload when starting the clocksource timer which fixes
> the above issue.
Thanks for updating this, will apply into fixes.
Tony
>
> Signed-off-by: Hemant Pedanekar <hemantp@ti.com>
> ---
> arch/arm/mach-omap2/timer.c | 3 ++-
> 1 files changed, 2 insertions(+), 1 deletions(-)
>
> diff --git a/arch/arm/mach-omap2/timer.c b/arch/arm/mach-omap2/timer.c
> index e964072..cf1de7d 100644
> --- a/arch/arm/mach-omap2/timer.c
> +++ b/arch/arm/mach-omap2/timer.c
> @@ -293,7 +293,8 @@ static void __init omap2_gp_clocksource_init(int gptimer_id,
> pr_info("OMAP clocksource: GPTIMER%d at %lu Hz\n",
> gptimer_id, clksrc.rate);
>
> - __omap_dm_timer_load_start(clksrc.io_base, OMAP_TIMER_CTRL_ST, 0, 1);
> + __omap_dm_timer_load_start(clksrc.io_base,
> + OMAP_TIMER_CTRL_ST | OMAP_TIMER_CTRL_AR, 0, 1);
> init_sched_clock(&cd, dmtimer_update_sched_clock, 32, clksrc.rate);
>
> if (clocksource_register_hz(&clocksource_gpt, clksrc.rate))
> --
> 1.7.3.5
>
next prev parent reply other threads:[~2011-08-10 14:37 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-10 13:19 [PATCH v2] omap: timer: Set dmtimer used as clocksource in autoreload mode Hemant Pedanekar
2011-08-10 13:19 ` Hemant Pedanekar
2011-08-10 13:19 ` Hemant Pedanekar
2011-08-10 14:37 ` Tony Lindgren [this message]
2011-08-10 14:37 ` Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110810143732.GN1939@atomide.com \
--to=tony@atomide.com \
--cc=hemantp@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.