From: Robin Holt <holt@sgi.com>
To: Scott Wood <scottwood@freescale.com>
Cc: socketcan-core@lists.berlios.de, netdev@vger.kernel.org,
devicetree-discuss@lists.ozlabs.org,
U Bhaskar-B22300 <B22300@freescale.com>,
Robin Holt <holt@sgi.com>,
PPC list <linuxppc-dev@lists.ozlabs.org>
Subject: Re: [PATCH v11 5/5] powerpc: Fix up fsl-flexcan device tree binding.
Date: Wed, 10 Aug 2011 12:19:33 -0500 [thread overview]
Message-ID: <20110810171933.GW4926@sgi.com> (raw)
In-Reply-To: <4E42B83C.2040705@freescale.com>
On Wed, Aug 10, 2011 at 11:56:28AM -0500, Scott Wood wrote:
> On 08/10/2011 11:27 AM, Robin Holt wrote:
> > -CPI Clock- Can Protocol Interface Clock
> > - This CLK_SRC bit of CTRL(control register) selects the clock source to
> > - the CAN Protocol Interface(CPI) to be either the peripheral clock
> > - (driven by the PLL) or the crystal oscillator clock. The selected clock
> > - is the one fed to the prescaler to generate the Serial Clock (Sclock).
> > - The PRESDIV field of CTRL(control register) controls a prescaler that
> > - generates the Serial Clock (Sclock), whose period defines the
> > - time quantum used to compose the CAN waveform.
> > +- compatible : Should be "fsl,flexcan" and optionally
> > + "fsl,flexcan-<processor>"
>
> fsl,<processor>-flexcan, and it should not be optional, and should come
> before "fsl,flexcan".
>
> Also may want to list fsl,p1010-rdb as a "canonical compatible" for
> anything which is backwards compatible with p1010's implementation.
How do I specify 'canonical compatible'? What would be the use of it
in that implementation?
Robin
WARNING: multiple messages have this Message-ID (diff)
From: Robin Holt <holt-sJ/iWh9BUns@public.gmane.org>
To: Scott Wood <scottwood-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
Cc: socketcan-core-0fE9KPoRgkgATYTw5x5z8w@public.gmane.org,
netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org,
U Bhaskar-B22300 <B22300-KZfg59tc24xl57MIdRCFDg@public.gmane.org>,
Kumar Gala
<galak-XVmvHMARGAS8U2dJNN8I7kB+6BGkLq7r@public.gmane.org>,
Grant Likely
<grant.likely-s3s/WqlpOiPyB63q8FvJNQ@public.gmane.org>,
Marc Kleine-Budde <mkl-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>,
PPC list <linuxppc-dev-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org>,
Wolfgang Grandegger <wg-5Yr1BZd7O62+XT7JhA+gdA@public.gmane.org>
Subject: Re: [PATCH v11 5/5] powerpc: Fix up fsl-flexcan device tree binding.
Date: Wed, 10 Aug 2011 12:19:33 -0500 [thread overview]
Message-ID: <20110810171933.GW4926@sgi.com> (raw)
In-Reply-To: <4E42B83C.2040705-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
On Wed, Aug 10, 2011 at 11:56:28AM -0500, Scott Wood wrote:
> On 08/10/2011 11:27 AM, Robin Holt wrote:
> > -CPI Clock- Can Protocol Interface Clock
> > - This CLK_SRC bit of CTRL(control register) selects the clock source to
> > - the CAN Protocol Interface(CPI) to be either the peripheral clock
> > - (driven by the PLL) or the crystal oscillator clock. The selected clock
> > - is the one fed to the prescaler to generate the Serial Clock (Sclock).
> > - The PRESDIV field of CTRL(control register) controls a prescaler that
> > - generates the Serial Clock (Sclock), whose period defines the
> > - time quantum used to compose the CAN waveform.
> > +- compatible : Should be "fsl,flexcan" and optionally
> > + "fsl,flexcan-<processor>"
>
> fsl,<processor>-flexcan, and it should not be optional, and should come
> before "fsl,flexcan".
>
> Also may want to list fsl,p1010-rdb as a "canonical compatible" for
> anything which is backwards compatible with p1010's implementation.
How do I specify 'canonical compatible'? What would be the use of it
in that implementation?
Robin
next prev parent reply other threads:[~2011-08-10 17:19 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-10 16:27 [PATCH v11 0/5] flexcan/powerpc: Add support for powerpc flexcan (freescale p1010) Robin Holt
2011-08-10 16:27 ` Robin Holt
2011-08-10 16:27 ` [PATCH v11 1/5] flexcan: Remove #include <mach/clock.h> Robin Holt
2011-08-10 16:27 ` Robin Holt
2011-08-10 16:27 ` [PATCH v11 2/5] flexcan: Abstract off read/write for big/little endian Robin Holt
2011-08-10 16:27 ` Robin Holt
2011-08-10 16:27 ` [PATCH v11 3/5] flexcan: Add of_match to platform_device definition Robin Holt
2011-08-10 16:27 ` Robin Holt
2011-08-10 16:27 ` Robin Holt
2011-08-10 16:27 ` [PATCH v11 4/5] powerpc: Add flexcan device support for p1010rdb Robin Holt
2011-08-10 16:27 ` Robin Holt
2011-08-10 17:01 ` Kumar Gala
2011-08-10 17:01 ` Kumar Gala
2011-08-10 18:16 ` Wolfgang Grandegger
2011-08-10 18:16 ` Wolfgang Grandegger
2011-08-11 3:56 ` Robin Holt
2011-08-11 3:56 ` Robin Holt
2011-08-11 7:35 ` Wolfgang Grandegger
2011-08-11 7:35 ` Wolfgang Grandegger
2011-08-11 4:46 ` Kumar Gala
2011-08-11 4:46 ` Kumar Gala
2011-08-11 7:26 ` Wolfgang Grandegger
2011-08-11 7:26 ` Wolfgang Grandegger
2011-08-11 10:42 ` Robin Holt
2011-08-11 10:42 ` Robin Holt
2011-08-11 14:17 ` Kumar Gala
2011-08-11 14:17 ` Kumar Gala
2011-08-10 16:27 ` [PATCH v11 5/5] powerpc: Fix up fsl-flexcan device tree binding Robin Holt
2011-08-10 16:27 ` Robin Holt
2011-08-10 16:27 ` Robin Holt
2011-08-10 16:56 ` Scott Wood
2011-08-10 16:56 ` Scott Wood
2011-08-10 16:56 ` Scott Wood
2011-08-10 17:19 ` Robin Holt [this message]
2011-08-10 17:19 ` Robin Holt
2011-08-10 17:36 ` Scott Wood
2011-08-10 17:36 ` Scott Wood
2011-08-10 17:36 ` Scott Wood
2011-08-10 18:30 ` Robin Holt
2011-08-10 18:30 ` Robin Holt
2011-08-10 18:40 ` Scott Wood
2011-08-10 18:40 ` Scott Wood
2011-08-10 18:40 ` Scott Wood
2011-08-10 18:45 ` Robin Holt
2011-08-10 18:45 ` Robin Holt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110810171933.GW4926@sgi.com \
--to=holt@sgi.com \
--cc=B22300@freescale.com \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=netdev@vger.kernel.org \
--cc=scottwood@freescale.com \
--cc=socketcan-core@lists.berlios.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.