From: Matthew Garrett <mjg@redhat.com>
To: lm-sensors@vger.kernel.org
Subject: Re: [lm-sensors] [PATCH 2/3] hwmon: Fix applesmc temperature
Date: Wed, 10 Aug 2011 17:57:09 +0000 [thread overview]
Message-ID: <20110810175709.GB7667@srcf.ucam.org> (raw)
In-Reply-To: <1312906483-3046-2-git-send-email-mjg@redhat.com>
On Wed, Aug 10, 2011 at 10:41:06AM -0700, Guenter Roeck wrote:
> On Wed, 2011-08-10 at 13:17 -0400, Matthew Garrett wrote:
> > Yeah, my MBA returns these from TCZ3 and TH0F. Typical read value is
> > 0xf978. There may be some other underlying issue that's triggering this,
> > but returning data that's known to be bogus seems unhelpful.
> >
> Sounds like that is a persistent condition, though, not a temporary one.
> Negative values returned from temperature sensors often indicate either
> a non-existing thermistor or a sensor fault.
>
> Personally, I think it would be better to just ignore the returned
> value. Ultimately, you'll have to add an entry into sensors.conf anyway,
> and returning an error just because the returned value _might_ be wrong
> does not seem to be a good idea to me.
We can pretty much guarantee that this hardware won't be running below
freezing in this case. Smarter userspace can see an error and then
ignore the sensor in the UI.
> Either case, -EINVAL seems wrong. Maybe -EIO.
Seems reasonable.
--
Matthew Garrett | mjg59@srcf.ucam.org
_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
next prev parent reply other threads:[~2011-08-10 17:57 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-09 16:14 [lm-sensors] [PATCH 2/3] hwmon: Fix applesmc temperature handling Matthew Garrett
2011-08-10 17:05 ` [lm-sensors] [PATCH 2/3] hwmon: Fix applesmc temperature Guenter Roeck
2011-08-10 17:17 ` Matthew Garrett
2011-08-10 17:41 ` Guenter Roeck
2011-08-10 17:57 ` Matthew Garrett [this message]
2011-08-11 19:36 ` Henrik Rydberg
2011-08-11 19:42 ` Matthew Garrett
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110810175709.GB7667@srcf.ucam.org \
--to=mjg@redhat.com \
--cc=lm-sensors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.