All of lore.kernel.org
 help / color / mirror / Atom feed
From: Matthew Garrett <mjg59@srcf.ucam.org>
To: lm-sensors@vger.kernel.org
Subject: Re: [lm-sensors] [PATCH 2/3] hwmon: Fix applesmc temperature
Date: Thu, 11 Aug 2011 19:42:23 +0000	[thread overview]
Message-ID: <20110811194223.GA30934@srcf.ucam.org> (raw)
In-Reply-To: <1312906483-3046-2-git-send-email-mjg@redhat.com>

On Thu, Aug 11, 2011 at 09:36:22PM +0200, Henrik Rydberg wrote:
> instance, on some models, remove the battery and some temperature
> sensors will start to oscillate between zero and max. Some time ago, I
> tried to come up with a patch which would detect this behavior, so far
> without positive reports. If anything, it would make sense to filter
> the list of available sensors, either dynamically (removing it from
> the sysfs tree) or by clamping the value to zero or
> something. Reporting an error does not seem very useful.

We *know* that the value is incorrect. How is giving it to userspace 
without that information in any way helpful? Once userspace has opened 
the file and performed read(), we need to give it something.

-- 
Matthew Garrett | mjg59@srcf.ucam.org

_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors

      parent reply	other threads:[~2011-08-11 19:42 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-08-09 16:14 [lm-sensors] [PATCH 2/3] hwmon: Fix applesmc temperature handling Matthew Garrett
2011-08-10 17:05 ` [lm-sensors] [PATCH 2/3] hwmon: Fix applesmc temperature Guenter Roeck
2011-08-10 17:17 ` Matthew Garrett
2011-08-10 17:41 ` Guenter Roeck
2011-08-10 17:57 ` Matthew Garrett
2011-08-11 19:36 ` Henrik Rydberg
2011-08-11 19:42 ` Matthew Garrett [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110811194223.GA30934@srcf.ucam.org \
    --to=mjg59@srcf.ucam.org \
    --cc=lm-sensors@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.