From: Michal Hocko <mhocko@suse.cz>
To: Johannes Weiner <jweiner@redhat.com>
Cc: Minchan Kim <minchan.kim@gmail.com>,
Andrew Morton <akpm@linux-foundation.org>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>,
Ying Han <yinghan@google.com>,
Balbir Singh <bsingharora@gmail.com>,
KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>,
Daisuke Nishimura <nishimura@mxp.nes.nec.co.jp>,
Mel Gorman <mel@csn.ul.ie>
Subject: Re: [patch 2/2] mm: vmscan: drop nr_force_scan[] from get_scan_count
Date: Fri, 12 Aug 2011 15:33:52 +0200 [thread overview]
Message-ID: <20110812133352.GD32335@tiehlicka.suse.cz> (raw)
In-Reply-To: <20110812065858.GA6916@redhat.com>
On Fri 12-08-11 08:58:58, Johannes Weiner wrote:
[...]
> From: Johannes Weiner <jweiner@redhat.com>
> Subject: [patch] mm: vmscan: drop nr_force_scan[] from get_scan_count
>
> The nr_force_scan[] tuple holds the effective scan numbers for anon
> and file pages in case the situation called for a forced scan and the
> regularly calculated scan numbers turned out zero.
>
> However, the effective scan number can always be assumed to be
> SWAP_CLUSTER_MAX right before the division into anon and file. The
> numerators and denominator are properly set up for all cases, be it
> force scan for just file, just anon, or both, to do the right thing.
>
> Signed-off-by: Johannes Weiner <jweiner@redhat.com>
Nice. The code is much easier to read.
Reviewed-by: Michal Hocko <mhocko@suse.cz>
--
Michal Hocko
SUSE Labs
SUSE LINUX s.r.o.
Lihovarska 1060/12
190 00 Praha 9
Czech Republic
WARNING: multiple messages have this Message-ID (diff)
From: Michal Hocko <mhocko@suse.cz>
To: Johannes Weiner <jweiner@redhat.com>
Cc: Minchan Kim <minchan.kim@gmail.com>,
Andrew Morton <akpm@linux-foundation.org>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>,
Ying Han <yinghan@google.com>,
Balbir Singh <bsingharora@gmail.com>,
KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>,
Daisuke Nishimura <nishimura@mxp.nes.nec.co.jp>,
Mel Gorman <mel@csn.ul.ie>
Subject: Re: [patch 2/2] mm: vmscan: drop nr_force_scan[] from get_scan_count
Date: Fri, 12 Aug 2011 15:33:52 +0200 [thread overview]
Message-ID: <20110812133352.GD32335@tiehlicka.suse.cz> (raw)
In-Reply-To: <20110812065858.GA6916@redhat.com>
On Fri 12-08-11 08:58:58, Johannes Weiner wrote:
[...]
> From: Johannes Weiner <jweiner@redhat.com>
> Subject: [patch] mm: vmscan: drop nr_force_scan[] from get_scan_count
>
> The nr_force_scan[] tuple holds the effective scan numbers for anon
> and file pages in case the situation called for a forced scan and the
> regularly calculated scan numbers turned out zero.
>
> However, the effective scan number can always be assumed to be
> SWAP_CLUSTER_MAX right before the division into anon and file. The
> numerators and denominator are properly set up for all cases, be it
> force scan for just file, just anon, or both, to do the right thing.
>
> Signed-off-by: Johannes Weiner <jweiner@redhat.com>
Nice. The code is much easier to read.
Reviewed-by: Michal Hocko <mhocko@suse.cz>
--
Michal Hocko
SUSE Labs
SUSE LINUX s.r.o.
Lihovarska 1060/12
190 00 Praha 9
Czech Republic
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2011-08-12 13:33 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-11 20:31 [patch 1/2] mm: vmscan: fix force-scanning small targets without swap Johannes Weiner
2011-08-11 20:31 ` Johannes Weiner
2011-08-11 20:31 ` [patch 2/2] mm: vmscan: drop nr_force_scan[] from get_scan_count Johannes Weiner
2011-08-11 20:31 ` Johannes Weiner
2011-08-11 23:44 ` Minchan Kim
2011-08-11 23:44 ` Minchan Kim
2011-08-12 6:58 ` Johannes Weiner
2011-08-12 6:58 ` Johannes Weiner
2011-08-12 7:04 ` Minchan Kim
2011-08-12 7:04 ` Minchan Kim
2011-08-12 13:33 ` Michal Hocko [this message]
2011-08-12 13:33 ` Michal Hocko
2011-08-17 14:00 ` Mel Gorman
2011-08-17 14:00 ` Mel Gorman
2011-08-17 1:12 ` KAMEZAWA Hiroyuki
2011-08-17 1:12 ` KAMEZAWA Hiroyuki
2011-08-11 23:16 ` [patch 1/2] mm: vmscan: fix force-scanning small targets without swap Minchan Kim
2011-08-11 23:16 ` Minchan Kim
2011-08-12 13:10 ` Michal Hocko
2011-08-12 13:10 ` Michal Hocko
2011-08-12 13:13 ` Michal Hocko
2011-08-12 13:13 ` Michal Hocko
2011-08-17 1:12 ` KAMEZAWA Hiroyuki
2011-08-17 1:12 ` KAMEZAWA Hiroyuki
2011-08-17 13:38 ` Mel Gorman
2011-08-17 13:38 ` Mel Gorman
2011-08-29 16:08 ` Johannes Weiner
2011-08-29 16:08 ` Johannes Weiner
2011-08-31 23:37 ` Andrew Morton
2011-08-31 23:37 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110812133352.GD32335@tiehlicka.suse.cz \
--to=mhocko@suse.cz \
--cc=akpm@linux-foundation.org \
--cc=bsingharora@gmail.com \
--cc=jweiner@redhat.com \
--cc=kamezawa.hiroyu@jp.fujitsu.com \
--cc=kosaki.motohiro@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mel@csn.ul.ie \
--cc=minchan.kim@gmail.com \
--cc=nishimura@mxp.nes.nec.co.jp \
--cc=yinghan@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.