From: Michael Holzheu <holzheu@linux.vnet.ibm.com>
To: vgoyal@redhat.com
Cc: oomichi@mxs.nes.nec.co.jp, linux-s390@vger.kernel.org,
mahesh@linux.vnet.ibm.com, heiko.carstens@de.ibm.com,
linux-kernel@vger.kernel.org, hbabu@us.ibm.com,
horms@verge.net.au, ebiederm@xmission.com,
schwidefsky@de.ibm.com, kexec@lists.infradead.org
Subject: [patch v3 8/8] kexec-tools: Allow to call verify_sha256_digest() from kernel
Date: Fri, 12 Aug 2011 15:48:57 +0200 [thread overview]
Message-ID: <20110812134908.120804811@linux.vnet.ibm.com> (raw)
In-Reply-To: 20110812134849.748973593@linux.vnet.ibm.com
[-- Attachment #1: kexec-tools-s390-kdump-entry.patch --]
[-- Type: text/plain, Size: 2159 bytes --]
From: Michael Holzheu <holzheu@linux.vnet.ibm.com>
For s390 we first want to check if kdump checksums are valid before we start
the kdump kernel. With this patch on s390 the purgatory entry point is
called with a parameter. If the parameter is "0", only the checksum test
is done and the result (0 = ok, 1 = invalid) is passed as return code back
to the caller (kernel). If the parameter is "1", the complete purgatory code
is executed and kdump is started.
Signed-off-by: Michael Holzheu <holzheu@linux.vnet.ibm.com>
---
purgatory/arch/s390/setup-s390.S | 14 ++++++++++++++
purgatory/purgatory.c | 13 ++++++++-----
2 files changed, 22 insertions(+), 5 deletions(-)
--- a/purgatory/arch/s390/setup-s390.S
+++ b/purgatory/arch/s390/setup-s390.S
@@ -11,12 +11,23 @@
.balign 16
purgatory_start:
#ifdef __s390x__
+ larl %r5,gprs_save_area
+ stmg %r6,%r15,0(%r5)
larl %r15,lstack_end
aghi %r15,-160
+
+ clgfi %r2,0
+ je verify_checksums
+
brasl %r14,purgatory
larl %r14,kdump_psw
lpswe 0(%r14)
+verify_checksums:
+ brasl %r14,verify_sha256_digest
+ larl %r5,gprs_save_area
+ lmg %r6,%r15,0(%r5)
+ br %r14
.section ".data"
.balign 16
kdump_psw:
@@ -24,6 +35,9 @@ kdump_psw:
.quad 0x0000000000010010
.bss
+gprs_save_area:
+ .fill 80
+
.balign 4096
lstack:
.skip 4096
--- a/purgatory/purgatory.c
+++ b/purgatory/purgatory.c
@@ -9,7 +9,7 @@
struct sha256_region sha256_regions[SHA256_REGIONS] = {};
sha256_digest_t sha256_digest = { };
-void verify_sha256_digest(void)
+int verify_sha256_digest(void)
{
struct sha256_region *ptr, *end;
sha256_digest_t digest;
@@ -34,16 +34,19 @@ void verify_sha256_digest(void)
printf("%hhx ", sha256_digest[i]);
}
printf("\n");
- for(;;) {
- /* loop forever */
- }
+ return 1;
}
+ return 0;
}
void purgatory(void)
{
printf("I'm in purgatory\n");
setup_arch();
- verify_sha256_digest();
+ if (verify_sha256_digest()) {
+ for(;;) {
+ /* loop forever */
+ }
+ }
post_verification_setup_arch();
}
_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec
WARNING: multiple messages have this Message-ID (diff)
From: Michael Holzheu <holzheu@linux.vnet.ibm.com>
To: vgoyal@redhat.com
Cc: ebiederm@xmission.com, mahesh@linux.vnet.ibm.com,
hbabu@us.ibm.com, oomichi@mxs.nes.nec.co.jp, horms@verge.net.au,
schwidefsky@de.ibm.com, heiko.carstens@de.ibm.com,
kexec@lists.infradead.org, linux-kernel@vger.kernel.org,
linux-s390@vger.kernel.org
Subject: [patch v3 8/8] kexec-tools: Allow to call verify_sha256_digest() from kernel
Date: Fri, 12 Aug 2011 15:48:57 +0200 [thread overview]
Message-ID: <20110812134908.120804811@linux.vnet.ibm.com> (raw)
In-Reply-To: 20110812134849.748973593@linux.vnet.ibm.com
[-- Attachment #1: kexec-tools-s390-kdump-entry.patch --]
[-- Type: text/plain, Size: 2014 bytes --]
From: Michael Holzheu <holzheu@linux.vnet.ibm.com>
For s390 we first want to check if kdump checksums are valid before we start
the kdump kernel. With this patch on s390 the purgatory entry point is
called with a parameter. If the parameter is "0", only the checksum test
is done and the result (0 = ok, 1 = invalid) is passed as return code back
to the caller (kernel). If the parameter is "1", the complete purgatory code
is executed and kdump is started.
Signed-off-by: Michael Holzheu <holzheu@linux.vnet.ibm.com>
---
purgatory/arch/s390/setup-s390.S | 14 ++++++++++++++
purgatory/purgatory.c | 13 ++++++++-----
2 files changed, 22 insertions(+), 5 deletions(-)
--- a/purgatory/arch/s390/setup-s390.S
+++ b/purgatory/arch/s390/setup-s390.S
@@ -11,12 +11,23 @@
.balign 16
purgatory_start:
#ifdef __s390x__
+ larl %r5,gprs_save_area
+ stmg %r6,%r15,0(%r5)
larl %r15,lstack_end
aghi %r15,-160
+
+ clgfi %r2,0
+ je verify_checksums
+
brasl %r14,purgatory
larl %r14,kdump_psw
lpswe 0(%r14)
+verify_checksums:
+ brasl %r14,verify_sha256_digest
+ larl %r5,gprs_save_area
+ lmg %r6,%r15,0(%r5)
+ br %r14
.section ".data"
.balign 16
kdump_psw:
@@ -24,6 +35,9 @@ kdump_psw:
.quad 0x0000000000010010
.bss
+gprs_save_area:
+ .fill 80
+
.balign 4096
lstack:
.skip 4096
--- a/purgatory/purgatory.c
+++ b/purgatory/purgatory.c
@@ -9,7 +9,7 @@
struct sha256_region sha256_regions[SHA256_REGIONS] = {};
sha256_digest_t sha256_digest = { };
-void verify_sha256_digest(void)
+int verify_sha256_digest(void)
{
struct sha256_region *ptr, *end;
sha256_digest_t digest;
@@ -34,16 +34,19 @@ void verify_sha256_digest(void)
printf("%hhx ", sha256_digest[i]);
}
printf("\n");
- for(;;) {
- /* loop forever */
- }
+ return 1;
}
+ return 0;
}
void purgatory(void)
{
printf("I'm in purgatory\n");
setup_arch();
- verify_sha256_digest();
+ if (verify_sha256_digest()) {
+ for(;;) {
+ /* loop forever */
+ }
+ }
post_verification_setup_arch();
}
next prev parent reply other threads:[~2011-08-12 13:49 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-12 13:48 [patch v3 0/8] kdump: Patch series for s390 support (version 3) Michael Holzheu
2011-08-12 13:48 ` Michael Holzheu
2011-08-12 13:48 ` [patch v3 1/8] kdump: Add KEXEC_CRASH_CONTROL_MEMORY_LIMIT Michael Holzheu
2011-08-12 13:48 ` Michael Holzheu
2011-08-12 13:48 ` [patch v3 2/8] kdump: Make kimage_load_crash_segment() weak Michael Holzheu
2011-08-12 13:48 ` Michael Holzheu
2011-08-18 17:15 ` Vivek Goyal
2011-08-18 17:15 ` Vivek Goyal
2011-08-19 13:27 ` Michael Holzheu
2011-08-19 13:27 ` Michael Holzheu
2011-08-19 13:48 ` Vivek Goyal
2011-08-19 13:48 ` Vivek Goyal
2011-08-19 13:48 ` Vivek Goyal
2011-08-19 14:02 ` Michael Holzheu
2011-08-19 14:02 ` Michael Holzheu
2011-08-19 14:02 ` Michael Holzheu
2011-08-19 14:28 ` Martin Schwidefsky
2011-08-19 14:28 ` Martin Schwidefsky
2011-08-19 14:28 ` Martin Schwidefsky
2011-08-19 14:37 ` Vivek Goyal
2011-08-19 14:37 ` Vivek Goyal
2011-08-19 14:37 ` Vivek Goyal
2011-08-19 14:44 ` Martin Schwidefsky
2011-08-19 14:44 ` Martin Schwidefsky
2011-08-19 14:44 ` Martin Schwidefsky
2011-08-12 13:48 ` [patch v3 3/8] kdump: Add size to elfcorehdr kernel parameter Michael Holzheu
2011-08-12 13:48 ` Michael Holzheu
2011-08-17 21:05 ` Vivek Goyal
2011-08-17 21:05 ` Vivek Goyal
2011-08-18 8:47 ` Michael Holzheu
2011-08-18 8:47 ` Michael Holzheu
2011-08-18 17:28 ` Vivek Goyal
2011-08-18 17:28 ` Vivek Goyal
2011-08-18 17:56 ` Michael Holzheu
2011-08-18 17:56 ` Michael Holzheu
2011-08-12 13:48 ` [patch v3 4/8] s390: Add real memory access functions Michael Holzheu
2011-08-12 13:48 ` Michael Holzheu
2011-08-12 13:48 ` [patch v3 5/8] s390: kdump backend code Michael Holzheu
2011-08-12 13:48 ` Michael Holzheu
2011-08-12 13:48 ` [patch v3 6/8] s390: Do first kdump checksum test before really starting kdump Michael Holzheu
2011-08-12 13:48 ` Michael Holzheu
2011-08-12 13:48 ` [patch v3 7/8] kexec-tools: Add s390 kdump support Michael Holzheu
2011-08-12 13:48 ` Michael Holzheu
2011-08-12 13:48 ` Michael Holzheu [this message]
2011-08-12 13:48 ` [patch v3 8/8] kexec-tools: Allow to call verify_sha256_digest() from kernel Michael Holzheu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110812134908.120804811@linux.vnet.ibm.com \
--to=holzheu@linux.vnet.ibm.com \
--cc=ebiederm@xmission.com \
--cc=hbabu@us.ibm.com \
--cc=heiko.carstens@de.ibm.com \
--cc=horms@verge.net.au \
--cc=kexec@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=mahesh@linux.vnet.ibm.com \
--cc=oomichi@mxs.nes.nec.co.jp \
--cc=schwidefsky@de.ibm.com \
--cc=vgoyal@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.