All of lore.kernel.org
 help / color / mirror / Atom feed
From: ben@trinity.fluff.org (Ben Dooks)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: S3C2443: Remove redundant s3c_register_clocks call for init_clocks
Date: Tue, 16 Aug 2011 12:03:30 +0100	[thread overview]
Message-ID: <20110816110330.GB27653@trinity.fluff.org> (raw)
In-Reply-To: <201108160848.25088.heiko@sntech.de>

On Tue, Aug 16, 2011 at 08:48:22AM +0200, Heiko St?bner wrote:
> Am Dienstag, 16. August 2011, 05:04:41 schrieb Axel Lin:
> > Since commit af337f3e633a198034a99450416257ddf2307497
> > "ARM: S3C2443: Move parts of the clock code to common clock file",
> > the init_clocks array is moved to arch/arm/plat-s3c24xx/s3c2443-clock.c.
> > Now we call s3c_register_clocks for init_clocks in
> > s3c2443_common_init_clocks.
> > 
> > Thus we can remove the empty init_clocks array here and remove the
> > redundant s3c_register_clocks call for init_clocks in s3c2443_init_clocks.
> I'm not 100% sure, but you might want to include Kukjin Kim 
> <kgene.kim@samsung.com> who seems to be handling the Samsung-stuff most of the 
> time.
> 
> Heiko

I'll pick this up, as there's plans to turn all the mach-s3c24xxs into
one big directory.
 
> > 
> > Signed-off-by: Axel Lin <axel.lin@gmail.com>
> > ---
> >  arch/arm/mach-s3c2443/clock.c |    7 -------
> >  1 files changed, 0 insertions(+), 7 deletions(-)
> > 
> > diff --git a/arch/arm/mach-s3c2443/clock.c b/arch/arm/mach-s3c2443/clock.c
> > index a1a7176..4018dbe 100644
> > --- a/arch/arm/mach-s3c2443/clock.c
> > +++ b/arch/arm/mach-s3c2443/clock.c
> > @@ -305,9 +305,6 @@ static struct clk init_clocks_off[] = {
> >  	}
> >  };
> > 
> > -static struct clk init_clocks[] = {
> > -};
> > -
> >  /* clocks to add straight away */
> > 
> >  static struct clksrc_clk *clksrcs[] __initdata = {
> > @@ -345,10 +342,6 @@ void __init s3c2443_init_clocks(int xtal)
> >  	for (ptr = 0; ptr < ARRAY_SIZE(clksrcs); ptr++)
> >  		s3c_register_clksrc(clksrcs[ptr], 1);
> > 
> > -	/* register clocks from clock array */
> > -
> > -	s3c_register_clocks(init_clocks, ARRAY_SIZE(init_clocks));
> > -
> >  	/* We must be careful disabling the clocks we are not intending to
> >  	 * be using at boot time, as subsystems such as the LCD which do
> >  	 * their own DMA requests to the bus can cause the system to lockup
> 

-- 
Ben Dooks, ben at fluff.org, http://www.fluff.org/ben/

Large Hadron Colada: A large Pina Colada that makes the universe disappear.

WARNING: multiple messages have this Message-ID (diff)
From: Ben Dooks <ben@trinity.fluff.org>
To: "Heiko Stübner" <heiko@sntech.de>
Cc: linux-arm-kernel@lists.infradead.org,
	Axel Lin <axel.lin@gmail.com>,
	linux-kernel@vger.kernel.org,
	Russell King <linux@arm.linux.org.uk>,
	Ben Dooks <ben-linux@fluff.org>,
	Kukjin Kim <kgene.kim@samsung.com>
Subject: Re: [PATCH] ARM: S3C2443: Remove redundant s3c_register_clocks call for init_clocks
Date: Tue, 16 Aug 2011 12:03:30 +0100	[thread overview]
Message-ID: <20110816110330.GB27653@trinity.fluff.org> (raw)
In-Reply-To: <201108160848.25088.heiko@sntech.de>

On Tue, Aug 16, 2011 at 08:48:22AM +0200, Heiko Stübner wrote:
> Am Dienstag, 16. August 2011, 05:04:41 schrieb Axel Lin:
> > Since commit af337f3e633a198034a99450416257ddf2307497
> > "ARM: S3C2443: Move parts of the clock code to common clock file",
> > the init_clocks array is moved to arch/arm/plat-s3c24xx/s3c2443-clock.c.
> > Now we call s3c_register_clocks for init_clocks in
> > s3c2443_common_init_clocks.
> > 
> > Thus we can remove the empty init_clocks array here and remove the
> > redundant s3c_register_clocks call for init_clocks in s3c2443_init_clocks.
> I'm not 100% sure, but you might want to include Kukjin Kim 
> <kgene.kim@samsung.com> who seems to be handling the Samsung-stuff most of the 
> time.
> 
> Heiko

I'll pick this up, as there's plans to turn all the mach-s3c24xxs into
one big directory.
 
> > 
> > Signed-off-by: Axel Lin <axel.lin@gmail.com>
> > ---
> >  arch/arm/mach-s3c2443/clock.c |    7 -------
> >  1 files changed, 0 insertions(+), 7 deletions(-)
> > 
> > diff --git a/arch/arm/mach-s3c2443/clock.c b/arch/arm/mach-s3c2443/clock.c
> > index a1a7176..4018dbe 100644
> > --- a/arch/arm/mach-s3c2443/clock.c
> > +++ b/arch/arm/mach-s3c2443/clock.c
> > @@ -305,9 +305,6 @@ static struct clk init_clocks_off[] = {
> >  	}
> >  };
> > 
> > -static struct clk init_clocks[] = {
> > -};
> > -
> >  /* clocks to add straight away */
> > 
> >  static struct clksrc_clk *clksrcs[] __initdata = {
> > @@ -345,10 +342,6 @@ void __init s3c2443_init_clocks(int xtal)
> >  	for (ptr = 0; ptr < ARRAY_SIZE(clksrcs); ptr++)
> >  		s3c_register_clksrc(clksrcs[ptr], 1);
> > 
> > -	/* register clocks from clock array */
> > -
> > -	s3c_register_clocks(init_clocks, ARRAY_SIZE(init_clocks));
> > -
> >  	/* We must be careful disabling the clocks we are not intending to
> >  	 * be using at boot time, as subsystems such as the LCD which do
> >  	 * their own DMA requests to the bus can cause the system to lockup
> 

-- 
Ben Dooks, ben@fluff.org, http://www.fluff.org/ben/

Large Hadron Colada: A large Pina Colada that makes the universe disappear.


  reply	other threads:[~2011-08-16 11:03 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-08-16  3:04 [PATCH] ARM: S3C2443: Remove redundant s3c_register_clocks call for init_clocks Axel Lin
2011-08-16  3:04 ` Axel Lin
2011-08-16  6:48 ` Heiko Stübner
2011-08-16  6:48   ` Heiko Stübner
2011-08-16 11:03   ` Ben Dooks [this message]
2011-08-16 11:03     ` Ben Dooks
2011-10-14  7:14 ` Kukjin Kim
2011-10-14  7:14   ` Kukjin Kim

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110816110330.GB27653@trinity.fluff.org \
    --to=ben@trinity.fluff.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.